ITP libunistring 0.9.3-1

ITP libunistring 0.9.3-1

[Erwin Waterlander]

Hi,

I propose package 'libunistring' for cygwin.

Text files are nowadays usually encoded in Unicode, and may consist of 
very different scripts – from Latin letters to Chinese Hanzi –, with 
many kinds of special characters – accents, right-to-left writing marks, 
hyphens, Roman numbers, and much more. But the POSIX platform APIs for 
text do not contain adequate functions for dealing with particular 
properties of many Unicode characters. In fact, the POSIX APIs for text 
have several assumptions at their base which don't hold for Unicode text.

This library provides functions for manipulating Unicode strings and for 
manipulating C strings according to the Unicode standard.

http://www.gnu.org/s/libunistring/

Libunistring is part of major Linux distributions:
Fedora Linux: https://admin.fedoraproject.org/pkgdb/acls/name/libunistring
Suse Linux: 
http://download.opensuse.org/source/distribution/11.4/repo/oss/suse/src/libunistring-0.9.3-2.1.src.rpm
Debian Linux: http://packages.debian.org/search?keywords=libunistring-dev

http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1.tar.bz2
http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1-src.tar.bz2

category: Libs
requires: libgcc1
sdesc: "Library for manipulating Unicode strings."
ldesc: "This library provides functions for manipulating Unicode
strings and for manipulating C strings according to the Unicode standard."

regards,

-- 
Erwin Waterlander

Re: ITP libunistring 0.9.3-1

[Yaakov (Cygwin/X)]

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

On Thu, 2011-10-06 at 22:52 +0200, Erwin Waterlander wrote:
> I propose package 'libunistring' for cygwin.

I presume you have another package in mind which will use this?

> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1.tar.bz2
> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1-src.tar.bz2

There are several packaging issues:

1) Libraries should be packaged in separate runtime and development
packages, so that nothing will break whenever the library ABI changes.

2) Your .cygport file uses internal functions.  This is not supported.

3) You have skipped the cygautoreconf step.  As mentioned in the cygport
documentation, this is strongly discouraged, particularly where libtool
is involved.

Therefore the .cygport should look like:

DESCRIPTION="Unicode string library"
HOMEPAGE="http://www.gnu.org/s/libunistring/"
SRC_URI="mirror://gnu/libunistring/${P}.tar.gz"

PKG_NAMES="libunistring0 libunistring-devel libunistring-doc"
libunistring0_CONTENTS="usr/bin/cygunistring-0.dll"
libunistring_devel_CONTENTS="usr/include/ usr/lib/"
libunistring_doc_CONTENTS="usr/share/doc/ usr/share/info/"

That's it.

4) I see this is one of Bruno's packages.  He has some unconventional
views about the PE format, and Cygwin in particular.  I would suggest
the attached patch.

> category: Libs
> requires: libgcc1
> sdesc: "Library for manipulating Unicode strings."
> ldesc: "This library provides functions for manipulating Unicode
> strings and for manipulating C strings according to the Unicode standard."

You will need separate .hint files for each subpackage, adding the
external-source tag.  You also need to add a libiconv2 dependency to the
runtime package and libiconv to the devel package.


Yaakov


[-- Attachment #2: libunistring-0.9.3-1.src.patch --]
[-- Type: text/x-patch, Size: 1228 bytes --]

--- origsrc/libunistring-0.9.3/configure.ac	2010-03-28 21:35:26.000000000 -0500
+++ src/libunistring-0.9.3/configure.ac	2011-10-06 18:12:24.064566600 -0500
@@ -61,7 +61,7 @@ LT_LANG([Windows Resource])
 dnl On mingw and Cygwin, we can activate special Makefile rules which add
 dnl version information to the shared libraries and executables.
 case "$host_os" in
-  mingw* | cygwin*) is_woe32=yes ;;
+  mingw*) is_woe32=yes ;;
   *) is_woe32=no ;;
 esac
 AM_CONDITIONAL([WOE32], [test $is_woe32 = yes])
@@ -79,7 +79,7 @@ dnl    must arrange to define the auxili
 dnl    exported variables _also_ in the static library.
 if test "$enable_shared" = yes; then
   case "$host_os" in
-    mingw* | cygwin*) is_woe32dll=yes ;;
+    mingw*) is_woe32dll=yes ;;
     *) is_woe32dll=no ;;
   esac
 else
--- origsrc/libunistring-0.9.3/m4/woe32-dll.m4	2009-04-19 13:00:22.000000000 -0500
+++ src/libunistring-0.9.3/m4/woe32-dll.m4	2011-10-06 19:29:25.470649000 -0500
@@ -29,7 +29,7 @@ AC_DEFUN([gl_WOE32_DLL],
 [
   AC_REQUIRE([AC_CANONICAL_HOST])
   case "$host_os" in
-    mingw* | cygwin*)
+    mingw*)
       AC_MSG_CHECKING([for auto-import of symbols])
       AC_CACHE_VAL([gl_cv_ld_autoimport], [
         gl_save_LDFLAGS="$LDFLAGS"

Re: ITP libunistring 0.9.3-1

[Erwin Waterlander]

Op 7-10-2011 3:29, Yaakov (Cygwin/X) schreef:
> On Thu, 2011-10-06 at 22:52 +0200, Erwin Waterlander wrote:
>> I propose package 'libunistring' for cygwin.
> I presume you have another package in mind which will use this?

Yes, I'm going to use it in my own package wcd.

>
>> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1.tar.bz2
>> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1-src.tar.bz2
> There are several packaging issues:
>
> 1) Libraries should be packaged in separate runtime and development
> packages, so that nothing will break whenever the library ABI changes.

OK. I overlooked that. I started with dos2unix's cygport file as an 
example. I'm still learning.

>
> 2) Your .cygport file uses internal functions.  This is not supported.

I see functions used also on other cyport files. I looked at libiconv's 
cygport file.

>
> 3) You have skipped the cygautoreconf step.  As mentioned in the cygport
> documentation, this is strongly discouraged, particularly where libtool
> is involved.
>
> Therefore the .cygport should look like:
>
> DESCRIPTION="Unicode string library"
> HOMEPAGE="http://www.gnu.org/s/libunistring/"
> SRC_URI="mirror://gnu/libunistring/${P}.tar.gz"
>
> PKG_NAMES="libunistring0 libunistring-devel libunistring-doc"
> libunistring0_CONTENTS="usr/bin/cygunistring-0.dll"
> libunistring_devel_CONTENTS="usr/include/ usr/lib/"
> libunistring_doc_CONTENTS="usr/share/doc/ usr/share/info/"
>
> That's it.

Thanks.

>
> 4) I see this is one of Bruno's packages.  He has some unconventional
> views about the PE format, and Cygwin in particular.  I would suggest
> the attached patch.
>
>> category: Libs
>> requires: libgcc1
>> sdesc: "Library for manipulating Unicode strings."
>> ldesc: "This library provides functions for manipulating Unicode
>> strings and for manipulating C strings according to the Unicode standard."
> You will need separate .hint files for each subpackage, adding the
> external-source tag.  You also need to add a libiconv2 dependency to the
> runtime package and libiconv to the devel package.
>
>
>

Thanks. And the source patch should be in a separate file isn't it (not 
included in the cygwin patch).

I create a new package with your improvements.

best regards,

-- 
Erwin Waterlander

Re: ITP libunistring 0.9.3-2

[Erwin Waterlander]

Erwin Waterlander schreef, Op 7-10-2011 12:55:
> Op 7-10-2011 3:29, Yaakov (Cygwin/X) schreef:
>> On Thu, 2011-10-06 at 22:52 +0200, Erwin Waterlander wrote:
>>> I propose package 'libunistring' for cygwin.
>> I presume you have another package in mind which will use this?
>
> Yes, I'm going to use it in my own package wcd.
>
>>
>>> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1.tar.bz2 
>>>
>>> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1-src.tar.bz2 
>>>
>> There are several packaging issues:
>>
>> 1) Libraries should be packaged in separate runtime and development
>> packages, so that nothing will break whenever the library ABI changes.
>
> OK. I overlooked that. I started with dos2unix's cygport file as an 
> example. I'm still learning.
>
>>
>> 2) Your .cygport file uses internal functions.  This is not supported.
>
> I see functions used also on other cyport files. I looked at 
> libiconv's cygport file.
>
>>
>> 3) You have skipped the cygautoreconf step.  As mentioned in the cygport
>> documentation, this is strongly discouraged, particularly where libtool
>> is involved.
>>
>> Therefore the .cygport should look like:
>>
>> DESCRIPTION="Unicode string library"
>> HOMEPAGE="http://www.gnu.org/s/libunistring/"
>> SRC_URI="mirror://gnu/libunistring/${P}.tar.gz"
>>
>> PKG_NAMES="libunistring0 libunistring-devel libunistring-doc"
>> libunistring0_CONTENTS="usr/bin/cygunistring-0.dll"
>> libunistring_devel_CONTENTS="usr/include/ usr/lib/"
>> libunistring_doc_CONTENTS="usr/share/doc/ usr/share/info/"
>>
>> That's it.
>
> Thanks.
>
>>
>> 4) I see this is one of Bruno's packages.  He has some unconventional
>> views about the PE format, and Cygwin in particular.  I would suggest
>> the attached patch.
>>
>>> category: Libs
>>> requires: libgcc1
>>> sdesc: "Library for manipulating Unicode strings."
>>> ldesc: "This library provides functions for manipulating Unicode
>>> strings and for manipulating C strings according to the Unicode 
>>> standard."
>> You will need separate .hint files for each subpackage, adding the
>> external-source tag.  You also need to add a libiconv2 dependency to the
>> runtime package and libiconv to the devel package.
>>
>>
>>
>
> Thanks. And the source patch should be in a separate file isn't it 
> (not included in the cygwin patch).
>
> I create a new package with your improvements.
>
> best regards,
>


Hi,

I created new packages:
http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-2-src.tar.bz2
http://waterlan.home.xs4all.nl/libunistring/libunistring-devel-0.9.3-2.tar.bz2
http://waterlan.home.xs4all.nl/libunistring/libunistring-doc-0.9.3-2.tar.bz2
http://waterlan.home.xs4all.nl/libunistring/libunistring0-0.9.3-2.tar.bz2

I hope these are correct. If not, let me know.

best regards,

-- 
Erwin Waterlander

Re: ITP libunistring 0.9.3-1

[Erwin Waterlander]

Yaakov (Cygwin/X) schreef, Op 7-10-2011 3:29:
> 4) I see this is one of Bruno's packages.  He has some unconventional
> views about the PE format, and Cygwin in particular.

It looks like he considers Cygwin to be part of "Win32", which he 
consistently names "Woe32"...

http://www.gnu.org/software/gettext/FAQ.html#windows_woe32


-- 
Erwin

Re: ITP libunistring 0.9.3-2

[Corinna Vinschen]

On Oct  7 18:57, Erwin Waterlander wrote:
> Hi,
> 
> I created new packages:
> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-2-src.tar.bz2
> http://waterlan.home.xs4all.nl/libunistring/libunistring-devel-0.9.3-2.tar.bz2
> http://waterlan.home.xs4all.nl/libunistring/libunistring-doc-0.9.3-2.tar.bz2
> http://waterlan.home.xs4all.nl/libunistring/libunistring0-0.9.3-2.tar.bz2
> 
> I hope these are correct. If not, let me know.

Packaging looks good afaics, but could you please also provide the
matching setup.hint files for uploading, preferredly in a easily downloadable
form which matches the package directory layout, like this:

  wget -x -nH \
  http://waterlan.home.xs4all.nl/libunistring/setup.hint \
  http://waterlan.home.xs4all.nl/libunistring/libunistring-devel/setup.hint \
  http://waterlan.home.xs4all.nl/libunistring/libunistring-doc/setup.hint \
  http://waterlan.home.xs4all.nl/libunistring/libunistring0/setup.hint \


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Re: ITP libunistring 0.9.3-2

[Erwin Waterlander]

On 10/10/2011 12:04 PM, Corinna Vinschen wrote:
> On Oct  7 18:57, Erwin Waterlander wrote:
>> Hi,
>>
>> I created new packages:
>> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-2-src.tar.bz2
>> http://waterlan.home.xs4all.nl/libunistring/libunistring-devel-0.9.3-2.tar.bz2
>> http://waterlan.home.xs4all.nl/libunistring/libunistring-doc-0.9.3-2.tar.bz2
>> http://waterlan.home.xs4all.nl/libunistring/libunistring0-0.9.3-2.tar.bz2
>>
>> I hope these are correct. If not, let me know.
> Packaging looks good afaics, but could you please also provide the
> matching setup.hint files for uploading, preferredly in a easily downloadable
> form which matches the package directory layout, like this:
>
>    wget -x -nH \
>    http://waterlan.home.xs4all.nl/libunistring/setup.hint \
>    http://waterlan.home.xs4all.nl/libunistring/libunistring-devel/setup.hint \
>    http://waterlan.home.xs4all.nl/libunistring/libunistring-doc/setup.hint \
>    http://waterlan.home.xs4all.nl/libunistring/libunistring0/setup.hint \
>
>
> Thanks,
> Corinna
>

Hi Corinna,

I added the files you requested.

best regards,

Erwin

Re: ITP libunistring 0.9.3-2

[Corinna Vinschen]

On Oct 10 12:39, Erwin Waterlander wrote:
> On 10/10/2011 12:04 PM, Corinna Vinschen wrote:
> >On Oct  7 18:57, Erwin Waterlander wrote:
> >>Hi,
> >>
> >>I created new packages:
> >>http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-2-src.tar.bz2
> >>http://waterlan.home.xs4all.nl/libunistring/libunistring-devel-0.9.3-2.tar.bz2
> >>http://waterlan.home.xs4all.nl/libunistring/libunistring-doc-0.9.3-2.tar.bz2
> >>http://waterlan.home.xs4all.nl/libunistring/libunistring0-0.9.3-2.tar.bz2
> >>
> >>I hope these are correct. If not, let me know.
> >Packaging looks good afaics, but could you please also provide the
> >matching setup.hint files for uploading, preferredly in a easily downloadable
> >form which matches the package directory layout, like this:
> >
> >   wget -x -nH \
> >   http://waterlan.home.xs4all.nl/libunistring/setup.hint \
> >   http://waterlan.home.xs4all.nl/libunistring/libunistring-devel/setup.hint \
> >   http://waterlan.home.xs4all.nl/libunistring/libunistring-doc/setup.hint \
> >   http://waterlan.home.xs4all.nl/libunistring/libunistring0/setup.hint \
> >
> >
> >Thanks,
> >Corinna
> >
> 
> Hi Corinna,
> 
> I added the files you requested.

Thanks.  I think the requirements in the setup.hint files in
libunistring and libunistring-devel are not correct.

libunistring only provides sources.  It has no requirements.
libunistring-devel should require libunistring0 but not libgcc1 since
this is indirectly required by libunistring0.

If that's what you have in mind, I'll change that on cygwin.com and
you just should update your local copy.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Re: ITP libunistring 0.9.3-2

[Erwin Waterlander]

On 10/10/2011 3:26 PM, Corinna Vinschen wrote:
> On Oct 10 12:39, Erwin Waterlander wrote:
>> On 10/10/2011 12:04 PM, Corinna Vinschen wrote:
>>> On Oct  7 18:57, Erwin Waterlander wrote:
>>>> Hi,
>>>>
>>>> I created new packages:
>>>> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-2-src.tar.bz2
>>>> http://waterlan.home.xs4all.nl/libunistring/libunistring-devel-0.9.3-2.tar.bz2
>>>> http://waterlan.home.xs4all.nl/libunistring/libunistring-doc-0.9.3-2.tar.bz2
>>>> http://waterlan.home.xs4all.nl/libunistring/libunistring0-0.9.3-2.tar.bz2
>>>>
>>>> I hope these are correct. If not, let me know.
>>> Packaging looks good afaics, but could you please also provide the
>>> matching setup.hint files for uploading, preferredly in a easily downloadable
>>> form which matches the package directory layout, like this:
>>>
>>>    wget -x -nH \
>>>    http://waterlan.home.xs4all.nl/libunistring/setup.hint \
>>>    http://waterlan.home.xs4all.nl/libunistring/libunistring-devel/setup.hint \
>>>    http://waterlan.home.xs4all.nl/libunistring/libunistring-doc/setup.hint \
>>>    http://waterlan.home.xs4all.nl/libunistring/libunistring0/setup.hint \
>>>
>>>
>>> Thanks,
>>> Corinna
>>>
>> Hi Corinna,
>>
>> I added the files you requested.
> Thanks.  I think the requirements in the setup.hint files in
> libunistring and libunistring-devel are not correct.
>
> libunistring only provides sources.  It has no requirements.
> libunistring-devel should require libunistring0 but not libgcc1 since
> this is indirectly required by libunistring0.
>
> If that's what you have in mind, I'll change that on cygwin.com and
> you just should update your local copy.
>
>
> Corinna
>
Hi Corinna,

Your are correct. Thanks for pointing that out. I have changed my copies.

Erwin

Re: ITP libunistring 0.9.3-2

[Corinna Vinschen]

On Oct 10 15:45, Erwin Waterlander wrote:
> On 10/10/2011 3:26 PM, Corinna Vinschen wrote:
> >Thanks.  I think the requirements in the setup.hint files in
> >libunistring and libunistring-devel are not correct.
> >
> >libunistring only provides sources.  It has no requirements.
> >libunistring-devel should require libunistring0 but not libgcc1 since
> >this is indirectly required by libunistring0.
> >
> >If that's what you have in mind, I'll change that on cygwin.com and
> >you just should update your local copy.
> >
> >
> >Corinna
> >
> Hi Corinna,
> 
> Your are correct. Thanks for pointing that out. I have changed my copies.

Ok, uploaded.  Please send an announcement to the cygwin-announce list.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat