[ITP] Inetutils 1.9.4

[ITP] Inetutils 1.9.4

[D. Boland]

Hi group,

I intend to package the new version of Inetutils, version 1.9.4.

Package inetutils
-----------------
category: Net
requires: bash libgcc1 hostname whois cygwin
sdesc: "Common networking client programs"
ldesc: "inetutils provides common networking clients and
  servers, including the inetd super-server, telnetd and
  telnet, ftpd and ftp, talkd and talk, uucpd (but no uucp
  client), and syslogd."

Package inetutils-server
------------------------
category: Net
requires: bash crypt libgcc1 inetutils tcp_wrappers
sdesc: "Common networking server programs"
ldesc: "inetutils provides common networking clients and
  servers, including the inetd super-server, telnetd and
  telnet, ftpd and ftp, talkd and talk, uucpd (but no uucp
  client), and syslogd."

As you can see, I kept the 'hostname' and 'whois' programs out of the 
distribution, and added them on the 'required' line, see:

https://cygwin.com/ml/cygwin-apps/2015-07/msg00046.html

I guess I could have just announced the update, but since I am adopting 
the package, maybe I should submit it for approval first:

http://cygwin.boland.nl/x86/release/inetutils/

Good-to-go's are welcome!

Daniel

Re: [ITP] Inetutils 1.9.4

[Marco Atzeri]

On 31/10/2015 11:32, D. Boland wrote:
> Hi group,
>
> I intend to package the new version of Inetutils, version 1.9.4.
>
>
> I guess I could have just announced the update, but since I am adopting
> the package, maybe I should submit it for approval first:
>
> http://cygwin.boland.nl/x86/release/inetutils/
>
> Good-to-go's are welcome!
>
> Daniel


tried building for x86_64

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..     -O2 -pipe 
-Wimplicit-function-declaration -MT argp-help.o -MD -MP -MF $depbase.Tpo 
-c -o argp-help.o argp-help.c &&\
mv -f $depbase.Tpo $depbase.Po
depbase=`echo argp-parse.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..     -O2 -pipe 
-Wimplicit-function-declaration -MT argp-parse.o -MD -MP -MF 
$depbase.Tpo -c -o argp-parse.o argp-parse.c &&\
mv -f $depbase.Tpo $depbase.Po
argp-parse.c:28:27: fatal error: fakesu/unistd.h: No such file or directory
  #include <fakesu/unistd.h>

but

$ cygcheck -c libfakesu
Cygwin Package Information
Package              Version        Status
libfakesu            1.1.0-0        OK

$ cygcheck -l libfakesu
/usr/include/fakesu.h
/usr/lib/libfakesu.a
/usr/share/doc/libfakesu/LICENSE
/usr/share/doc/libfakesu/README


Have you forgot to update Fakesu package or there is a wrong include ?

Regards
Marco

Re: [ITP] Inetutils 1.9.4

[D. Boland]

Marco Atzeri wrote:
> $ cygcheck -c libfakesu
> Cygwin Package Information
> Package              Version        Status
> libfakesu            1.1.0-0        OK
> 
> $ cygcheck -l libfakesu
> /usr/include/fakesu.h
> /usr/lib/libfakesu.a
> /usr/share/doc/libfakesu/LICENSE
> /usr/share/doc/libfakesu/README
> 
> 
> Have you forgot to update Fakesu package or there is a wrong include ?
> 
> Regards
> Marco
> 
> 
Oops, sorry about that. I forgot to update. I just updated libfakesu to 
version 1.2.0-0

Sincerely,
Daniel

Re: [ITP] Inetutils 1.9.4

[Marco Atzeri]

On 01/11/2015 00:02, D. Boland wrote:
> Marco Atzeri wrote:
>>
>>
>> Have you forgot to update Fakesu package or there is a wrong include ?
>>
>> Regards
>> Marco
>>
>>
> Oops, sorry about that. I forgot to update. I just updated libfakesu to
> version 1.2.0-0
>
> Sincerely,
> Daniel

Hi Daniel,
with that is still failing a bit later on 64bit:

gcc -std=gnu99  -O2 -pipe -Wimplicit-function-declaration   -o tftp 
tftp.o ../libinetutils/libinetutils.a ../lib/libgnu.a -lutil 
/usr/lib/libfakesu.a
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../lib -I../lib 
-I../libinetutils   -I../libicmp  -DPATH_CONSOLE=\"/dev/console\" 
-DPATH_CP=\"/usr/bin/cp\"   -DPATH_INETDCONF=\"/etc/inetd.conf\" 
-DPATH_INETDDIR=\"/etc/inetd.d\" -DPATH_INETDPID=\"/var/run/inetd.pid\" 
   -DPATH_LOGCONF=\"/etc/syslog.conf\" -DPATH_LOGCONFD=\"/etc/syslog.d\" 
-DPATH_LOGIN=\"/usr/bin/login\" -DPATH_LOGPID=\"/var/run/syslog.pid\" 
-DPATH_NOLOGIN=\"/etc/nologin\" -DPATH_RLOGIN=\"/usr/bin/rlogin\" 
-DPATH_RSH=\"/usr/bin/rsh\"     -DPATH_UUCICO=\"/usr/sbin/uucp/uucico\" 
   -O2 -pipe -Wimplicit-function-declaration -MT traceroute.o -MD -MP 
-MF .deps/traceroute.Tpo -c -o traceroute.o traceroute.c
traceroute.c:110:14: error: 'MAX_IPOPTLEN' undeclared here (not in a 
function)
  char ip_opts[MAX_IPOPTLEN];
               ^
traceroute.c: In function 'get_hostname':
traceroute.c:461:5: warning: return discards 'const' qualifier from 
pointer target type
      return info->h_name;
      ^
Makefile:1691: recipe for target 'traceroute.o' failed
make[2]: *** [traceroute.o] Error 1

Re: [ITP] Inetutils 1.9.4

[D. Boland]

Marco Atzeri wrote:
> 
> 
> On 01/11/2015 00:02, D. Boland wrote:
>> Marco Atzeri wrote:
>>>
>>>
>>> Have you forgot to update Fakesu package or there is a wrong include ?
>>>
>>> Regards
>>> Marco
>>>
>>>
>> Oops, sorry about that. I forgot to update. I just updated libfakesu to
>> version 1.2.0-0
>>
>> Sincerely,
>> Daniel
> 
> Hi Daniel,
> with that is still failing a bit later on 64bit:
> 
> gcc -std=gnu99  -O2 -pipe -Wimplicit-function-declaration   -o tftp 
> tftp.o ../libinetutils/libinetutils.a ../lib/libgnu.a -lutil 
> /usr/lib/libfakesu.a
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../lib -I../lib 
> -I../libinetutils   -I../libicmp  -DPATH_CONSOLE=\"/dev/console\" 
> -DPATH_CP=\"/usr/bin/cp\"   -DPATH_INETDCONF=\"/etc/inetd.conf\" 
> -DPATH_INETDDIR=\"/etc/inetd.d\" -DPATH_INETDPID=\"/var/run/inetd.pid\" 
>   -DPATH_LOGCONF=\"/etc/syslog.conf\" -DPATH_LOGCONFD=\"/etc/syslog.d\" 
> -DPATH_LOGIN=\"/usr/bin/login\" -DPATH_LOGPID=\"/var/run/syslog.pid\" 
> -DPATH_NOLOGIN=\"/etc/nologin\" -DPATH_RLOGIN=\"/usr/bin/rlogin\" 
> -DPATH_RSH=\"/usr/bin/rsh\"     -DPATH_UUCICO=\"/usr/sbin/uucp/uucico\" 
>   -O2 -pipe -Wimplicit-function-declaration -MT traceroute.o -MD -MP -MF 
> .deps/traceroute.Tpo -c -o traceroute.o traceroute.c
> traceroute.c:110:14: error: 'MAX_IPOPTLEN' undeclared here (not in a 
> function)
>  char ip_opts[MAX_IPOPTLEN];
>               ^
> traceroute.c: In function 'get_hostname':
> traceroute.c:461:5: warning: return discards 'const' qualifier from 
> pointer target type
>      return info->h_name;
>      ^
> Makefile:1691: recipe for target 'traceroute.o' failed
> make[2]: *** [traceroute.o] Error 1
> 

Arghh! I also forgot I had to install (copy) some missing include files. 
Thanks for checking this.

I got these from the glibc-2.21 source code:

/usr/include/arpa/tftp.h
/usr/include/netinet/icmp6.h

The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:

/usr/include/netinet/ip_var.h

The latter I also needed for my Sendmail package. Also, the following 
Cygwin packages are required to compile the source code:

help2man
perl-Locale-gettext

After this, it should compile. Are these files included in any Cygwin 
package? Is there an elegant way to include these in my source package?

Daniel

Re: [ITP] Inetutils 1.9.4

[Marco Atzeri]

On 01/11/2015 15:19, D. Boland wrote:
> Marco Atzeri wrote:

>
> Arghh! I also forgot I had to install (copy) some missing include files.
> Thanks for checking this.
>
> I got these from the glibc-2.21 source code:
>
> /usr/include/arpa/tftp.h

tftp has this
https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1

> /usr/include/netinet/icmp6.h

not yet included
https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64

>
> The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:
>
> /usr/include/netinet/ip_var.h
>
> The latter I also needed for my Sendmail package. Also, the following
> Cygwin packages are required to compile the source code:
>
> help2man
> perl-Locale-gettext
>
> After this, it should compile. Are these files included in any Cygwin
> package? Is there an elegant way to include these in my source package?
>
> Daniel

Re: [ITP] Inetutils 1.9.4

[D. Boland]

Marco Atzeri wrote:
> 
> 
> On 01/11/2015 15:19, D. Boland wrote:
>> Marco Atzeri wrote:
> 
>>
>> Arghh! I also forgot I had to install (copy) some missing include files.
>> Thanks for checking this.
>>
>> I got these from the glibc-2.21 source code:
>>
>> /usr/include/arpa/tftp.h
> 
> tftp has this
> https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1
> 
>> /usr/include/netinet/icmp6.h
> 
> not yet included
> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64
> 
>>
>> The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:
>>
>> /usr/include/netinet/ip_var.h
>>
>> The latter I also needed for my Sendmail package. Also, the following
>> Cygwin packages are required to compile the source code:
>>
>> help2man
>> perl-Locale-gettext
>>
>> After this, it should compile. Are these files included in any Cygwin
>> package? Is there an elegant way to include these in my source package?
>>

So how do I do this? I could include icmp6.h and ip_var.h in the source 
package and conditionally install it to /usr/include in the 
'src_compile' handler, previous to the 'make' command.

I'll leave tftp out of the distribution. That subpackage of inetutils is 
maintained by Gernot Hiller.

On the other hand, I'd be happy to adopt it...

Cheers,
Daniel

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 2113 bytes --]

On Nov  2 08:02, D. Boland wrote:
> Marco Atzeri wrote:
> >On 01/11/2015 15:19, D. Boland wrote:
> >>Marco Atzeri wrote:
> >>Arghh! I also forgot I had to install (copy) some missing include files.
> >>Thanks for checking this.
> >>
> >>I got these from the glibc-2.21 source code:

Please use BSD files, not glibc, for licensing reasons.

> >>/usr/include/arpa/tftp.h
> >
> >tftp has this
> >https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1
> >
> >>/usr/include/netinet/icmp6.h
> >
> >not yet included
> >https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64
> >
> >>
> >>The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:
> >>
> >>/usr/include/netinet/ip_var.h
> >>
> >>The latter I also needed for my Sendmail package.

We can add the definition of MAX_IPOPTLEN to /usr/include/netinet/ip.h
for Cygwin 2.3.0, as on Linux.

> Also, the following
> >>Cygwin packages are required to compile the source code:
> >>
> >>help2man
> >>perl-Locale-gettext
> >>
> >>After this, it should compile. Are these files included in any Cygwin
> >>package? Is there an elegant way to include these in my source package?
> >>
> 
> So how do I do this? I could include icmp6.h and ip_var.h in the source
> package and conditionally install it to /usr/include in the 'src_compile'
> handler, previous to the 'make' command.
> 
> I'll leave tftp out of the distribution. That subpackage of inetutils is
> maintained by Gernot Hiller.
> 
> On the other hand, I'd be happy to adopt it...

Let's see if Gernot is still available.  There was no update to tftp
since early 2012.  Gernot, you're still with us?  Care to chime in
here?  Thanks.

Whatever the outcome, the tftp.h header should stay with the inetutils
or tftp package, otherwise we need to manage a smooth handover to the
Cygwin package.  As for icmp6.h, we could include the FreeBSD version
with Cygwin 2.3.0.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 2319 bytes --]

{Forgot to CC Gernot, sorry]

On Nov  2 10:56, Corinna Vinschen wrote:
> On Nov  2 08:02, D. Boland wrote:
> > Marco Atzeri wrote:
> > >On 01/11/2015 15:19, D. Boland wrote:
> > >>Marco Atzeri wrote:
> > >>Arghh! I also forgot I had to install (copy) some missing include files.
> > >>Thanks for checking this.
> > >>
> > >>I got these from the glibc-2.21 source code:
> 
> Please use BSD files, not glibc, for licensing reasons.
> 
> > >>/usr/include/arpa/tftp.h
> > >
> > >tftp has this
> > >https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1
> > >
> > >>/usr/include/netinet/icmp6.h
> > >
> > >not yet included
> > >https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64
> > >
> > >>
> > >>The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:
> > >>
> > >>/usr/include/netinet/ip_var.h
> > >>
> > >>The latter I also needed for my Sendmail package.
> 
> We can add the definition of MAX_IPOPTLEN to /usr/include/netinet/ip.h
> for Cygwin 2.3.0, as on Linux.
> 
> > Also, the following
> > >>Cygwin packages are required to compile the source code:
> > >>
> > >>help2man
> > >>perl-Locale-gettext
> > >>
> > >>After this, it should compile. Are these files included in any Cygwin
> > >>package? Is there an elegant way to include these in my source package?
> > >>
> > 
> > So how do I do this? I could include icmp6.h and ip_var.h in the source
> > package and conditionally install it to /usr/include in the 'src_compile'
> > handler, previous to the 'make' command.
> > 
> > I'll leave tftp out of the distribution. That subpackage of inetutils is
> > maintained by Gernot Hiller.
> > 
> > On the other hand, I'd be happy to adopt it...
> 
> Let's see if Gernot is still available.  There was no update to tftp
> since early 2012.  Gernot, you're still with us?  Care to chime in
> here?  Thanks.
> 
> Whatever the outcome, the tftp.h header should stay with the inetutils
> or tftp package, otherwise we need to manage a smooth handover to the
> Cygwin package.  As for icmp6.h, we could include the FreeBSD version
> with Cygwin 2.3.0.
> 
> 
> Corinna
> 
> -- 
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On Nov  2 10:57, Corinna Vinschen wrote:
> {Forgot to CC Gernot, sorry]
> 
> On Nov  2 10:56, Corinna Vinschen wrote:
> > On Nov  2 08:02, D. Boland wrote:
> > > Marco Atzeri wrote:
> > > >On 01/11/2015 15:19, D. Boland wrote:
> > > >>Marco Atzeri wrote:
> > > >>Arghh! I also forgot I had to install (copy) some missing include files.
> > > >>Thanks for checking this.
> > > >>
> > > >>I got these from the glibc-2.21 source code:
> > 
> > Please use BSD files, not glibc, for licensing reasons.
> > 
> > > >>/usr/include/arpa/tftp.h
> > > >
> > > >tftp has this
> > > >https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1
> > > >
> > > >>/usr/include/netinet/icmp6.h
> > > >
> > > >not yet included
> > > >https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64
> > > >
> > > >>
> > > >>The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:

I applied ther matching patch to the Cygwin repository.


HTH,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITP] Inetutils 1.9.4

[D. Boland]

Corinna Vinschen wrote:
> On Nov  2 10:57, Corinna Vinschen wrote:
>> {Forgot to CC Gernot, sorry]
>>
>> On Nov  2 10:56, Corinna Vinschen wrote:
>>> On Nov  2 08:02, D. Boland wrote:
>>>> Marco Atzeri wrote:
>>>>> On 01/11/2015 15:19, D. Boland wrote:
>>>>>> Marco Atzeri wrote:
>>>>>> Arghh! I also forgot I had to install (copy) some missing include files.
>>>>>> Thanks for checking this.
>>>>>>
>>>>>> I got these from the glibc-2.21 source code:
>>> Please use BSD files, not glibc, for licensing reasons.
>>>
>>>>>> /usr/include/arpa/tftp.h
>>>>> tftp has this
>>>>> https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1
>>>>>
>>>>>> /usr/include/netinet/icmp6.h
>>>>> not yet included
>>>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64
>>>>>
>>>>>> The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:
> 
> I applied ther matching patch to the Cygwin repository.

So... Do I have the GTG?

Daniel

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

On Dec 30 08:51, D. Boland wrote:
> Corinna Vinschen wrote:
> >On Nov  2 10:57, Corinna Vinschen wrote:
> >>{Forgot to CC Gernot, sorry]
> >>
> >>On Nov  2 10:56, Corinna Vinschen wrote:
> >>>On Nov  2 08:02, D. Boland wrote:
> >>>>Marco Atzeri wrote:
> >>>>>On 01/11/2015 15:19, D. Boland wrote:
> >>>>>>Marco Atzeri wrote:
> >>>>>>Arghh! I also forgot I had to install (copy) some missing include files.
> >>>>>>Thanks for checking this.
> >>>>>>
> >>>>>>I got these from the glibc-2.21 source code:
> >>>Please use BSD files, not glibc, for licensing reasons.
> >>>
> >>>>>>/usr/include/arpa/tftp.h
> >>>>>tftp has this
> >>>>>https://cygwin.com/packages/x86_64/tftp/tftp-5.2-1
> >>>>>
> >>>>>>/usr/include/netinet/icmp6.h
> >>>>>not yet included
> >>>>>https://cygwin.com/cgi-bin2/package-grep.cgi?grep=icmp6.h&arch=x86_64
> >>>>>
> >>>>>>The MAX_IPOPTLEN constant is in ip_var.h. I got that from OpenBSD source:
> >
> >I applied ther matching patch to the Cygwin repository.
> 
> So... Do I have the GTG?

Please send another ITP.  We also have to decide what to do with
icmp6.h.  We could include the FreeBSD file into the Cygwin distro,
perhaps.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[ITP] Inetutils 1.9.4

[D. Boland]

Hi group,

At Corinna's request, I re-intend to package the new version of 
Inetutils, version 1.9.4:

http://cygwin.boland.nl/x86_64/release/inetutils/inetutils-1.9.4-2-src.tar.xz

Package inetutils
-----------------
category: Net
requires: bash libgcc1 hostname whois tftp cygwin
sdesc: "Common networking client programs"
ldesc: "inetutils provides common networking clients and
  servers, including the inetd super-server, telnetd and
  telnet, ftpd and ftp, talkd and talk, uucpd (but no uucp
  client), and syslogd."

Package inetutils-server
------------------------
category: Net
requires: bash crypt libgcc1 inetutils tcp_wrappers tfpt-server
sdesc: "Common networking server programs"
ldesc: "inetutils provides common networking clients and
  servers, including the inetd super-server, telnetd and
  telnet, ftpd and ftp, talkd and talk, uucpd (but no uucp
  client), and syslogd."

Sub-packages
------------
Some programs in the inetutils suite are packaged already:

* hostname
* whois
* tftp
* tftp-server

So I added these on the 'required' lines.

Source-dependencies
-------------------
To build the source code, the following packages are needed:

* help2man
* libcrypt-devel
* libfakesu
* tftp

Also, the following include files are needed:

* /usr/include/netinet/icmp6.h
* /usr/include/netinet/ip_var.h

There has been discussion on including the icmp6.h file in Cygwin 2.3.0.

ip_var.h is needed for the MAX_IPOPTLEN constant. This could be added to 
the ip.h file as is done in Linux.

Good-to-go's are welcome!

Daniel

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On Feb  7 18:55, D. Boland wrote:
> Hi group,
> 
> At Corinna's request, I re-intend to package the new version of Inetutils,
> version 1.9.4:
> 
> http://cygwin.boland.nl/x86_64/release/inetutils/inetutils-1.9.4-2-src.tar.xz
> [...]
> Some programs in the inetutils suite are packaged already:
> 
> * hostname
> * whois
> * tftp
> * tftp-server
> 
> So I added these on the 'required' lines.

They are not actually *required* to run inetd, right?  Does it really
make sense to add them as require packages then?

> Also, the following include files are needed:
> 
> * /usr/include/netinet/icmp6.h
> * /usr/include/netinet/ip_var.h
> 
> There has been discussion on including the icmp6.h file in Cygwin 2.3.0.

Can you check if icmp6.h from FreeBSD
https://svnweb.freebsd.org/base/head/sys/netinet/icmp6.h?revision=279531&view=co
does the trick when copied to /usr/include/netinet?  If so, I add this file
to the repo.

> ip_var.h is needed for the MAX_IPOPTLEN constant. This could be added to the
> ip.h file as is done in Linux.

MAX_IPOPTLEN is in ip.h since Cygwin 2.3.0.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITP] Inetutils 1.9.4

[Achim Gratz]

Corinna Vinschen writes:
>> So I added these on the 'required' lines.
>
> They are not actually *required* to run inetd, right?  Does it really
> make sense to add them as require packages then?

I don't think so (not checked all scripts, though), although people who
expect these programs to become available with inetutils might say
otherwise.  I would tend to omit those in order to keep the dependencies
down.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

DIY Stuff:
http://Synth.Stromeko.net/DIY.html

Re: [ITP] Inetutils 1.9.4

[D. Boland]

Hi Corinna,

Corinna Vinschen wrote:
> On Feb  7 18:55, D. Boland wrote:
>> Hi group,
>>
>> At Corinna's request, I re-intend to package the new version of Inetutils,
>> version 1.9.4:
>>
>> http://cygwin.boland.nl/x86_64/release/inetutils/inetutils-1.9.4-2-src.tar.xz
>> [...]
>> Some programs in the inetutils suite are packaged already:
>>
>> * hostname
>> * whois
>> * tftp
>> * tftp-server
>>
>> So I added these on the 'required' lines.
> 
> They are not actually *required* to run inetd, right?  Does it really
> make sense to add them as require packages then?

They belong to the package. A user expects them in there and would have
to piece the package back together. Why does it make sense to leave them
out?

> 
>> Also, the following include files are needed:
>>
>> * /usr/include/netinet/icmp6.h
>> * /usr/include/netinet/ip_var.h
>>
>> There has been discussion on including the icmp6.h file in Cygwin 2.3.0.
> 
> Can you check if icmp6.h from FreeBSD
> https://svnweb.freebsd.org/base/head/sys/netinet/icmp6.h?revision=279531&view=co
> does the trick when copied to /usr/include/netinet?  If so, I add this file
> to the repo.

If I use the FreeBSD version I get:

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../lib -I../lib 
-I../libinetutils -I../libicmp    -O2 -pipe 
-Wimplicit-function-declaration -MT ping6.o -MD -MP -MF .deps/ping6.Tpo 
-c -o ping6.o ping6.c
ping6.c: In function 'ping_init':
ping6.c:844:37: error: 'ICMP6_FILTER' undeclared (first use in this 
function)
      setsockopt (fd, IPPROTO_ICMPV6, ICMP6_FILTER, &filter, sizeof 
(filter));
                                      ^

Daniel

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 4246 bytes --]

Hi Daniel,

On Feb 13 07:56, D. Boland wrote:
> Hi Corinna,
> 
> Corinna Vinschen wrote:
> >On Feb  7 18:55, D. Boland wrote:
> >>Some programs in the inetutils suite are packaged already:
> >>
> >>* hostname
> >>* whois
> >>* tftp
> >>* tftp-server
> >>
> >>So I added these on the 'required' lines.
> >
> >They are not actually *required* to run inetd, right?  Does it really
> >make sense to add them as require packages then?
> 
> They belong to the package. A user expects them in there and would have
> to piece the package back together. Why does it make sense to leave them
> out?

These tools are provided separately in many Linux distros for quite
some time, and while those tools can be started by inetd, inetd
doesn't require them and they don't require inetd (xinetd is perfectly
capable of replacing inetd).

> >>Also, the following include files are needed:
> >>
> >>* /usr/include/netinet/icmp6.h
> >>* /usr/include/netinet/ip_var.h
> >>
> >>There has been discussion on including the icmp6.h file in Cygwin 2.3.0.
> >
> >Can you check if icmp6.h from FreeBSD
> >https://svnweb.freebsd.org/base/head/sys/netinet/icmp6.h?revision=279531&view=co
> >does the trick when copied to /usr/include/netinet?  If so, I add this file
> >to the repo.
> 
> If I use the FreeBSD version I get:
> 
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../lib -I../lib -I../libinetutils
> -I../libicmp    -O2 -pipe -Wimplicit-function-declaration -MT ping6.o -MD
> -MP -MF .deps/ping6.Tpo -c -o ping6.o ping6.c
> ping6.c: In function 'ping_init':
> ping6.c:844:37: error: 'ICMP6_FILTER' undeclared (first use in this
> function)
>      setsockopt (fd, IPPROTO_ICMPV6, ICMP6_FILTER, &filter, sizeof
> (filter));

That won't work.  Ever.  Using RAW sockets requires administrator
privileges.  Apart from that, WinSock setsockopt does not at all support
settings for the IPPROTO_ICMPV6 protocol family.  That's what the
32 bit ping package

I took a (not so) quick glance over the binary packages and there are
some problems:

- etc/defaults/etc/init.src.sh has 000 perms.

- etc/defaults/etc/shells collides with the already provided file from
  the base-files package.

- usr/bin/inetutils-server-config installs inetd and syslogd in one
  go.  That's a no no.  There should be two installation scripts since
  you can't expect that a user who wants one service also wants the
  other one.  Some people would probably like to stick to the Windows
  logging, or install syslog-ng.

- Apropos syslog-ng: syslogd potentially collides with syslog-ng.
  However, instead of reusing the existing /usr/bin/syslogd-config
  script, your new scripts don't check for an existing syslog-ng
  installation at all.

- You removed the etc/defaults/etc/xinetd.d files.

- You removed the /usr/bin/iu-config file, which was specificially
  created to allow running under the cyg_server account for the known
  reasons of being able to switch the user context(*).  Your scripts
  enforce file ownership and service start under the SYSTEM account.
  That's why the csih package exists for service installation scripts to
  use for stuff like that.  Please have a look into the old
  /usr/bin/iu-config file.

- usr/bin/ping collides with the ping package.

- sbin/ifconfig is mostly non-functional since Cygwin doesn't support
  most of the functionality.  Do you really want to maintain it?

- usr/bin/traceroute is non-functional:

    $ traceroute.exe www.wdr.de
    traceroute to e2636.g.akamaiedge.net (104.90.150.230), 64 hops max
    traceroute: socket: Operation not permitted

- What also irritates me is that almost none of the patches from the
  former package made it into your version.  Did you actually check the
  patches from the current 1.9.1 source package and made sure that they
  are really not required anymore, especially concerning O_BINARY/O_TEXT
  mode, authentication, exception handling, and, generally, backward
  compatibility?


Corinna

(*) https://cygwin.com/cygwin-ug-net/ntsec.html

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [ITP] Inetutils 1.9.4

[D. Boland]

Hi Corinna,

Corinna Vinschen wrote:
> Hi Daniel,
> 
> On Feb 13 07:56, D. Boland wrote:
>> Hi Corinna,
>>
>> Corinna Vinschen wrote:
>>> On Feb  7 18:55, D. Boland wrote:
>>>> Some programs in the inetutils suite are packaged already:
>>>>
>>>> * hostname
>>>> * whois
>>>> * tftp
>>>> * tftp-server
>>>>
>>>> So I added these on the 'required' lines.
>>> They are not actually *required* to run inetd, right?  Does it really
>>> make sense to add them as require packages then?
>> They belong to the package. A user expects them in there and would have
>> to piece the package back together. Why does it make sense to leave them
>> out?
> 
> These tools are provided separately in many Linux distros for quite
> some time, and while those tools can be started by inetd, inetd
> doesn't require them and they don't require inetd (xinetd is perfectly
> capable of replacing inetd).

I don't see why this makes sense. The ping, hostname, whois and tftp 
programs *do* belong to the inetutils package, right? But if you insist, 
i'll comply.

> 
>>>> Also, the following include files are needed:
>>>>
>>>> * /usr/include/netinet/icmp6.h
>>>> * /usr/include/netinet/ip_var.h
>>>>
>>>> There has been discussion on including the icmp6.h file in Cygwin 2.3.0.
>>> Can you check if icmp6.h from FreeBSD
>>> https://svnweb.freebsd.org/base/head/sys/netinet/icmp6.h?revision=279531&view=co
>>> does the trick when copied to /usr/include/netinet?  If so, I add this file
>>> to the repo.
>> If I use the FreeBSD version I get:
>>
>> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../lib -I../lib -I../libinetutils
>> -I../libicmp    -O2 -pipe -Wimplicit-function-declaration -MT ping6.o -MD
>> -MP -MF .deps/ping6.Tpo -c -o ping6.o ping6.c
>> ping6.c: In function 'ping_init':
>> ping6.c:844:37: error: 'ICMP6_FILTER' undeclared (first use in this
>> function)
>>      setsockopt (fd, IPPROTO_ICMPV6, ICMP6_FILTER, &filter, sizeof
>> (filter));
> 
> That won't work.  Ever.  Using RAW sockets requires administrator
> privileges.  Apart from that, WinSock setsockopt does not at all support
> settings for the IPPROTO_ICMPV6 protocol family.  That's what the
> 32 bit ping package
> 

OK. I'll leave the ping6 program out.

> I took a (not so) quick glance over the binary packages and there are
> some problems:
> 
> - etc/defaults/etc/init.src.sh has 000 perms.

I'll fix that.

> 
> - etc/defaults/etc/shells collides with the already provided file from
>   the base-files package.

I'll remove it.

> 
> - usr/bin/inetutils-server-config installs inetd and syslogd in one
>   go.  That's a no no.  There should be two installation scripts since
>   you can't expect that a user who wants one service also wants the
>   other one.  Some people would probably like to stick to the Windows
>   logging, or install syslog-ng.
> 
> - Apropos syslog-ng: syslogd potentially collides with syslog-ng.
>   However, instead of reusing the existing /usr/bin/syslogd-config
>   script, your new scripts don't check for an existing syslog-ng
>   installation at all.

I'll create inetutils-inetd-config and inetutils-syslogd-config. The 
latter will check for syslog-ng existance.

> 
> - You removed the etc/defaults/etc/xinetd.d files.
> 

I'll put them in.

> - You removed the /usr/bin/iu-config file, which was specificially
>   created to allow running under the cyg_server account for the known
>   reasons of being able to switch the user context(*).  Your scripts
>   enforce file ownership and service start under the SYSTEM account.
>   That's why the csih package exists for service installation scripts to
>   use for stuff like that.  Please have a look into the old
>   /usr/bin/iu-config file.

I'll restore the iu-config script.

> 
> - usr/bin/ping collides with the ping package.

I'll remove ping.

> 
> - sbin/ifconfig is mostly non-functional since Cygwin doesn't support
>   most of the functionality.  Do you really want to maintain it?
> 
> - usr/bin/traceroute is non-functional:
> 
>     $ traceroute.exe www.wdr.de
>     traceroute to e2636.g.akamaiedge.net (104.90.150.230), 64 hops max
>     traceroute: socket: Operation not permitted

That's because you're not in Administrator mode. Ping (from Atzeri's 
package) does the same. The error message ultimately comes from the 
'sendto' function, which is in cygwin1.dll

> 
> - What also irritates me is that almost none of the patches from the
>   former package made it into your version.  Did you actually check the
>   patches from the current 1.9.1 source package and made sure that they
>   are really not required anymore, especially concerning O_BINARY/O_TEXT
>   mode, authentication, exception handling, and, generally, backward
>   compatibility?

What surprised me was the sheer number of patches. A whopping 573 of 
them. Are they bug-fixes? Features? Shouldn't both be sent upstream? 
What about the dont-mess-with-userspace rule? You once told me
that "we mostly strive to make Cygwin accommodate user space".

I'm not sure if I want to adopt inetutils with all these patches. It 
feels like a can of worms. I cannot find any explanations for the 
patches in the README files. Those patches are going to haunt me. I am a 
systems-programmer for 20 years now. And I learnt Torvald's first rule 
of kernel programming the hard way.

Please let me adopt the package in a clean way. If a parent adopts a 
child, there will be new rules. The real parents didn't want the child, 
or couldn't keep the child for unknown reasons. I don't mess with the 
child and it will love me for it. I'll take full resposibility for not 
messing with the child ;-)

Seriously, I really think it is fair to re-negotiate if and how I will 
mess with inetutils. I'm the new maintainer, right? The concerns about 
authentication I understand, but isn't a big issue. It's in the new, 
much smaller patch. And aren't things like O_BINARY/O_TEXT mode and 
exception handling a concern of the upstream maintainers?

Sincerely,
Daniel

Re: [ITP] Inetutils 1.9.4

[Achim Gratz]

D. Boland writes:
>> These tools are provided separately in many Linux distros for quite
>> some time, and while those tools can be started by inetd, inetd
>> doesn't require them and they don't require inetd (xinetd is perfectly
>> capable of replacing inetd).
>
> I don't see why this makes sense. The ping, hostname, whois and tftp
> programs *do* belong to the inetutils package, right? But if you
> insist, i'll comply.

They don't necessarily belong there and haven't for quite some time if
you look at a reasonably modern Linux distribution (mine is openSUSE
Tumbleweed).

> rpm -qf /usr/lib/git/git-subtree
git-core-2.7.1-1.1.x86_64
> rpm -qf `which hostname`
hostname-3.16-1.3.x86_64
> rpm -qf `which ping`
iputils-s20121221-4.5.x86_64
> rpm -qf `which tftp`
tftp-5.2-13.2.x86_64

whois isn't even installed on my box and most registrars wouldn't
deliver data for it anyway.

>> - etc/defaults/etc/shells collides with the already provided file from
>>   the base-files package.
>
> I'll remove it.

If there's something you think should be added, let me know.

>> - usr/bin/traceroute is non-functional:
>>
>>     $ traceroute.exe www.wdr.de
>>     traceroute to e2636.g.akamaiedge.net (104.90.150.230), 64 hops max
>>     traceroute: socket: Operation not permitted
>
> That's because you're not in Administrator mode. Ping (from Atzeri's
> package) does the same. The error message ultimately comes from the
> 'sendto' function, which is in cygwin1.dll

Maybe it should be in sbin/ like all the other stuff that needs
administrator privileges, then?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [ITP] Inetutils 1.9.4

[Daniel Boland]

Hi Achim,

Achim Gratz wrote:
> D. Boland writes:
>>> These tools are provided separately in many Linux distros for quite
>>> some time, and while those tools can be started by inetd, inetd
>>> doesn't require them and they don't require inetd (xinetd is perfectly
>>> capable of replacing inetd).
>> I don't see why this makes sense. The ping, hostname, whois and tftp
>> programs *do* belong to the inetutils package, right? But if you
>> insist, i'll comply.
> 
> They don't necessarily belong there and haven't for quite some time if
> you look at a reasonably modern Linux distribution (mine is openSUSE
> Tumbleweed).
> 
>> rpm -qf /usr/lib/git/git-subtree
> git-core-2.7.1-1.1.x86_64
>> rpm -qf `which hostname`
> hostname-3.16-1.3.x86_64
>> rpm -qf `which ping`
> iputils-s20121221-4.5.x86_64
>> rpm -qf `which tftp`
> tftp-5.2-13.2.x86_64
> 
> whois isn't even installed on my box and most registrars wouldn't
> deliver data for it anyway.
> 

What if you are a registrar ;-)

>>> - usr/bin/traceroute is non-functional:
>>>
>>>     $ traceroute.exe www.wdr.de
>>>     traceroute to e2636.g.akamaiedge.net (104.90.150.230), 64 hops max
>>>     traceroute: socket: Operation not permitted
>> That's because you're not in Administrator mode. Ping (from Atzeri's
>> package) does the same. The error message ultimately comes from the
>> 'sendto' function, which is in cygwin1.dll
> 
> Maybe it should be in sbin/ like all the other stuff that needs
> administrator privileges, then?
> 

Definitely. Maybe add /sbin:/usr/sbin:/usr/local/sbin to the path of the
user who installs Cygwin? Most Linux systems do that.

Daniel

Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 5203 bytes --]

Hi Daniel,

On Feb 16 17:28, D. Boland wrote:
> Corinna Vinschen wrote:
> >On Feb 13 07:56, D. Boland wrote:
> >>Corinna Vinschen wrote:
> >>>On Feb  7 18:55, D. Boland wrote:
> >>>>Some programs in the inetutils suite are packaged already:
> >>>>[...]
> >>>>So I added these on the 'required' lines.
> >>>They are not actually *required* to run inetd, right?  Does it really
> >>>make sense to add them as require packages then?
> >>[...]
> >These tools are provided separately in many Linux distros for quite
> >some time, and while those tools can be started by inetd, inetd
> >doesn't require them and they don't require inetd (xinetd is perfectly
> >capable of replacing inetd).
> 
> I don't see why this makes sense. The ping, hostname, whois and tftp
> programs *do* belong to the inetutils package, right? But if you insist,
> i'll comply.

Let's use modern Linux distros as role model, please.

> >- usr/bin/inetutils-server-config installs inetd and syslogd in one
> >  go.  That's a no no.  There should be two installation scripts since
> >  you can't expect that a user who wants one service also wants the
> >  other one.  Some people would probably like to stick to the Windows
> >  logging, or install syslog-ng.
> >
> >- Apropos syslog-ng: syslogd potentially collides with syslog-ng.
> >  However, instead of reusing the existing /usr/bin/syslogd-config
> >  script, your new scripts don't check for an existing syslog-ng
> >  installation at all.
> 
> I'll create inetutils-inetd-config and inetutils-syslogd-config. The latter
> will check for syslog-ng existance.

Ok.  It would just be nice if your service installer scripts would
follow the technique used by other service installer scripts and not
work entirely differently.

> >- sbin/ifconfig is mostly non-functional since Cygwin doesn't support
> >  most of the functionality.  Do you really want to maintain it?
> >
> >- usr/bin/traceroute is non-functional:
> >
> >    $ traceroute.exe www.wdr.de
> >    traceroute to e2636.g.akamaiedge.net (104.90.150.230), 64 hops max
> >    traceroute: socket: Operation not permitted
> 
> That's because you're not in Administrator mode. Ping (from Atzeri's
> package) does the same. The error message ultimately comes from the 'sendto'
> function, which is in cygwin1.dll

That's because ping is using raw sockets which are restricted to
admins.  Sadly Windows doesn't support the SUID bit...

Linux' traceroute supports the -U flag which uses UDP packages.  That
might be a default option for non-admin accounts, if this traceroute
supports UDP tracing as well, wouldn't it?

> >- What also irritates me is that almost none of the patches from the
> >  former package made it into your version.  Did you actually check the
> >  patches from the current 1.9.1 source package and made sure that they
> >  are really not required anymore, especially concerning O_BINARY/O_TEXT
> >  mode, authentication, exception handling, and, generally, backward
> >  compatibility?
> 
> What surprised me was the sheer number of patches. A whopping 573 of them.
> Are they bug-fixes? Features? Shouldn't both be sent upstream? What about
> the dont-mess-with-userspace rule? You once told me
> that "we mostly strive to make Cygwin accommodate user space".
> 
> I'm not sure if I want to adopt inetutils with all these patches. It feels
> like a can of worms. I cannot find any explanations for the patches in the
> README files. Those patches are going to haunt me. I am a systems-programmer
> for 20 years now. And I learnt Torvald's first rule of kernel programming
> the hard way.
> 
> Please let me adopt the package in a clean way. If a parent adopts a child,
> there will be new rules. The real parents didn't want the child, or couldn't
> keep the child for unknown reasons. I don't mess with the child and it will
> love me for it. I'll take full resposibility for not messing with the child
> ;-)
> 
> Seriously, I really think it is fair to re-negotiate if and how I will mess
> with inetutils. I'm the new maintainer, right? The concerns about
> authentication I understand, but isn't a big issue. It's in the new, much
> smaller patch. And aren't things like O_BINARY/O_TEXT mode and exception
> handling a concern of the upstream maintainers?

There are two points here.

One, I didn't say that you have to take the patches as is.  They might
partially not even be necessary anymore.  I asked you if you have
*checked* them.  Some of them might contain stuff which should stay
available one way or the other to be backward compatible with the former
version of inetutils (especially inetd).  The missing O_BINARY stuff
looks suspicious, for instance.

Two, of course it's preferably if necessary patches go upstream.  But
upstream might not even know that we're using their package.  And if the
old maintainer didn't communicate with upstream, it would probably make
sense if the new maintainer would try to pick up.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]