From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH rebase] Make rebaseall a wrapper around the autorebase postinstall, script
Date: Thu, 21 Jul 2022 09:50:40 -0400 [thread overview]
Message-ID: <6b3a9801-6ab9-e910-a55e-2a9d398edc5f@cornell.edu> (raw)
In-Reply-To: <YtkXxSZiLDxfY9mJ@calimero.vinschen.de>
On 7/21/2022 5:09 AM, Corinna Vinschen wrote:
> We're using the "?p=" URLs on the cygin-apps website, too. Maybe it's
> just me, but to me it looks better if we change this to the 2nd form
> where possible. What do you think?
I agree that it looks better without the ?p=. I have no idea why the latter is
used on the cygwin-apps website.
> Just a style issue, but the two functions should stay first in the file.
> Please move this code just right before the trap call.
>
> Other than that, LGTM.
I've made all the changes you suggested and pushed it.
Ken
next prev parent reply other threads:[~2022-07-21 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 20:14 Ken Brown
2022-07-21 9:09 ` Corinna Vinschen
2022-07-21 13:50 ` Ken Brown [this message]
2022-07-21 14:09 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b3a9801-6ab9-e910-a55e-2a9d398edc5f@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).