Re: [PATCH rebase] Make rebaseall a wrapper around the autorebase postinstall, script

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

Hi Ken,

On Jul 20 16:14, Ken Brown wrote:
> Patch attached.

> From bcbc7f9768854a6e6aaf1a450cdaabc61241ea9d Mon Sep 17 00:00:00 2001
>  Homepage:
>  ================================================================================
>  The primary rebase web site is:
>  
> -    http://www.tishler.net/jason/software/rebase/
> +    https://cygwin.com/git/?p=cygwin-apps/rebase.git

Shouldn't that be https://sourceware.org/cygwin-apps/ ?

I mean, it's the only real web page apart from git access.

Also

  https://cygwin.com/git/?p=cygwin-apps/rebase.git

vs.

  https://cygwin.com/git/cygwin-apps/rebase.git

Both work but the 2nd URL avoids that ugly ?p=.

We're using the "?p=" URLs on the cygin-apps website, too.  Maybe it's
just me, but to me it looks better if we change this to the 2nd form
where possible.  What do you think?


>  Download:
>  ================================================================================
> -The primary rebase download site is:
> -
> -    http://www.tishler.net/jason/software/rebase/
> -
> -Access to the CVS development sources is available:
> +Access to the git development sources is available:
>  
> -    cvs -d:pserver:anoncvs@cygwin.com:/cvs/cygwin-apps co rebase
> +    git clone git://cygwin.com/git/cygwin-apps/rebase.git

Better use https here, rather than git.

>  DefaultFileList=
>  DefaultSuffixes='dll|so|oct'
>  
> +# Determine platform
> +Platform=`uname -s`
> +case $Platform in
> + *MINGW*  | *mingw*  ) Platform=mingw  ;;
> + *CYGWIN* | *cygwin* ) Platform=cygwin ;;
> + *MSYS*   | *msys*   ) Platform=msys   ;;
> + * )
> +    echo "Unsupported platform: $Platform" 1>&2
> +    exit 1
> +    ;;
> +esac
> +
> +# On Cygwin, just call the _autorebase postinstall script
> +case $Platform in
> +  cygwin)
> +    if [ "$#" -gt 0 ]
> +    then
> +      echo "usage: ${ProgramName}"
> +      exit 1
> +    fi
> +    exec /etc/postinstall/0p_000_autorebase.dash
> +    ;;
> +  *)
> +    ;;
> +esac
> +
>  # Define functions
>  usage()
>  {

Just a style issue, but the two functions should stay first in the file.
Please move this code just right before the trap call.

Other than that, LGTM.


Thanks,
Corinna