Re: Updated: speex-1.2.0-1

Re: Updated: speex-1.2.0-1

[Yaakov Selkowitz]

On 2016-12-26 12:23, David Rothenberger wrote:
> Updated to the 1.2.0 upstream release. See also the package
> documentation in /usr/share/doc/speex/.

David,

This version does not come with the speexdsp library, which is now 
shipped separately upstream.  This needs to be provided as well in order 
to not break packages which already use it.  Are you able to ITP speexdsp?

-- 
Yaakov

[ITP] speexdsp-1.2rc3-1

[David Rothenberger]

On 12/26/2016 12:55 PM, Yaakov Selkowitz wrote:
> On 2016-12-26 12:23, David Rothenberger wrote:
>> Updated to the 1.2.0 upstream release. See also the package
>> documentation in /usr/share/doc/speex/.
> 
> David,
> 
> This version does not come with the speexdsp library, which is now
> shipped separately upstream.  This needs to be provided as well in order
> to not break packages which already use it.  Are you able to ITP speexdsp?

Sure, here you go.

SpeexDSP is included in:
 * Debian: https://packages.debian.org/search?keywords=speexdsp
 * Fedora: https://admin.fedoraproject.org/pkgdb/package/rpms/speexdsp/

----------------------------------------------------------------------
Hints:
----------------------------------------------------------------------

speexdsp-1.2rc3-1.hint
----------------------------------------------------------------------
category: Audio 
requires:  
sdesc: "A patent-free, Open Source/Free Software DSP library"
ldesc: "Speex is a patent-free audio codec designed especially for voice
(unlike Vorbis which targets general audio) signals and providing good
narrowband and wideband quality. This project aims to be complementary to
the Vorbis codec."

libspeexdsp1-1.2rc3-1.hint
----------------------------------------------------------------------
category: Audio Devel Libs
requires: cygwin speexdsp
sdesc: "A patent-free, Open Source/Free Software DSP library (runtime)"
ldesc: "Speex is a patent-free audio codec designed especially for voice
(unlike Vorbis which targets general audio) signals and providing good
narrowband and wideband quality. This project aims to be complementary to
the Vorbis codec."
external-source: speexdsp

speexdsp-devel-1.2rc3-1.hint
----------------------------------------------------------------------
category: Audio Libs
requires: libspeexdsp1 pkg-config speexdsp
sdesc: "A patent-free, Open Source/Free Software DSP library (development)"
ldesc: "Speex is a patent-free audio codec designed especially for voice
(unlike Vorbis which targets general audio) signals and providing good
narrowband and wideband quality. This project aims to be complementary to
the Vorbis codec."
external-source: speexdsp

speexdsp-debuginfo-1.2rc3-1.hint
----------------------------------------------------------------------
category: Debug
requires: cygwin-debuginfo
external-source: speexdsp
sdesc: "Debug info for speexdsp"
ldesc: "This package contains files necessary for debugging the
speexdsp package with gdb."

----------------------------------------------------------------------
Packages:
----------------------------------------------------------------------

x86_64:
----------------------------------------------------------------------
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-1.2rc3-1-src.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-1.2rc3-1.hint
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/libspeexdsp1/libspeexdsp1-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/libspeexdsp1/libspeexdsp1-1.2rc3-1.hint
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-devel/speexdsp-devel-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-devel/speexdsp-devel-1.2rc3-1.hint
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-debuginfo/speexdsp-debuginfo-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.x86_64/speexdsp-debuginfo/speexdsp-debuginfo-1.2rc3-1.hint

i686:
----------------------------------------------------------------------
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-1.2rc3-1-src.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-1.2rc3-1.hint
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/libspeexdsp1/libspeexdsp1-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/libspeexdsp1/libspeexdsp1-1.2rc3-1.hint
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-devel/speexdsp-devel-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-devel/speexdsp-devel-1.2rc3-1.hint
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-debuginfo/speexdsp-debuginfo-1.2rc3-1.tar.xz
https://dl.dropboxusercontent.com/u/103907567/speexdsp-1.2rc3-1.i686/speexdsp-debuginfo/speexdsp-debuginfo-1.2rc3-1.hint


-- 
David Rothenberger  ----  daveroth@acm.org

Re: [ITP] speexdsp-1.2rc3-1

[Yaakov Selkowitz]

On 2016-12-26 18:32, David Rothenberger wrote:
> On 12/26/2016 12:55 PM, Yaakov Selkowitz wrote:
>> This version does not come with the speexdsp library, which is now
>> shipped separately upstream.  This needs to be provided as well in order
>> to not break packages which already use it.  Are you able to ITP speexdsp?
>
> Sure, here you go.

Thanks!  A few nits:

* Why a git snapshot instead of an official tarball?

* A version number of "1.2rc3" may not sort properly with a future 
1.2.0.  Instead, drop all the git stuff and:

VERSION=1.2
RELEASE=0.1.rc3

SRC_URI="http://downloads.xiph.org/releases/speex/speexdsp-${VERSION}${RELEASE##*.}.tar.gz"
SRC_DIR="speexdsp-${VERSION}${RELEASE##*.}"

* The following is problematic:

libspeexdsp1_CONTENTS="usr/bin/*.dll"

NEVER DO THIS.  If the DLL ABI version number is changed upstream 
(either on purpose or by accident), you might miss it and end up 
packaging what should be libspeexdsp2 as libspeexdsp1, breaking existing 
installations.

I have added this package under your name.  Go ahead and upload with 
these fixes, and then I'll fix the dependencies of other packages 
accordingly.

-- 
Yaakov

Re: [ITP] speexdsp-1.2rc3-1

[David Rothenberger]

On 12/26/2016 5:16 PM, Yaakov Selkowitz wrote:
> * Why a git snapshot instead of an official tarball?

I had problems building the latest speex release from the official 
tarball, so I switched to git for that release and just copied it for 
speexdsp.

> * A version number of "1.2rc3" may not sort properly with a future
> 1.2.0.  Instead, drop all the git stuff and:
>
> VERSION=1.2
> RELEASE=0.1.rc3

Right. For speex, I had to use override.hint for 1.2.0. Thanks for the hint.

> libspeexdsp1_CONTENTS="usr/bin/*.dll"
>
> NEVER DO THIS.  If the DLL ABI version number is changed upstream
> (either on purpose or by accident), you might miss it and end up
> packaging what should be libspeexdsp2 as libspeexdsp1, breaking existing
> installations.

Noted.

> I have added this package under your name.  Go ahead and upload with
> these fixes, and then I'll fix the dependencies of other packages
> accordingly.

Done. Thanks for the review and fixing up the dependencies.

-- 
David Rothenberger  ----  daveroth@acm.org

Cynic, n.:
         Experienced.

Re: [ITP] speexdsp-1.2rc3-1

[Yaakov Selkowitz]

On 2016-12-26 20:49, David Rothenberger wrote:
> On 12/26/2016 5:16 PM, Yaakov Selkowitz wrote:
>> * Why a git snapshot instead of an official tarball?
>
> I had problems building the latest speex release from the official
> tarball, so I switched to git for that release and just copied it for
> speexdsp.

How so?  I didn't have any issues building the mingw speex packages.

>> I have added this package under your name.  Go ahead and upload with
>> these fixes, and then I'll fix the dependencies of other packages
>> accordingly.
>
> Done. Thanks for the review and fixing up the dependencies.

One more thing: now that we have speexdsp (again), speexenc (from the 
main speex package) will benefit from it if present.  This would require 
a simple revision bump and rebuild of speex with the speexdsp packages 
installed.

-- 
Yaakov

Re: [ITP] speexdsp-1.2rc3-1

[David Rothenberger]

On 12/26/2016 7:35 PM, Yaakov Selkowitz wrote:
> On 2016-12-26 20:49, David Rothenberger wrote:
>> On 12/26/2016 5:16 PM, Yaakov Selkowitz wrote:
>>> * Why a git snapshot instead of an official tarball?
>>
>> I had problems building the latest speex release from the official
>> tarball, so I switched to git for that release and just copied it for
>> speexdsp.
>
> How so?  I didn't have any issues building the mingw speex packages.

It wouldn't build the man pages using the official source tarball.

>>> I have added this package under your name.  Go ahead and upload with
>>> these fixes, and then I'll fix the dependencies of other packages
>>> accordingly.
>>
>> Done. Thanks for the review and fixing up the dependencies.
>
> One more thing: now that we have speexdsp (again), speexenc (from the
> main speex package) will benefit from it if present.  This would require
> a simple revision bump and rebuild of speex with the speexdsp packages
> installed.

Thanks for the heads up. Working on that now.


-- 
David Rothenberger  ----  daveroth@acm.org

"There is nothing new under the sun, but there are lots of old things
  we don't know yet."
                 -- Ambrose Bierce

Re: [ITP] speexdsp-1.2rc3-1

[Yaakov Selkowitz]

On 2016-12-27 13:08, David Rothenberger wrote:
> On 12/26/2016 7:35 PM, Yaakov Selkowitz wrote:
>> On 2016-12-26 20:49, David Rothenberger wrote:
>>> I had problems building the latest speex release from the official
>>> tarball, so I switched to git for that release and just copied it for
>>> speexdsp.
>>
>> How so?  I didn't have any issues building the mingw speex packages.
>
> It wouldn't build the man pages using the official source tarball.

Sorry, which man pages?

>> One more thing: now that we have speexdsp (again), speexenc (from the
>> main speex package) will benefit from it if present.  This would require
>> a simple revision bump and rebuild of speex with the speexdsp packages
>> installed.
>
> Thanks for the heads up. Working on that now.

Thanks!

-- 
Yaakov