public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: ASSI <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: Re: git repositories for cygwin packaging - please test
Date: Sat, 08 Aug 2020 06:26:59 +0200	[thread overview]
Message-ID: <874kpd225o.fsf@Otto.invalid> (raw)
In-Reply-To: <fa34e0c7-72a4-3cbb-d816-2aa9b1e2aeb2@cornell.edu> (Ken Brown via Cygwin-apps's message of "Fri, 7 Aug 2020 18:05:01 -0400")

Ken Brown via Cygwin-apps writes:
>>> - take an inordinate amount of time to run (exceeding the resource limits)
>>
>> That is a problem that comes with CI I think and we didn't really have
>> had to consider so far.  I have a few packages that I don't run tests on
>> by default because the test suite produces hangs or other unstable
>> behaviour, but that is dealt with in the src_test function itself.
>> If there are really resource hungry tests they usually need to be
>> enabled somewhere and one could skip those if the build runs on CI (how
>> to find that out?).
>
> Here's an example where Jon's suggestion would have been useful: While
> building php recently, I noticed that the test suite took forever.  I
> would have been happy to have a way to tell the CI to skip the tests
> and avoid exceeding the resource limits.  But I wouldn't want to do
> that by modifying src_test, because I would still want to run the
> tests locally.

I think I didn't express myself clearly enough.  If you look in the
perl-IO-Tty cygport file you'll find this:

src_test() {
    cd ${B}
    [ "no" != "${CYGPORT_RUN_UNSTABLE_TESTS-no}" ] &&
     cygtest || echo "Unstable test, set CYGPORT_RUN_UNSTABLE_TESTS to run."
}

This is clearly an exceptional deficiency (even if presumably caused by
some border case in Cygwin) that needs to be handled in the package and
not a general thing that should be in cygport.

But that's not to say that something like CYGPORT_RUN_EXPENSIVE_TESTS
could not exist and arguably it should even be directly provided by
cygport itself if it was.  Now, "expensive" has multiple dimensions, so
I'd expect that variable to have a list of values to indicate which of
these is considered relevant (like time, memory, network).  There'd need
to be a matching set of values / limits provided by the local or CI
configuration to enable / disable tests as appropriate.

CPU wise the CI seems to have a pretty beefy configuration, I've not run
into memory problems yet (but didn't check that specifically).  So at
the moment the relevant limits would be total runtime and maybe network
activity (I don't think I have a package that exercises that).  But then
again, this could change with each run and certainly will change over
time, so hard-coding these limits doesn't seem like a good idea.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

  reply	other threads:[~2020-08-08  4:27 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 20:08 Jon Turney
2019-08-05  2:03 ` Ken Brown
2019-08-08 13:47 ` Andrew Schulman via cygwin-apps
2019-08-08 14:04 ` Andrew Schulman via cygwin-apps
2019-08-08 17:09   ` Ken Brown
2019-08-09 16:12     ` Jon Turney
2019-08-09 19:12       ` Ken Brown
2019-08-13 11:55         ` Jon Turney
2019-08-09 16:00 ` Jon Turney
2019-08-09 20:58 ` Brian Inglis
2019-08-13 11:55 ` Jon Turney
2019-08-19 18:36 ` Achim Gratz
2020-05-27 22:27 ` Jon Turney
2020-05-28 11:51   ` szgyg
2020-06-04 16:01   ` Ken Brown
2020-06-04 20:33     ` Brian Inglis
2020-06-09 13:26       ` Jon Turney
2020-06-09 22:44         ` Brian Inglis
2020-08-06 20:20   ` Jon Turney
2020-08-06 21:04     ` Ken Brown
2020-08-07 19:42     ` Achim Gratz
2020-08-07 22:05       ` Ken Brown
2020-08-08  4:26         ` ASSI [this message]
2020-08-16 18:05         ` Jon Turney
2020-08-23 21:01   ` Jon Turney
2020-08-26 22:00     ` Ken Brown
2020-08-30 15:00       ` Jon Turney
2020-08-30 15:22         ` Ken Brown
2020-08-30 15:46           ` Jon Turney
2020-08-30 17:25             ` Ken Brown
2020-08-30 20:06               ` Jon Turney
2020-11-12 21:30             ` Jon Turney
2020-08-30 16:44         ` ASSI
2020-08-30 20:08           ` Jon Turney
2020-10-04 10:26           ` Achim Gratz
2020-10-25 18:10             ` Jon Turney
2021-05-09 14:39     ` Jon Turney
2021-06-22 19:52       ` Jon Turney
2021-06-23  4:22         ` Brian Inglis
2022-07-05 13:12         ` Jon Turney
2023-02-18 16:21           ` Jon Turney
2023-02-18 17:43             ` Ken Brown
2023-02-18 18:40               ` Jon Turney
2020-11-16 21:54   ` Brian Inglis
2020-11-16 22:16     ` Jon Turney
2020-11-16 22:54       ` Brian Inglis
2020-11-17 19:21     ` Achim Gratz
2020-05-29 14:40 ` Alexey Sokolov
2020-06-07 15:06   ` Hamish McIntyre-Bhatty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kpd225o.fsf@Otto.invalid \
    --to=stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).