public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: git repositories for cygwin packaging - please test
Date: Sun, 16 Aug 2020 19:05:44 +0100	[thread overview]
Message-ID: <c1025583-f9bc-30a9-9441-92491763bfe9@dronecode.org.uk> (raw)
In-Reply-To: <fa34e0c7-72a4-3cbb-d816-2aa9b1e2aeb2@cornell.edu>

On 07/08/2020 23:05, Ken Brown via Cygwin-apps wrote:
> On 8/7/2020 3:42 PM, Achim Gratz wrote:
>> Jon Turney writes:
>>> One problem I have noticed is that some packages have test suites
>>> (which are getting run via 'cygport test' invoking src_test()) which:
>>>
>>> - require lots of extra dependencies to run, or
>>
>> I currently subsume these in BUILD_REQUIRES as they are indeed required
>> for a (complete) build.  It'd be possible to split them out into a
>> separate variable indeed, but that is yet another level of
>> specificatrion that needs to be figured out if it should become useful.

Yeah, the only saving is that we don't need to spend the time to install 
those packages if we aren't going to run the tests.

>>> - don't succeed on Cygwin, or
>>
>> Any such tests I usually patch out or mark expected fail whichever seems
>> easier.
>>
>>> - take an inordinate amount of time to run (exceeding the resource 
>>> limits)
>>
>> That is a problem that comes with CI I think and we didn't really have
>> had to consider so far.  I have a few packages that I don't run tests on
>> by default because the test suite produces hangs or other unstable
>> behaviour, but that is dealt with in the src_test function itself.
>> If there are really resource hungry tests they usually need to be
>> enabled somewhere and one could skip those if the build runs on CIm (how
>> to find that out?).
> 
> Here's an example where Jon's suggestion would have been useful: While 
> building php recently, I noticed that the test suite took forever.  I 
> would have been happy to have a way to tell the CI to skip the tests and 
> avoid exceeding the resource limits.  But I wouldn't want to do that by 
> modifying src_test, because I would still want to run the tests locally.

It should now be possible to add to the .cygport a line like:

SCALLYWAG="notest"

which instructs it not to run the src_test() phase.

  parent reply	other threads:[~2020-08-16 18:05 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 20:08 Jon Turney
2019-08-05  2:03 ` Ken Brown
2019-08-08 13:47 ` Andrew Schulman via cygwin-apps
2019-08-08 14:04 ` Andrew Schulman via cygwin-apps
2019-08-08 17:09   ` Ken Brown
2019-08-09 16:12     ` Jon Turney
2019-08-09 19:12       ` Ken Brown
2019-08-13 11:55         ` Jon Turney
2019-08-09 16:00 ` Jon Turney
2019-08-09 20:58 ` Brian Inglis
2019-08-13 11:55 ` Jon Turney
2019-08-19 18:36 ` Achim Gratz
2020-05-27 22:27 ` Jon Turney
2020-05-28 11:51   ` szgyg
2020-06-04 16:01   ` Ken Brown
2020-06-04 20:33     ` Brian Inglis
2020-06-09 13:26       ` Jon Turney
2020-06-09 22:44         ` Brian Inglis
2020-08-06 20:20   ` Jon Turney
2020-08-06 21:04     ` Ken Brown
2020-08-07 19:42     ` Achim Gratz
2020-08-07 22:05       ` Ken Brown
2020-08-08  4:26         ` ASSI
2020-08-16 18:05         ` Jon Turney [this message]
2020-08-23 21:01   ` Jon Turney
2020-08-26 22:00     ` Ken Brown
2020-08-30 15:00       ` Jon Turney
2020-08-30 15:22         ` Ken Brown
2020-08-30 15:46           ` Jon Turney
2020-08-30 17:25             ` Ken Brown
2020-08-30 20:06               ` Jon Turney
2020-11-12 21:30             ` Jon Turney
2020-08-30 16:44         ` ASSI
2020-08-30 20:08           ` Jon Turney
2020-10-04 10:26           ` Achim Gratz
2020-10-25 18:10             ` Jon Turney
2021-05-09 14:39     ` Jon Turney
2021-06-22 19:52       ` Jon Turney
2021-06-23  4:22         ` Brian Inglis
2022-07-05 13:12         ` Jon Turney
2023-02-18 16:21           ` Jon Turney
2023-02-18 17:43             ` Ken Brown
2023-02-18 18:40               ` Jon Turney
2020-11-16 21:54   ` Brian Inglis
2020-11-16 22:16     ` Jon Turney
2020-11-16 22:54       ` Brian Inglis
2020-11-17 19:21     ` Achim Gratz
2020-05-29 14:40 ` Alexey Sokolov
2020-06-07 15:06   ` Hamish McIntyre-Bhatty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1025583-f9bc-30a9-9441-92491763bfe9@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).