public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] libsass v3.3.6
Date: Mon, 06 Jun 2016 17:07:00 -0000	[thread overview]
Message-ID: <878tyiz1o6.fsf@Rainer.invalid> (raw)
In-Reply-To: <CABKfh3y80xOvhVSGguLB+Ygt2y3DahmfUbtJcSWHdqHGY76ioA@mail.gmail.com>	(Marcos Vives Del Sol's message of "Mon, 6 Jun 2016 18:45:39 +0200")

Marcos Vives Del Sol writes:
>> to avoid the useless creation of libsass-3.3.6-1.src.patch
> Actually the patch isn't useless. It creates a VERSION file which
> version.sh expects to exist during the building process. Without that
> file, the library reports version "[na]" instead of the correct 3.3.6.

That file is created by configure, so patching it in anyway is still
useless.  In fact it's wrong the next time you update the source
archive.  You should never package files or patches that the build
system can re-create (and by extension remove such files from the source
directory should upstream package them for folks who don't use the full
configury).


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

  reply	other threads:[~2016-06-06 17:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 15:10 Marcos Vives Del Sol
2016-06-06 10:09 ` Marco Atzeri
2016-06-06 16:46   ` Marcos Vives Del Sol
2016-06-06 17:07     ` Achim Gratz [this message]
2016-06-07  9:36       ` Marcos Vives Del Sol
2016-06-07  9:49         ` Achim Gratz
2016-06-07 10:02           ` Marco Atzeri
2016-06-07 22:18             ` Marcos Vives Del Sol
2016-06-08  5:46               ` Achim Gratz
2016-06-08  8:02                 ` Marcos Vives Del Sol
2016-06-08 18:55                   ` Achim Gratz
2016-06-09  9:37               ` Marco Atzeri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tyiz1o6.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).