From: Marcos Vives Del Sol <socram8888@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] libsass v3.3.6
Date: Mon, 06 Jun 2016 16:46:00 -0000 [thread overview]
Message-ID: <CABKfh3y80xOvhVSGguLB+Ygt2y3DahmfUbtJcSWHdqHGY76ioA@mail.gmail.com> (raw)
In-Reply-To: <8005b674-1e74-a909-50ca-2a0b4fb0e570@gmail.com>
2016-06-06 12:08 GMT+02:00 Marco Atzeri:
> builds and packages fine, but I suggest you
>
> 1) to add
>
> DIFF_EXCLUDES="VERSION"
>
> to avoid the useless creation of libsass-3.3.6-1.src.patch
Actually the patch isn't useless. It creates a VERSION file which
version.sh expects to exist during the building process. Without that
file, the library reports version "[na]" instead of the correct 3.3.6.
> 2) to move "usr/share/doc" from "libsass0" to "libsass-devel"
I've moved it to -devel, so they cygport file now reads:
---------------------------------------
# libsass
libsass0_SUMMARY="${SUMMARY} (runtime)"
libsass0_DESCRIPTION="${DESCRIPTION}"
libsass0_CATEGORY="Libs"
libsass0_CONTENTS="usr/bin/"
# libsass-devel
libsass_devel_SUMMARY="${SUMMARY} (development)"
libsass_devel_DESCRIPTION="${DESCRIPTION}"
libsass_devel_CATEGORY="Libs Devel"
libsass_devel_CONTENTS="usr/include/ usr/lib/ usr/share/doc/"
---------------------------------------
The updated package is available here: http://mural.uv.es/videlsol/libsass/
> I assume you tested it as per
> https://github.com/sass/sass-spec
Regarding tests, to be honest, I had not run any before. I tried
compiling a few Sass using sassc from Bootstrap v4 and it all went
fine, so I assumed it was working as expected. I've just now run them,
and there are nine parsing errors (out of around five thousands
asserts). The execution and the errors and can be seen here:
http://pastebin.com/yTcpK3Pj
They are probably nothing to worry about: the libsass library is for
the 3.3.x version of the specification, while the spec repository only
has tests for 3.4 onwards. I suppose the failing tests are caused by
newer features not available in the 3.3.x specification.
Regards,
--
Marcos Vives Del Sol
https://github.com/socram8888
miniLock: NscWdW8fh2E5SBoRtrnXWrDwmQmwaR5awMKE78tQW1Ffx
next prev parent reply other threads:[~2016-06-06 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 15:10 Marcos Vives Del Sol
2016-06-06 10:09 ` Marco Atzeri
2016-06-06 16:46 ` Marcos Vives Del Sol [this message]
2016-06-06 17:07 ` Achim Gratz
2016-06-07 9:36 ` Marcos Vives Del Sol
2016-06-07 9:49 ` Achim Gratz
2016-06-07 10:02 ` Marco Atzeri
2016-06-07 22:18 ` Marcos Vives Del Sol
2016-06-08 5:46 ` Achim Gratz
2016-06-08 8:02 ` Marcos Vives Del Sol
2016-06-08 18:55 ` Achim Gratz
2016-06-09 9:37 ` Marco Atzeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABKfh3y80xOvhVSGguLB+Ygt2y3DahmfUbtJcSWHdqHGY76ioA@mail.gmail.com \
--to=socram8888@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).