[ITA] python-imaging

[ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 589 bytes --]

Hello,

This email signals my intent to adopt python-imaging
(https://pypi.org/project/Pillow) for Cygwin, as after being informed by
Yaakov I have realised there was already a Cygwin package for this.

I wish to package this because I have found that PyCrust (built with
wxPython) depends on it and there is a much newer version than is
currently available for Cygwin.

Attached is my cygport file. As usual, the test packages are available
at https://www.hamishmb.com/files/cygwin-temp/.

If anyone has feedback I'd appreciate it very much.

Hamish McIntyre-Bhatty




[-- Attachment #1.1.2: python-imaging.cygport --]
[-- Type: text/plain, Size: 4306 bytes --]

ORIG_PN="Pillow"
inherit python-wheel

NAME="python-imaging"
VERSION=7.2.0
RELEASE=1
CATEGORY="Python"
SUMMARY="Python Imaging Library"
DESCRIPTION="The Python Imaging Library (PIL) adds image processing capabilities
to your Python interpreter. This library supports many file formats, and provides
powerful image processing and graphics capabilities."
HOMEPAGE="https://python-pillow.github.io/"

SRC_URI="https://files.pythonhosted.org/packages/3e/02/b09732ca4b14405ff159c470a612979acfc6e8645dc32f83ea0129709f7a/Pillow-7.2.0.tar.gz"
SRC_DIR="Pillow-${VERSION}"
PATCH_URI=""

BUILD_REQUIRES="libjpeg-devel libjpeg8 zlib-devel zlib0 libtiff-devel libtiff6 libfreetype-devel libfreetype6 liblcms2-devel lcms2 libwebp libwebp-devel tcl-devel tcl libimagequant-devel libimagequant0 libraqm-devel libraqm0 libX11-xcb-devel libX11-xcb1 libxcb-devel libxcb1 python36 python36-devel python36-setuptools python36-wheel python36-pip python37 python37-devel python37-setuptools python37-wheel python37-pip python38 python38-devel python38-setuptools python38-wheel python38-pip"

DIFF_EXCLUDES="build"

PKG_NAMES=" python36-imaging python36-imaging-tk"
PKG_NAMES+=" python37-imaging python37-imaging-tk"
PKG_NAMES+=" python38-imaging python38-imaging-tk"

# ImageQt no longer imports PyQt or PySide, but simply integrates with
# whatever has already been imported.  Therefore there is no need to
# break it out separately, as it has no hard dependencies of its own.
python36_imaging_OBSOLETES+=" python3-imaging-devel python3-imaging-qt"
python36_imaging_CONTENTS="
	--exclude=_imagingtk*
	--exclude=ImageTk*
	--exclude=SpiderImagePlugin*
	usr/lib/python3.6/site-packages/PIL/
    usr/lib/python3.6/site-packages/Pillow-${VERSION}-py3.6.egg-info/
    usr/share/doc/python36-imaging/
"
python36_imaging_tk_OBSOLETES="python3-imaging-tk"
python36_imaging_tk_REQUIRES="python36-tkinter"
python36_imaging_tk_CONTENTS="
	usr/lib/python3.6/site-packages/PIL/_imagingtk*
	usr/lib/python3.6/site-packages/PIL/ImageTk*
	usr/lib/python3.6/site-packages/PIL/SpiderImagePlugin*
	usr/lib/python3.6/site-packages/PIL/__pycache__/ImageTk*
	usr/lib/python3.6/site-packages/PIL/__pycache__/SpiderImagePlugin*
"
python37_imaging_CONTENTS="
	--exclude=_imagingtk*
	--exclude=ImageTk*
	--exclude=SpiderImagePlugin*
	${python37_imaging_CONTENTS}
"
python37_imaging_tk_REQUIRES="python37-tkinter"
python37_imaging_tk_CONTENTS="
	usr/lib/python3.7/site-packages/PIL/_imagingtk*
	usr/lib/python3.7/site-packages/PIL/ImageTk*
	usr/lib/python3.7/site-packages/PIL/SpiderImagePlugin*
	usr/lib/python3.7/site-packages/PIL/__pycache__/ImageTk*
	usr/lib/python3.7/site-packages/PIL/__pycache__/SpiderImagePlugin*
"
python38_imaging_CONTENTS="
	--exclude=_imagingtk*
	--exclude=ImageTk*
	--exclude=SpiderImagePlugin*
	${python38_imaging_CONTENTS}
"
python38_imaging_tk_REQUIRES="python38-tkinter"
python38_imaging_tk_CONTENTS="
	usr/lib/python3.8/site-packages/PIL/_imagingtk*
	usr/lib/python3.8/site-packages/PIL/ImageTk*
	usr/lib/python3.8/site-packages/PIL/SpiderImagePlugin*
	usr/lib/python3.8/site-packages/PIL/__pycache__/ImageTk*
	usr/lib/python3.8/site-packages/PIL/__pycache__/SpiderImagePlugin*
"
python_imaging_debuginfo_OBSOLETES="python3-imaging-debuginfo"
PKG_IGNORE="usr/share/doc/python*-imaging-*/"

src_compile() {
	lndirs
	cd ${B}

    echo "Building for Python 3.6..."
	python3.6 setup.py build

    echo "Building for Python 3.7..."
	python3.7 setup.py build

    echo "Building for Python 3.8..."
	python3.8 setup.py build

}

src_test() {
    cd ${B}

    PYTHONPATH="build/lib.cygwin-$(uname -r | sed -e 's|s*(.*||')-$(uname -m)-3.6/" python3.6 selftest.py
    PYTHONPATH="build/lib.cygwin-$(uname -r | sed -e 's|s*(.*||')-$(uname -m)-3.7/" python3.7 selftest.py
    PYTHONPATH="build/lib.cygwin-$(uname -r | sed -e 's|s*(.*||')-$(uname -m)-3.8/" python3.8 selftest.py
}

src_install() {
	cd ${B}

    #------------ Python 3.6 ----------------
	python3.6 setup.py install --single-version-externally-managed --root ${D}

    #------------ Python 3.7 ----------------
    python3.7 setup.py install --single-version-externally-managed --root ${D}

    #------------ Python 3.8 ----------------
    python3.8 setup.py install --single-version-externally-managed --root ${D} --install-lib usr/lib/python3.8/site-packages/

}


[-- Attachment #1.1.3: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [ITA] python-imaging

[airplanemath]

Sending to actual list this time:

On 7/8/2020 10:59 AM, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
>> Hello,
>>
>> Attached is my cygport file. As usual, the test packages are available
>> at https://www.hamishmb.com/files/cygwin-temp/.
>>
>> If anyone has feedback I'd appreciate it very much.
> I tend to use loops like
>
> for ver in ${PYTHON_WHEEL_VERSIONS//:/ };
> do
>     /usr/bin/python${ver} script
> done
>
> for the tests.  Also, I believe ${ARCH} is the same as $(uname -m) here,
> if you want to streamline the PYTHONPATH definition a bit.  Both of
> those are personal style and you are entirely welcome to ignore this.
>
> Other than that, I noticed you're writing your own src_compile and
> src_install.  Is there some reason python_wheel_compile and
> python_wheel_install aren't working for you? I haven't noticed a problem
> with either of those functions in the past year or so.  (For reference, the
> value of PYTHON_WHEEL_VERSIONS determines which python versions
> are compiled: see
> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361).
>
> Thank you for taking up this package.
>
>> Hamish McIntyre-Bhatty

Re: [ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 1631 bytes --]

On 10/07/2020 01:20, airplanemath via Cygwin-apps wrote:
>> I tend to use loops like
>>
>> for ver in ${PYTHON_WHEEL_VERSIONS//:/ };
>> do
>>     /usr/bin/python${ver} script
>> done
>>
>> for the tests.  Also, I believe ${ARCH} is the same as $(uname -m) here,
>> if you want to streamline the PYTHONPATH definition a bit.  Both of
>> those are personal style and you are entirely welcome to ignore this.
Originally it was using a loop like that for the tests, but for some
reason not all of the Python versions I wanted to build for were being
tested that way (it was only doing 3.7 and 3.8). I figure I might as
well use ARCH then, makes it a bit clearer.
>> Other than that, I noticed you're writing your own src_compile and
>> src_install.  Is there some reason python_wheel_compile and
>> python_wheel_install aren't working for you? I haven't noticed a problem
>> with either of those functions in the past year or so.  (For reference, the
>> value of PYTHON_WHEEL_VERSIONS determines which python versions
>> are compiled: see
>> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361).

Ah, thank you for that link, that clears things up for me. I didn't
realise I could do that. So, I can just set PYTHON_WHEEL_VERSIONS to
"3.6:3.7:3.8" to build for those versions? I guess I don't need the
custom functions that way, that would make things simpler.

So far I've built for Python 3.6 and newer, should I also be building
for 3.5 or are we not bothered at this point?

>> Thank you for taking up this package.

You're welcome, and thanks for the advice :)

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [ITA] python-imaging

[marco atzeri]

On Fri, Jul 10, 2020 at 12:28 PM Hamish McIntyre-Bhatty via Cygwin-apps  wrote:
>
> On 10/07/2020 01:20, airplanemath via Cygwin-apps wrote:
> >> I tend to use loops like
> >>
> >> for ver in ${PYTHON_WHEEL_VERSIONS//:/ };
> >> do
> >>     /usr/bin/python${ver} script
> >> done
> >>
> >> for the tests.  Also, I believe ${ARCH} is the same as $(uname -m) here,
> >> if you want to streamline the PYTHONPATH definition a bit.  Both of
> >> those are personal style and you are entirely welcome to ignore this.
> Originally it was using a loop like that for the tests, but for some
> reason not all of the Python versions I wanted to build for were being
> tested that way (it was only doing 3.7 and 3.8). I figure I might as
> well use ARCH then, makes it a bit clearer.
> >> Other than that, I noticed you're writing your own src_compile and
> >> src_install.  Is there some reason python_wheel_compile and
> >> python_wheel_install aren't working for you? I haven't noticed a problem
> >> with either of those functions in the past year or so.  (For reference, the
> >> value of PYTHON_WHEEL_VERSIONS determines which python versions
> >> are compiled: see
> >> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361).
>
> Ah, thank you for that link, that clears things up for me. I didn't
> realise I could do that. So, I can just set PYTHON_WHEEL_VERSIONS to
> "3.6:3.7:3.8" to build for those versions? I guess I don't need the
> custom functions that way, that would make things simpler.
>
> So far I've built for Python 3.6 and newer, should I also be building
> for 3.5 or are we not bothered at this point?

I am not bothering with 3.5 for my builds.
The focus should be to have 3.8 up and running
so 3.6:3.7:3.8 are enough

>
> >> Thank you for taking up this package.
>
> You're welcome, and thanks for the advice :)
>
> Hamish

Regards
Marco

Re: [ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 1468 bytes --]

On 10/07/2020 13:24, marco atzeri via Cygwin-apps wrote:
> On Fri, Jul 10, 2020 at 12:28 PM Hamish McIntyre-Bhatty via Cygwin-apps  wrote:
>> On 10/07/2020 01:20, airplanemath via Cygwin-apps wrote:
>>>> I tend to use loops like
>>>>
>>>> for ver in ${PYTHON_WHEEL_VERSIONS//:/ };
>>>> do
>>>>     /usr/bin/python${ver} script
>>>> done
>>>>
>>>> for the tests.  Also, I believe ${ARCH} is the same as $(uname -m) here,
>>>> if you want to streamline the PYTHONPATH definition a bit.  Both of
>>>> those are personal style and you are entirely welcome to ignore this.
This worked a treat.
>>>> Other than that, I noticed you're writing your own src_compile and
>>>> src_install.  Is there some reason python_wheel_compile and
>>>> python_wheel_install aren't working for you? I haven't noticed a problem
>>>> with either of those functions in the past year or so.  (For reference, the
>>>> value of PYTHON_WHEEL_VERSIONS determines which python versions
>>>> are compiled: see
>>>> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361).
>>>>
This also worked really well, thanks for the tip :)

> I am not bothering with 3.5 for my builds.
> The focus should be to have 3.8 up and running
> so 3.6:3.7:3.8 are enough

Okay. I've updated my test packages, and they are available at
https://www.hamishmb.com/files/cygwin-temp/ as before. Please let me
know if I'm now good to go or if there are any more issues.

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 1605 bytes --]

On 14/07/2020 15:41, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
> On 10/07/2020 13:24, marco atzeri via Cygwin-apps wrote:
>> On Fri, Jul 10, 2020 at 12:28 PM Hamish McIntyre-Bhatty via Cygwin-apps  wrote:
>>> On 10/07/2020 01:20, airplanemath via Cygwin-apps wrote:
>>>>> I tend to use loops like
>>>>>
>>>>> for ver in ${PYTHON_WHEEL_VERSIONS//:/ };
>>>>> do
>>>>>     /usr/bin/python${ver} script
>>>>> done
>>>>>
>>>>> for the tests.  Also, I believe ${ARCH} is the same as $(uname -m) here,
>>>>> if you want to streamline the PYTHONPATH definition a bit.  Both of
>>>>> those are personal style and you are entirely welcome to ignore this.
> This worked a treat.
>>>>> Other than that, I noticed you're writing your own src_compile and
>>>>> src_install.  Is there some reason python_wheel_compile and
>>>>> python_wheel_install aren't working for you? I haven't noticed a problem
>>>>> with either of those functions in the past year or so.  (For reference, the
>>>>> value of PYTHON_WHEEL_VERSIONS determines which python versions
>>>>> are compiled: see
>>>>> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361).
>>>>>
> This also worked really well, thanks for the tip :)
>
>> I am not bothering with 3.5 for my builds.
>> The focus should be to have 3.8 up and running
>> so 3.6:3.7:3.8 are enough
> Okay. I've updated my test packages, and they are available at
> https://www.hamishmb.com/files/cygwin-temp/ as before. Please let me
> know if I'm now good to go or if there are any more issues.

*bump* in case no one has seen.

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [ITA] python-imaging

[Brian Inglis]

On 2020-07-17 15:03, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
> On 14/07/2020 15:41, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
>> On 10/07/2020 13:24, marco atzeri via Cygwin-apps wrote:
>>> On Fri, Jul 10, 2020 at 12:28 PM Hamish McIntyre-Bhatty via Cygwin-apps  wrote:
>>>> On 10/07/2020 01:20, airplanemath via Cygwin-apps wrote:
>>>>>> I tend to use loops like
>>>>>>
>>>>>> for ver in ${PYTHON_WHEEL_VERSIONS//:/ };
>>>>>> do
>>>>>>     /usr/bin/python${ver} script
>>>>>> done
>>>>>>
>>>>>> for the tests.  Also, I believe ${ARCH} is the same as $(uname -m) here,
>>>>>> if you want to streamline the PYTHONPATH definition a bit.  Both of
>>>>>> those are personal style and you are entirely welcome to ignore this.
>> This worked a treat.
>>>>>> Other than that, I noticed you're writing your own src_compile and
>>>>>> src_install.  Is there some reason python_wheel_compile and
>>>>>> python_wheel_install aren't working for you? I haven't noticed a problem
>>>>>> with either of those functions in the past year or so.  (For reference, the
>>>>>> value of PYTHON_WHEEL_VERSIONS determines which python versions
>>>>>> are compiled: see
>>>>>> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361).
>>>>>>
>> This also worked really well, thanks for the tip :)
>>
>>> I am not bothering with 3.5 for my builds.
>>> The focus should be to have 3.8 up and running
>>> so 3.6:3.7:3.8 are enough
>> Okay. I've updated my test packages, and they are available at
>> https://www.hamishmb.com/files/cygwin-temp/ as before. Please let me
>> know if I'm now good to go or if there are any more issues.
> 
> *bump* in case no one has seen.

Not yet:

$ curl https://cygwin.com/cygwin-pkg-maint | egrep 'Hamish|imaging'
python-imaging                               Yaakov Selkowitz
python-wx                                    Hamish McIntyre-Bhatty
python3-pillow                               Hamish McIntyre-Bhatty
python3-wx                                   Hamish McIntyre-Bhatty

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]

Re: [ITA] python-imaging

[Marco Atzeri]

On 17.07.2020 23:03, Hamish McIntyre-Bhatty via Cygwin-apps wrote:

>> Okay. I've updated my test packages, and they are available at
>> https://www.hamishmb.com/files/cygwin-temp/ as before. Please let me
>> know if I'm now good to go or if there are any more issues.
> 
> *bump* in case no one has seen.
> 
> Hamish
> 

I have seen, but I am currently busy with some of mine packages,
and my computer is not so fast to handle too many in parallel

Regards
Marco

Re: [ITA] python-imaging

[Marco Atzeri]

On 17.07.2020 23:25, Marco Atzeri wrote:
> On 17.07.2020 23:03, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
> 
>>> Okay. I've updated my test packages, and they are available at
>>> https://www.hamishmb.com/files/cygwin-temp/ as before. Please let me
>>> know if I'm now good to go or if there are any more issues.
>>
>> *bump* in case no one has seen.
>>
>> Hamish
>>
> 
> I have seen, but I am currently busy with some of mine packages,
> and my computer is not so fast to handle too many in parallel
> 
> Regards
> Marco

I change maintainership to you.

Before uploading can you rebuild so to pick dependency on all
version of python3x-olefile ?

Regards
Marco

Re: [ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 304 bytes --]

On 18/07/2020 21:07, Marco Atzeri via Cygwin-apps wrote:
> I change maintainership to you.
>
> Before uploading can you rebuild so to pick dependency on all
> version of python3x-olefile ?

Sure. I believe I can just change the cygport and hint files rather than
rebuilding for that?

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [ITA] python-imaging

[Marco Atzeri]

On 19.07.2020 18:36, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
> On 18/07/2020 21:07, Marco Atzeri via Cygwin-apps wrote:
>> I change maintainership to you.
>>
>> Before uploading can you rebuild so to pick dependency on all
>> version of python3x-olefile ?
> 
> Sure. I believe I can just change the cygport and hint files rather than
> rebuilding for that?
> 
> Hamish
> 

I assume you need to rebuild, as I saw python36-olefile and 
python37-olefile picked as dependency, so somewhere they were mentioned
in the packages.

If you plan to build other packages and you are missing a dependency
on any 3.8 subpackages let me know and I will put those
on top of the plan

Regards
Marco

Re: [ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 891 bytes --]

On 19/07/2020 18:09, Marco Atzeri via Cygwin-apps wrote:
> I assume you need to rebuild, as I saw python36-olefile and
> python37-olefile picked as dependency, so somewhere they were mentioned
> in the packages.
Okay, shall do tomorrow then. I note that while I can find the source
and binary packages for olefile on cygwin.com, it doesn't seem to be on
mirrors eg https://cygwin.mirror.uk.sargasso.net/x86/release/. Am I
being a bit stupid?
>
> If you plan to build other packages and you are missing a dependency
> on any 3.8 subpackages let me know and I will put those
> on top of the plan

Cheers, was going to suggest Numpy for Python 3.8, but looks like you
did that earlier today :). Guess I'll get a Python 3.8 build of wxPython
out too. With some luck (and some more debugging), I can have a version
of my GUI (DDRescue-GUI) out on Cygwin pretty soon.

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [ITA] python-imaging

[Marco Atzeri]

On 19.07.2020 19:26, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
> On 19/07/2020 18:09, Marco Atzeri via Cygwin-apps wrote:
>> I assume you need to rebuild, as I saw python36-olefile and
>> python37-olefile picked as dependency, so somewhere they were mentioned
>> in the packages.
> Okay, shall do tomorrow then. I note that while I can find the source
> and binary packages for olefile on cygwin.com, it doesn't seem to be on
> mirrors eg https://cygwin.mirror.uk.sargasso.net/x86/release/. Am I
> being a bit stupid?
>>

https://cygwin.mirror.uk.sargasso.net/noarch/release/python-olefile/

same packages are arch indipendent

>> If you plan to build other packages and you are missing a dependency
>> on any 3.8 subpackages let me know and I will put those
>> on top of the plan
> 
> Cheers, was going to suggest Numpy for Python 3.8, but looks like you
> did that earlier today :). Guess I'll get a Python 3.8 build of wxPython
> out too. With some luck (and some more debugging), I can have a version
> of my GUI (DDRescue-GUI) out on Cygwin pretty soon.
> 
> Hamish
> 

Regards
Marco

Re: [ITA] python-imaging

[Hamish McIntyre-Bhatty]

[-- Attachment #1.1.1: Type: text/plain, Size: 444 bytes --]

On 19/07/2020 20:09, Marco Atzeri via Cygwin-apps wrote:
> https://cygwin.mirror.uk.sargasso.net/noarch/release/python-olefile/
>
> same packages are arch indipendent

Ah of course, so I was being a bit stupid :)

Okay, it ended up being today because python3-wx took so long to build,
but test packages are now out for both python3-wx (a python 3.8 build)
and python-imaging 7.2.0.

Let me know if you have any issues.

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]