[ITA] ruby-tk 0.4.0

[ITA] ruby-tk 0.4.0

[Daisuke Fujimura]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hello,

====

Cygportfile:
- https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-tk

Packages, logs:
- https://github.com/cygwin/scallywag/actions/runs/4850129175


> If you subsequently adopt the ruby-tk package, please remember to add
> ruby_tk_OBSOLETES="ruby-tcltk" there (as that's the preferred way to
> record obsoletions nowadays)

Added according to advice.

[-- Attachment #2: ruby-tk.diff --]
[-- Type: application/octet-stream, Size: 655 bytes --]

--- ruby-tk/ruby-tk.cygport	2023-05-01 18:06:30
+++ playground/ruby-tk.cygport	2023-05-01 18:30:19
@@ -1,14 +1,19 @@
 inherit rubygem
 
 NAME="ruby-tk"
-VERSION=0.2.0
-RELEASE=2
+VERSION=0.4.0
+RELEASE=1
 CATEGORY="Ruby"
 SUMMARY="Ruby Tcl/Tk interface"
 DESCRIPTION="Tk interface module for Ruby using tcltklib"
 
 PATCH_URI="0.1.2-cygwin-x11.patch"
 
+BUILD_REQUIRES="libX11-devel tcl-tk-devel"
+
+LICENSE="Ruby"
+
 PKG_NAMES="${NAME} ${NAME}-doc"
 ruby_tk_CONTENTS="--exclude=sample "${RUBYGEM_EXTDIR#/}" "${RUBYGEM_INSTDIR#/}" "${RUBYGEM_SPEC#/}
 ruby_tk_doc_CONTENTS=${RUBYGEM_DOCDIR#/}" "${RUBYGEM_INSTDIR#/}/sample/
+ruby_tk_OBSOLETES="ruby-tcltk"

Re: [ITA] ruby-tk 0.4.0

[Jon Turney]

On 01/05/2023 10:54, Daisuke Fujimura via Cygwin-apps wrote:
> Hello,
> 
> ====
> 
> Cygportfile:
> - https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-tk
> 
> Packages, logs:
> - https://github.com/cygwin/scallywag/actions/runs/4850129175

Is this error expected?

https://github.com/cygwin/scallywag/actions/runs/4850129175/jobs/8642826755#step:6:1723

>> If you subsequently adopt the ruby-tk package, please remember to add
>> ruby_tk_OBSOLETES="ruby-tcltk" there (as that's the preferred way to
>> record obsoletions nowadays)
> 
> Added according to advice.

Looks good.  I added this to your packages.

Thanks

Re: [ITA] ruby-tk 0.4.0

[Daisuke Fujimura]

> Is this error expected?

Sorry, I missed that.

This seems to be caused by rdoc-6.1.2 not working with ruby-3.x.

- https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

Therefore, it is necessary to update rdoc first, but packaging
rdoc-6.5.0 also fails for the same reason, so it needs to be updated
by other means besides scallywag:

- Create a package using ruby-2.6.4.
- Create a package using rdoc-6.5.0 installed in a different location
with gem install.

Other issues have also been found.

- https://github.com/cygwin/scallywag/actions/runs/4850129175/jobs/8642826755#step:6:223

This seems to need a fix in rubygems.cygclass, so I will send a patch.

I will work in the following order.

1. Send a patch for rubygems.cygclass
2. ITA ruby-rdoc
3. ITA ruby-tk


On Tue, May 2, 2023 at 2:56 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 01/05/2023 10:54, Daisuke Fujimura via Cygwin-apps wrote:
> > Hello,
> >
> > ====
> >
> > Cygportfile:
> > - https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-tk
> >
> > Packages, logs:
> > - https://github.com/cygwin/scallywag/actions/runs/4850129175
>
> Is this error expected?
>
> https://github.com/cygwin/scallywag/actions/runs/4850129175/jobs/8642826755#step:6:1723
>
> >> If you subsequently adopt the ruby-tk package, please remember to add
> >> ruby_tk_OBSOLETES="ruby-tcltk" there (as that's the preferred way to
> >> record obsoletions nowadays)
> >
> > Added according to advice.
>
> Looks good.  I added this to your packages.
>
> Thanks

Re: [ITA] ruby-tk 0.4.0

[Jon Turney]

On 02/05/2023 10:31, Daisuke Fujimura via Cygwin-apps wrote:
>> Is this error expected?
> 
> Sorry, I missed that.
> 
> This seems to be caused by rdoc-6.1.2 not working with ruby-3.x.
> 
> - https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
> 
> Therefore, it is necessary to update rdoc first, but packaging
> rdoc-6.5.0 also fails for the same reason, so it needs to be updated
> by other means besides scallywag:

If you can locally build a working package, you can use 'cygport upload' 
  to upload it (and then push the update to the packaging repo with 
'--push-option=nobuild').

> - Create a package using ruby-2.6.4.
> - Create a package using rdoc-6.5.0 installed in a different location
> with gem install.
> 
> Other issues have also been found.
> 
> - https://github.com/cygwin/scallywag/actions/runs/4850129175/jobs/8642826755#step:6:223
> 
> This seems to need a fix in rubygems.cygclass, so I will send a patch.
> 
> I will work in the following order.
> 
> 1. Send a patch for rubygems.cygclass
> 2. ITA ruby-rdoc
> 3. ITA ruby-tk

Thanks very much.

Re: [ITA] ruby-tk 0.4.0

[Daisuke Fujimura]

> If you can locally build a working package, you can use 'cygport upload'
>   to upload it (and then push the update to the packaging repo with
> '--push-option=nobuild').

Thanks for the advice!

I have confirmed that ruby-tk can be packaged by updating cygport and ruby-rdoc.

- https://github.com/cygwin/scallywag/actions/runs/4889008372
  - https://github.com/cygwin/scallywag/actions/runs/4889008372/jobs/8727225513#step:6:223
(Bin dir is correct)
  - https://github.com/cygwin/scallywag/actions/runs/4889008372/jobs/8727225513#step:6:1722
(ERROR not found)


On Wed, May 3, 2023 at 2:22 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 02/05/2023 10:31, Daisuke Fujimura via Cygwin-apps wrote:
> >> Is this error expected?
> >
> > Sorry, I missed that.
> >
> > This seems to be caused by rdoc-6.1.2 not working with ruby-3.x.
> >
> > - https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
> >
> > Therefore, it is necessary to update rdoc first, but packaging
> > rdoc-6.5.0 also fails for the same reason, so it needs to be updated
> > by other means besides scallywag:
>
> If you can locally build a working package, you can use 'cygport upload'
>   to upload it (and then push the update to the packaging repo with
> '--push-option=nobuild').
>
> > - Create a package using ruby-2.6.4.
> > - Create a package using rdoc-6.5.0 installed in a different location
> > with gem install.
> >
> > Other issues have also been found.
> >
> > - https://github.com/cygwin/scallywag/actions/runs/4850129175/jobs/8642826755#step:6:223
> >
> > This seems to need a fix in rubygems.cygclass, so I will send a patch.
> >
> > I will work in the following order.
> >
> > 1. Send a patch for rubygems.cygclass
> > 2. ITA ruby-rdoc
> > 3. ITA ruby-tk
>
> Thanks very much.
>