[ATTN MAINTAINER] tig

[ATTN MAINTAINER] tig

[Libor Ukropec]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hello Jari,

cygwin contains "tig" in version 2.4.1 (2019-07-30) and there's already 2.5.4 (2021) with 
many bug fixes and improvements available.
Can I kindly ask whether it is possible to update the package?
I do not see a git repository for the tig package, so I attached the cygport file if it 
can save you some effort (in compare to the following scallywag, I've added the LICENSE 
info the script)

Scallywag report is here: https://github.com/cygwin/scallywag/actions/runs/3670966767

Thank you and regards,
Libor

[-- Attachment #2: tig.cygport --]
[-- Type: text/plain, Size: 902 bytes --]

# package name
NAME="tig"
VERSION=2.5.4
RELEASE=1

# .hint generation
CATEGORY="Utils"
SUMMARY="Curses based git repository browser"
DESCRIPTION="A command line repository browser capable of displaying a summarized
revision log and showing commit log messages, diffstats and diffs. Program
may also be used as a pager. It reads input from stdin and colorizes it."
HOMEPAGE="https://jonas.github.io/tig/"
LICENSE="GPL-2.0"

# source and patch files
SRC_URI="https://github.com/jonas/${NAME}/releases/download/${NAME}-${VERSION}/${NAME}-${VERSION}.tar.gz"
REQUIRES="git libiconv2 libreadline7"
BUILD_REQUIRES+="gcc-g++ libncurses-devel libiconv-devel asciidoc"

MAKEOPTS="prefix=/usr sysconfdir=/etc"

# use modified src_compile and src_install
src_compile() {
	warning $S
        cd ${S}
	lndirs
	cd ${B}
	./configure --prefix=/usr
	cygmake
}

src_install() {
	cd ${B}
	cyginstall install install-doc
}

Re: [ATTN MAINTAINER] tig

[Adam Dinwoodie]

On Sun, Dec 11, 2022 at 11:15:35PM +0100, Libor Ukropec via Cygwin-apps wrote:
> Hello Jari,
> 
> cygwin contains "tig" in version 2.4.1 (2019-07-30) and there's already
> 2.5.4 (2021) with many bug fixes and improvements available.
> Can I kindly ask whether it is possible to update the package?
> I do not see a git repository for the tig package, so I attached the cygport
> file if it can save you some effort (in compare to the following scallywag,
> I've added the LICENSE info the script)
> 
> Scallywag report is here: https://github.com/cygwin/scallywag/actions/runs/3670966767

I believe Jari's repo for the tig Cygwin packaging is on GitHub[0], and
it looks like it's using the old pre-Cygport packaging mechanism.  I've
not looked through that repo myself (yet, at least) but it looks like
there are some patches that imply a naïve build might not work
perfectly.  Or those packages might be entirely obsolete...

[0]: https://github.com/jaalto/cygwin-package--tig

FWIW, I'd be happy to at least attempt to add this package to my small
Cygwin Git packaging empire, and take responsibility for keeping it up
to date going forwards.  But that's only if Jari wants to relinquish
that hat, and even then I think Libor clearly gets first refusal given
they've written the new Cygport file.

Re: [ATTN MAINTAINER] tig

[Libor Ukropec]

Dne 12.12.2022 v 17:32 Adam Dinwoodie via Cygwin-apps napsal(a):
> On Sun, Dec 11, 2022 at 11:15:35PM +0100, Libor Ukropec via Cygwin-apps wrote:
>> Hello Jari,
>>
>> cygwin contains "tig" in version 2.4.1 (2019-07-30) and there's already
>> 2.5.4 (2021) with many bug fixes and improvements available.
>> Can I kindly ask whether it is possible to update the package?
>> I do not see a git repository for the tig package, so I attached the cygport
>> file if it can save you some effort (in compare to the following scallywag,
>> I've added the LICENSE info the script)
>>
>> Scallywag report is here: https://github.com/cygwin/scallywag/actions/runs/3670966767
> 
> I believe Jari's repo for the tig Cygwin packaging is on GitHub[0], and
> it looks like it's using the old pre-Cygport packaging mechanism.  I've
> not looked through that repo myself (yet, at least) but it looks like
> there are some patches that imply a naïve build might not work
> perfectly.  Or those packages might be entirely obsolete...
I did not look for the GitHub, but the naive compile and run worked with few custom 
actions in the cygport script.
> 
> [0]: https://github.com/jaalto/cygwin-package--tig
> 
> FWIW, I'd be happy to at least attempt to add this package to my small
> Cygwin Git packaging empire, and take responsibility for keeping it up
> to date going forwards.  But that's only if Jari wants to relinquish

Yes, let's wait for Jari's answer
> that hat, and even then I think Libor clearly gets first refusal given
> they've written the new Cygport file.
> 
Here comes my weak English. Will I be refused by Jari or do you mean that I will refuse 
you because I did the Cygport file?

If the latter, I have no objections you are the maintainer (let's wait for Jari), I just 
wanted to give a helpful hand, not only to rudely ask for the update. And also to play 
more with the cygports and expand my portfolio (I am shy to say `empire`)  :)

Re: [ATTN MAINTAINER] tig

[Adam Dinwoodie]

On Tue, 13 Dec 2022 at 17:16, Libor Ukropec via Cygwin-apps wrote:
>
> Dne 12.12.2022 v 17:32 Adam Dinwoodie via Cygwin-apps napsal(a):
> > On Sun, Dec 11, 2022 at 11:15:35PM +0100, Libor Ukropec via Cygwin-apps wrote:
> >> Hello Jari,
> >>
> >> cygwin contains "tig" in version 2.4.1 (2019-07-30) and there's already
> >> 2.5.4 (2021) with many bug fixes and improvements available.
> >> Can I kindly ask whether it is possible to update the package?
> >> I do not see a git repository for the tig package, so I attached the cygport
> >> file if it can save you some effort (in compare to the following scallywag,
> >> I've added the LICENSE info the script)
> >>
> >> Scallywag report is here: https://github.com/cygwin/scallywag/actions/runs/3670966767
> >
> > I believe Jari's repo for the tig Cygwin packaging is on GitHub[0], and
> > it looks like it's using the old pre-Cygport packaging mechanism.  I've
> > not looked through that repo myself (yet, at least) but it looks like
> > there are some patches that imply a naïve build might not work
> > perfectly.  Or those packages might be entirely obsolete...
> I did not look for the GitHub, but the naive compile and run worked with few custom
> actions in the cygport script.
> >
> > [0]: https://github.com/jaalto/cygwin-package--tig
> >
> > FWIW, I'd be happy to at least attempt to add this package to my small
> > Cygwin Git packaging empire, and take responsibility for keeping it up
> > to date going forwards.  But that's only if Jari wants to relinquish
>
> Yes, let's wait for Jari's answer
> > that hat, and even then I think Libor clearly gets first refusal given
> > they've written the new Cygport file.
> >
> Here comes my weak English. Will I be refused by Jari or do you mean that I will refuse
> you because I did the Cygport file?
>
> If the latter, I have no objections you are the maintainer (let's wait for Jari), I just
> wanted to give a helpful hand, not only to rudely ask for the update. And also to play
> more with the cygports and expand my portfolio (I am shy to say `empire`)  :)

Apologies for the idioms! I mean that if Jari wants to stop being the
maintainer, you should be allowed to become the maintainer if you want
to, because you wrote the up-to-date cygport file.

"First refusal" means, essentially, that you get given the chance to
do something before anyone else does. In this case, you'd get the
option to become maintainer, and I would only get the option to do so
if you refused.

Re: [ATTN MAINTAINER] tig

[Libor Ukropec]

> "First refusal" means, essentially, that you get given the chance to
> do something before anyone else does. In this case, you'd get the
> option to become maintainer, and I would only get the option to do so
> if you refused.
> 
Got it. As I said, let's wait for Jari. Because you were the first who 
clearly expressed the willingness to maintain, you won over me, I was 
too shy. But I expect you will keep it up to date (no excuses), because 
it is a git Swiss knife on all Win/Lin/Mac platforms and I cannot live 
without it. In the meantime you can try the cygport on your side, thx.

Re: [ATTN MAINTAINER] tig

[Jari Aalto]

On 2022-12-13 18:14, Libor Ukropec via Cygwin-apps wrote:
> Dne 12.12.2022 v 17:32 Adam Dinwoodie via Cygwin-apps napsal(a):
> > On Sun, Dec 11, 2022 at 11:15:35PM +0100, Libor Ukropec via Cygwin-apps wrote:
> > > Hello Jari,
> > > 
> > > cygwin contains "tig" in version 2.4.1 (2019-07-30) and there's already
> > > 2.5.4 (2021) with many bug fixes and improvements available.
> > > Can I kindly ask whether it is possible to update the package?
> > > I do not see a git repository for the tig package, so I attached the cygport
> > > file if it can save you some effort (in compare to the following scallywag,
> > > I've added the LICENSE info the script)
> > > 
> > > Scallywag report is here: https://github.com/cygwin/scallywag/actions/runs/3670966767
> > 
> > I believe Jari's repo for the tig Cygwin packaging is on GitHub[0], and
> > it looks like it's using the old pre-Cygport packaging mechanism.  I've
> > not looked through that repo myself (yet, at least) but it looks like
> > there are some patches that imply a naïve build might not work
> > perfectly.  Or those packages might be entirely obsolete...
> I did not look for the GitHub, but the naive compile and run worked with few
> custom actions in the cygport script.
> > 
> > [0]: https://github.com/jaalto/cygwin-package--tig
> > 
> > FWIW, I'd be happy to at least attempt to add this package to my small
> > Cygwin Git packaging empire, and take responsibility for keeping it up
> > to date going forwards.  But that's only if Jari wants to relinquish
> 
> Yes, let's wait for Jari's answer
> > that hat, and even then I think Libor clearly gets first refusal given
> > they've written the new Cygport file.
> > 
> Here comes my weak English. Will I be refused by Jari or do you mean that I
> will refuse you because I did the Cygport file?

Hi, Thanks for the heads up. I've uploaded new version and added the
*.cygport in my Github repository of tig for possible new maintainer
in the future.

The patches deal some fixes in the xmlto(1) of manual pages build.

Jari

Re: [ATTN MAINTAINER] tig

[Libor Ukropec]

Dne 10.01.2023 v 15:04 Jari Aalto via Cygwin-apps napsal(a):

> 
> Hi, Thanks for the heads up. I've uploaded new version and added the
> *.cygport in my Github repository of tig for possible new maintainer
> in the future.
> 
> The patches deal some fixes in the xmlto(1) of manual pages build.
> 
> Jari
> 
Hi Jari,

I updated to the latest tig, but when executing, it complains about missing dependency, 
but recently I saw many updates to the cygwin packages. Any idea if other package was 
broken, or tig is missing some dependency in the metadata?

C:/cygwin64/bin/tig.exe: error while loading shared libraries: cygpcreposix-0.dll: cannot 
open shared object file: No such file or directory

Manual installation of "libpcreposix0 8.45-1" seems resolving the problem.

Libor

Re: [ATTN MAINTAINER] tig

[Libor Ukropec]

Dne 13.01.2023 v 17:59 Libor Ukropec via Cygwin-apps napsal(a):
> Dne 10.01.2023 v 15:04 Jari Aalto via Cygwin-apps napsal(a):
> 
>>
>> Hi, Thanks for the heads up. I've uploaded new version and added the
>> *.cygport in my Github repository of tig for possible new maintainer
>> in the future.
>>
>> The patches deal some fixes in the xmlto(1) of manual pages build.
>>
>> Jari
>>
> Hi Jari,
> 
> I updated to the latest tig, but when executing, it complains about missing dependency, 
> but recently I saw many updates to the cygwin packages. Any idea if other package was 
> broken, or tig is missing some dependency in the metadata?
> 
> C:/cygwin64/bin/tig.exe: error while loading shared libraries: cygpcreposix-0.dll: cannot 
> open shared object file: No such file or directory
> 
> Manual installation of "libpcreposix0 8.45-1" seems resolving the problem.
> 
> Libor
> 
Problem lies somewhere in the compile process?
here is my output for tig I compiled few weeks ago:

$ ldd ./ttiigg/tig-2.5.4-1.x86_64/build/src/tig.exe
         ntdll.dll => /cygdrive/c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffe86590000)
         KERNEL32.DLL => /cygdrive/c/WINDOWS/System32/KERNEL32.DLL (0x7ffe85160000)
         KERNELBASE.dll => /cygdrive/c/WINDOWS/System32/KERNELBASE.dll (0x7ffe839e0000)
         cygwin1.dll => /usr/bin/cygwin1.dll (0x7ffe416d0000)
         cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x5461d0000)
         cygncursesw-10.dll => /usr/bin/cygncursesw-10.dll (0x48ca30000)


and here is from the installed:
$ ldd /usr/bin/tig.exe
         ntdll.dll => /cygdrive/c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffe86590000)
         KERNEL32.DLL => /cygdrive/c/WINDOWS/System32/KERNEL32.DLL (0x7ffe85160000)
         KERNELBASE.dll => /cygdrive/c/WINDOWS/System32/KERNELBASE.dll (0x7ffe839e0000)
         cygwin1.dll => /usr/bin/cygwin1.dll (0x7ffe416d0000)
         cygncursesw-10.dll => /usr/bin/cygncursesw-10.dll (0x48ca30000)
         cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x5461d0000)
         cygpcre-1.dll => /usr/bin/cygpcre-1.dll (0x3fd630000)
         cygreadline7.dll => /usr/bin/cygreadline7.dll (0x579cd0000)
         cygpcreposix-0.dll => /usr/bin/cygpcreposix-0.dll (0x520b40000)

Re: [ATTN MAINTAINER] tig

[Brian Inglis]

On 2023-01-13 10:06, Libor Ukropec via Cygwin-apps wrote:
> Dne 13.01.2023 v 17:59 Libor Ukropec via Cygwin-apps napsal(a):
>> Dne 10.01.2023 v 15:04 Jari Aalto via Cygwin-apps napsal(a):
>>> Thanks for the heads up. I've uploaded new version and added the
>>> *.cygport in my Github repository of tig for possible new maintainer
>>> in the future.
>>> The patches deal some fixes in the xmlto(1) of manual pages build.

>> I updated to the latest tig, but when executing, it complains about missing 
>> dependency, but recently I saw many updates to the cygwin packages. Any idea 
>> if other package was broken, or tig is missing some dependency in the metadata?
>> C:/cygwin64/bin/tig.exe: error while loading shared libraries: 
>> cygpcreposix-0.dll: cannot open shared object file: No such file or directory
>> Manual installation of "libpcreposix0 8.45-1" seems resolving the problem.

> Problem lies somewhere in the compile process?
> here is my output for tig I compiled few weeks ago:
> $ ldd ./ttiigg/tig-2.5.4-1.x86_64/build/src/tig.exe
>          ntdll.dll => /cygdrive/c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffe86590000)
>          KERNEL32.DLL => /cygdrive/c/WINDOWS/System32/KERNEL32.DLL (0x7ffe85160000)
>          KERNELBASE.dll => /cygdrive/c/WINDOWS/System32/KERNELBASE.dll 
> (0x7ffe839e0000)
>          cygwin1.dll => /usr/bin/cygwin1.dll (0x7ffe416d0000)
>          cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x5461d0000)
>          cygncursesw-10.dll => /usr/bin/cygncursesw-10.dll (0x48ca30000)
> and here is from the installed:
> $ ldd /usr/bin/tig.exe
>          ntdll.dll => /cygdrive/c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffe86590000)
>          KERNEL32.DLL => /cygdrive/c/WINDOWS/System32/KERNEL32.DLL (0x7ffe85160000)
>          KERNELBASE.dll => /cygdrive/c/WINDOWS/System32/KERNELBASE.dll 
> (0x7ffe839e0000)
>          cygwin1.dll => /usr/bin/cygwin1.dll (0x7ffe416d0000)
>          cygncursesw-10.dll => /usr/bin/cygncursesw-10.dll (0x48ca30000)
>          cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x5461d0000)
>          cygpcre-1.dll => /usr/bin/cygpcre-1.dll (0x3fd630000)
>          cygreadline7.dll => /usr/bin/cygreadline7.dll (0x579cd0000)
>          cygpcreposix-0.dll => /usr/bin/cygpcreposix-0.dll (0x520b40000)

Config issues, as you appear not to have installed prerequisite packages 
libncurses-devel, libpcre-devel, libreadline-devel in your build environment. 
Those package names should also be added to your cygport DEPEND/BUILD_REQUIRES+= 
string variables, so that cygport can warn you if the packages are not 
installed, and will be auto-installed so the package builds cleanly under 
Scallywag CI, when you push your cygport (and other sources and patches) to 
git/cygwin-packages playground repo or package branch or master package branch.

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

Re: [ATTN MAINTAINER] tig

[Adam Dinwoodie]

On Fri, Jan 13, 2023 at 06:06:22PM +0100, Libor Ukropec via Cygwin-apps wrote:
> Dne 13.01.2023 v 17:59 Libor Ukropec via Cygwin-apps napsal(a):
> > Dne 10.01.2023 v 15:04 Jari Aalto via Cygwin-apps napsal(a):
> > 
> > > 
> > > Hi, Thanks for the heads up. I've uploaded new version and added the
> > > *.cygport in my Github repository of tig for possible new maintainer
> > > in the future.
> > > 
> > > The patches deal some fixes in the xmlto(1) of manual pages build.
> > > 
> > > Jari
> > > 
> > Hi Jari,
> > 
> > I updated to the latest tig, but when executing, it complains about
> > missing dependency, but recently I saw many updates to the cygwin
> > packages. Any idea if other package was broken, or tig is missing some
> > dependency in the metadata?
> > 
> > C:/cygwin64/bin/tig.exe: error while loading shared libraries:
> > cygpcreposix-0.dll: cannot open shared object file: No such file or
> > directory
> > 
> > Manual installation of "libpcreposix0 8.45-1" seems resolving the problem.
> > 
> > Libor
> > 
> Problem lies somewhere in the compile process?
> here is my output for tig I compiled few weeks ago:
> 
> $ ldd ./ttiigg/tig-2.5.4-1.x86_64/build/src/tig.exe
>         ntdll.dll => /cygdrive/c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffe86590000)
>         KERNEL32.DLL => /cygdrive/c/WINDOWS/System32/KERNEL32.DLL (0x7ffe85160000)
>         KERNELBASE.dll => /cygdrive/c/WINDOWS/System32/KERNELBASE.dll (0x7ffe839e0000)
>         cygwin1.dll => /usr/bin/cygwin1.dll (0x7ffe416d0000)
>         cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x5461d0000)
>         cygncursesw-10.dll => /usr/bin/cygncursesw-10.dll (0x48ca30000)
> 
> 
> and here is from the installed:
> $ ldd /usr/bin/tig.exe
>         ntdll.dll => /cygdrive/c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffe86590000)
>         KERNEL32.DLL => /cygdrive/c/WINDOWS/System32/KERNEL32.DLL (0x7ffe85160000)
>         KERNELBASE.dll => /cygdrive/c/WINDOWS/System32/KERNELBASE.dll (0x7ffe839e0000)
>         cygwin1.dll => /usr/bin/cygwin1.dll (0x7ffe416d0000)
>         cygncursesw-10.dll => /usr/bin/cygncursesw-10.dll (0x48ca30000)
>         cygiconv-2.dll => /usr/bin/cygiconv-2.dll (0x5461d0000)
>         cygpcre-1.dll => /usr/bin/cygpcre-1.dll (0x3fd630000)
>         cygreadline7.dll => /usr/bin/cygreadline7.dll (0x579cd0000)
>         cygpcreposix-0.dll => /usr/bin/cygpcreposix-0.dll (0x520b40000)

I strongly suspect that, like git, tig will use libpcre if it was
present at compile time, and won't if it isn't.  Typically I'd expect
distribution builds to include libpcre support for this sort of thing.
That would mean Jari's compilation was correct, but the .hint files
didn't correctly list the necessary dependencies.

Jari, your email mentioned a possible new maintainer; are you intending
to hand over responsibility, or do you just mean for a hypothetical
future maintainer at some point in the future?

Re: [ATTN MAINTAINER] tig

[Jon Turney]

On 13/01/2023 16:59, Libor Ukropec via Cygwin-apps wrote:
> Dne 10.01.2023 v 15:04 Jari Aalto via Cygwin-apps napsal(a):
> 
>>
>> Hi, Thanks for the heads up. I've uploaded new version and added the
>> *.cygport in my Github repository of tig for possible new maintainer
>> in the future.
>>
>> The patches deal some fixes in the xmlto(1) of manual pages build.
>>
>> Jari
>>
> Hi Jari,
> 
> I updated to the latest tig, but when executing, it complains about 
> missing dependency, but recently I saw many updates to the cygwin 
> packages. Any idea if other package was broken, or tig is missing some 
> dependency in the metadata?
> 
> C:/cygwin64/bin/tig.exe: error while loading shared libraries: 
> cygpcreposix-0.dll: cannot open shared object file: No such file or 
> directory
> 
> Manual installation of "libpcreposix0 8.45-1" seems resolving the problem.

Libor,


Thanks for reporting this.

I added libpcre1 and libpcreposix0 to the requires: for tig.

Jari,

Please update your local copy, to try to ensure these are correct in any 
future release.

Re: [ATTN MAINTAINER] tig

[Jari Aalto]

On 2023-01-16 12:42, Jon Turney wrote:
> On 13/01/2023 16:59, Libor Ukropec via Cygwin-apps wrote:
> > C:/cygwin64/bin/tig.exe: error while loading shared libraries:
> > cygpcreposix-0.dll: cannot open shared object file: No such file or
> > directory
> >
> > Manual installation of "libpcreposix0 8.45-1" seems resolving the problem.
>
> I added libpcre1 and libpcreposix0 to the requires: for tig.
>
> Jari,
>
> Please update your local copy, to try to ensure these are correct in any
> future release.

Thanks, added.
Jari