public inbox for
help / color / mirror / Atom feed
From: Ken Brown <>
Subject: [newlib-cygwin] Cygwin: dtable::dup_worker: update comment and debug output
Date: Mon,  7 Dec 2020 21:33:43 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=b6624e23e17bdc505f639d9f181225dbf3a50fc6

commit b6624e23e17bdc505f639d9f181225dbf3a50fc6
Author: Ken Brown <>
Date:   Mon Dec 7 16:19:57 2020 -0500

    Cygwin: dtable::dup_worker: update comment and debug output
    The comment and debug output became obsolete in commit 23771fa1f7 when
    dup_worker started calling fhandler_base::clone instead of build_fh_pc
    and fhandler_base::operator=.

 winsup/cygwin/ | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 6a91e33bc..9f4210797 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -679,12 +679,9 @@ out:
 fhandler_base *
 dtable::dup_worker (fhandler_base *oldfh, int flags)
-  /* Don't call set_name in build_fh_pc.  It will be called in
-     fhandler_base::operator= below.  Calling it twice will result
-     in double allocation. */
   fhandler_base *newfh = oldfh->clone ();
   if (!newfh)
-    debug_printf ("build_fh_pc failed");
+    debug_printf ("clone failed");
       if (!oldfh->archetype)

                 reply	other threads:[~2020-12-07 21:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).