public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: dtable::dup_worker: update comment and debug output
@ 2020-12-07 21:33 Ken Brown
  0 siblings, 0 replies; only message in thread
From: Ken Brown @ 2020-12-07 21:33 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b6624e23e17bdc505f639d9f181225dbf3a50fc6

commit b6624e23e17bdc505f639d9f181225dbf3a50fc6
Author: Ken Brown <kbrown@cornell.edu>
Date:   Mon Dec 7 16:19:57 2020 -0500

    Cygwin: dtable::dup_worker: update comment and debug output
    
    The comment and debug output became obsolete in commit 23771fa1f7 when
    dup_worker started calling fhandler_base::clone instead of build_fh_pc
    and fhandler_base::operator=.

Diff:
---
 winsup/cygwin/dtable.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc
index 6a91e33bc..9f4210797 100644
--- a/winsup/cygwin/dtable.cc
+++ b/winsup/cygwin/dtable.cc
@@ -679,12 +679,9 @@ out:
 fhandler_base *
 dtable::dup_worker (fhandler_base *oldfh, int flags)
 {
-  /* Don't call set_name in build_fh_pc.  It will be called in
-     fhandler_base::operator= below.  Calling it twice will result
-     in double allocation. */
   fhandler_base *newfh = oldfh->clone ();
   if (!newfh)
-    debug_printf ("build_fh_pc failed");
+    debug_printf ("clone failed");
   else
     {
       if (!oldfh->archetype)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-07 21:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 21:33 [newlib-cygwin] Cygwin: dtable::dup_worker: update comment and debug output Ken Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).