public inbox for
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: don't copy path_conv in fhandler_base::reset
@ 2021-02-10  9:51 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2021-02-10  9:51 UTC (permalink / raw)
  To: cygwin-cvs;h=c875ed3744968b19f7dd8ed6335710be55617d36

commit c875ed3744968b19f7dd8ed6335710be55617d36
Author: Corinna Vinschen <>
Date:   Wed Feb 10 10:33:36 2021 +0100

    Cygwin: don't copy path_conv in fhandler_base::reset
    There's a slim chance that duplicating fhandlers may end up duplicating
    path_conv_handle handles twice ending up with a handle leak, due to
    fhandler_base::reset calling path_conv::operator<< after the only
    caller, fhandler::copyto, already called path_conv::operator=.
    Just drop the call which basically duplicates what path_conv::operator=
    already did.
    Signed-off-by: Corinna Vinschen <>

 winsup/cygwin/ | 1 -
 1 file changed, 1 deletion(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 5dbbd4068..ee0047ea0 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -43,7 +43,6 @@ LONG NO_COPY fhandler_base_overlapped::asio_close_counter;
 fhandler_base::reset (const fhandler_base *from)
-  pc << from->pc;
   ra.rabuf = NULL;
   ra.ralen = 0;
   ra.raixget = 0;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-10  9:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10  9:51 [newlib-cygwin] Cygwin: don't copy path_conv in fhandler_base::reset Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).