public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: pipes: minor code cleanup Date: Tue, 14 Sep 2021 15:06:34 +0000 (GMT) [thread overview] Message-ID: <20210914150634.88B443858434@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=44693e80b1dd6f97a674ddd383521a21c09c6dad commit 44693e80b1dd6f97a674ddd383521a21c09c6dad Author: Ken Brown <kbrown@cornell.edu> Date: Fri Sep 3 09:42:00 2021 -0400 Cygwin: pipes: minor code cleanup Clarify a comment in raw_read, and remove a useless line from raw_write. Diff: --- winsup/cygwin/fhandler_pipe.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc index 85730d039..81b1aed5e 100644 --- a/winsup/cygwin/fhandler_pipe.cc +++ b/winsup/cygwin/fhandler_pipe.cc @@ -248,8 +248,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len) WaitForSingleObject (read_mtx, INFINITE); - /* Make sure never to request more bytes than half the pipe - buffer size. Every pending read lowers WriteQuotaAvailable + /* If the pipe is empty, don't request more bytes than half the + pipe buffer size. Every pending read lowers WriteQuotaAvailable on the write side and thus affects select's ability to return more or less reliable info whether a write succeeds or not. @@ -425,7 +425,6 @@ fhandler_pipe::raw_write (const void *ptr, size_t len) set_errno (EBADF); else __seterrno (); - len = (size_t) -1; } else if (NT_SUCCESS (status)) {
reply other threads:[~2021-09-14 15:06 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210914150634.88B443858434@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).