public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: pipes: minor code cleanup
@ 2021-09-14 15:06 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2021-09-14 15:06 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=44693e80b1dd6f97a674ddd383521a21c09c6dad
commit 44693e80b1dd6f97a674ddd383521a21c09c6dad
Author: Ken Brown <kbrown@cornell.edu>
Date: Fri Sep 3 09:42:00 2021 -0400
Cygwin: pipes: minor code cleanup
Clarify a comment in raw_read, and remove a useless line from
raw_write.
Diff:
---
winsup/cygwin/fhandler_pipe.cc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 85730d039..81b1aed5e 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -248,8 +248,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len)
WaitForSingleObject (read_mtx, INFINITE);
- /* Make sure never to request more bytes than half the pipe
- buffer size. Every pending read lowers WriteQuotaAvailable
+ /* If the pipe is empty, don't request more bytes than half the
+ pipe buffer size. Every pending read lowers WriteQuotaAvailable
on the write side and thus affects select's ability to return
more or less reliable info whether a write succeeds or not.
@@ -425,7 +425,6 @@ fhandler_pipe::raw_write (const void *ptr, size_t len)
set_errno (EBADF);
else
__seterrno ();
- len = (size_t) -1;
}
else if (NT_SUCCESS (status))
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-14 15:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 15:06 [newlib-cygwin] Cygwin: pipes: minor code cleanup Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).