public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: pipe: Avoid false EOF while reading output of C# programs. Date: Mon, 8 Nov 2021 10:07:15 +0000 (GMT) [thread overview] Message-ID: <20211108100715.7BF183858401@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=365199090c05eb6076d0cfe9104a53177f6fa251 commit 365199090c05eb6076d0cfe9104a53177f6fa251 Author: Takashi Yano <takashi.yano@nifty.ne.jp> Date: Sun Nov 7 12:47:18 2021 +0900 Cygwin: pipe: Avoid false EOF while reading output of C# programs. - If output of C# program is redirected to pipe, pipe reader falsely detects EOF. This happens after overhaul of pipe implementation. This patch fixes the issue. Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html Diff: --- winsup/cygwin/fhandler_pipe.cc | 3 ++- winsup/cygwin/release/3.3.2 | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc index 43771e8f7..bc06d157c 100644 --- a/winsup/cygwin/fhandler_pipe.cc +++ b/winsup/cygwin/fhandler_pipe.cc @@ -393,7 +393,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len) } } - if (nbytes_now == 0 || status == STATUS_BUFFER_OVERFLOW) + if ((nbytes_now == 0 && !NT_SUCCESS (status)) + || status == STATUS_BUFFER_OVERFLOW) break; } ReleaseMutex (read_mtx); diff --git a/winsup/cygwin/release/3.3.2 b/winsup/cygwin/release/3.3.2 index 263c3efe6..2e48e39be 100644 --- a/winsup/cygwin/release/3.3.2 +++ b/winsup/cygwin/release/3.3.2 @@ -8,3 +8,7 @@ Bug Fixes Addresses: https://sourceware.org/pipermail/newlib/2021/018626.html - Fix a permission problem when writing ACLs on Samba. + +- Fix the issue that pipe reader falsely detects EOF if the output of + the C# program is redirected to the pipe. + Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html
reply other threads:[~2021-11-08 10:07 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211108100715.7BF183858401@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).