public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'"
Date: Fri, 28 Oct 2022 10:49:30 +0000 (GMT)	[thread overview]
Message-ID: <20221028104930.43EF5385AC2B@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=213b53ed355712b97d361a273a87f1162b8b7aab

commit 213b53ed355712b97d361a273a87f1162b8b7aab
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Fri Oct 28 12:24:31 2022 +0200

    Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'"
    
    This reverts commit 7589034cc3151bfac8cc3d3af5e91402a78e160b.
    
    The previous commit 14816de9af69 ("Cygwin: spawn: drop special handling
    for cmd.exe and command.com") make this patch unnecessary.  The filename
    argument (i. e., run_path in the caller) is now always non-NULL.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/spawn.cc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index a450ea443..f0ae73999 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -215,8 +215,6 @@ handle (int fd, bool writing)
 static bool
 is_console_app (WCHAR *filename)
 {
-  if (filename == NULL)
-    return true; /* The command executed is command.com or cmd.exe. */
   HANDLE h;
   const int id_offset = 92;
   h = CreateFileW (filename, GENERIC_READ, FILE_SHARE_READ,

                 reply	other threads:[~2022-10-28 10:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028104930.43EF5385AC2B@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).