public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: fs_info::update: fix NTFS filesystem flags Date: Tue, 21 Mar 2023 17:30:29 +0000 (GMT) [thread overview] Message-ID: <20230321173029.31F9E3858D3C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=0a962aa2c293aa69afbb3a52790ff14009921fe0 commit 0a962aa2c293aa69afbb3a52790ff14009921fe0 Author: Corinna Vinschen <corinna@vinschen.de> AuthorDate: Tue Mar 21 18:01:00 2023 +0100 Commit: Corinna Vinschen <corinna@vinschen.de> CommitDate: Tue Mar 21 18:02:49 2023 +0100 Cygwin: fs_info::update: fix NTFS filesystem flags These flags are used to check a remote filesystem. Not all flags supported by a local NTFS are available when checking a remote NTFS. Fix the flag set accordingly, otherwise the remote NTFS will ba handled as CIFS. Fixes: fcccdc4021ff ("Cygwin: fs_info: update filesystem flags and check Windows 7 flags") Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/mount.cc | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/winsup/cygwin/mount.cc b/winsup/cygwin/mount.cc index 627d120059a3..36ab042a723a 100644 --- a/winsup/cygwin/mount.cc +++ b/winsup/cygwin/mount.cc @@ -385,9 +385,10 @@ fs_info::update (PUNICODE_STRING upath, HANDLE in_vol) | FILE_CASE_PRESERVED_NAMES \ | FILE_UNICODE_ON_DISK \ | FILE_NAMED_STREAMS) -/* These are the minimal flags supported by NTFS since Windows 7. Every - filesystem not supporting these flags is not a native NTFS. We subsume - them under the filesystem type "cifs". */ +/* These are the minimal flags supported by NTFS since Windows 7, when + checking a remote NTFS filesystem. Every filesystem not supporting these + flags is not a native NTFS. + We subsume them under the filesystem type "cifs". */ #define MINIMAL_WIN_NTFS_FLAGS (FILE_CASE_SENSITIVE_SEARCH \ | FILE_CASE_PRESERVED_NAMES \ | FILE_UNICODE_ON_DISK \ @@ -399,11 +400,8 @@ fs_info::update (PUNICODE_STRING upath, HANDLE in_vol) | FILE_SUPPORTS_OBJECT_IDS \ | FILE_SUPPORTS_ENCRYPTION \ | FILE_NAMED_STREAMS \ - | FILE_SUPPORTS_TRANSACTIONS \ | FILE_SUPPORTS_HARD_LINKS \ - | FILE_SUPPORTS_EXTENDED_ATTRIBUTES \ - | FILE_SUPPORTS_OPEN_BY_FILE_ID \ - | FILE_SUPPORTS_USN_JOURNAL) + | FILE_SUPPORTS_EXTENDED_ATTRIBUTES) #define FS_IS_WINDOWS_NTFS TEST_GVI(flags () & MINIMAL_WIN_NTFS_FLAGS, \ MINIMAL_WIN_NTFS_FLAGS) /* These are the exact flags of a real Windows FAT/FAT32 filesystem.
reply other threads:[~2023-03-21 17:30 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230321173029.31F9E3858D3C@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).