public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] Cygwin: fs_info::update: fix NTFS filesystem flags
@ 2023-03-21 17:30 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2023-03-21 17:30 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=0a962aa2c293aa69afbb3a52790ff14009921fe0

commit 0a962aa2c293aa69afbb3a52790ff14009921fe0
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Tue Mar 21 18:01:00 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Mar 21 18:02:49 2023 +0100

    Cygwin: fs_info::update: fix NTFS filesystem flags
    
    These flags are used to check a remote filesystem.  Not all
    flags supported by a local NTFS are available when checking
    a remote NTFS.  Fix the flag set accordingly, otherwise
    the remote NTFS will ba handled as CIFS.
    
    Fixes: fcccdc4021ff ("Cygwin: fs_info: update filesystem flags and check Windows 7 flags")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/mount.cc | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/winsup/cygwin/mount.cc b/winsup/cygwin/mount.cc
index 627d120059a3..36ab042a723a 100644
--- a/winsup/cygwin/mount.cc
+++ b/winsup/cygwin/mount.cc
@@ -385,9 +385,10 @@ fs_info::update (PUNICODE_STRING upath, HANDLE in_vol)
 			     | FILE_CASE_PRESERVED_NAMES \
 			     | FILE_UNICODE_ON_DISK \
 			     | FILE_NAMED_STREAMS)
-/* These are the minimal flags supported by NTFS since Windows 7.  Every
-   filesystem not supporting these flags is not a native NTFS.  We subsume
-   them under the filesystem type "cifs". */
+/* These are the minimal flags supported by NTFS since Windows 7, when
+   checking a remote NTFS filesystem.  Every filesystem not supporting these
+   flags is not a native NTFS.
+   We subsume them under the filesystem type "cifs". */
 #define MINIMAL_WIN_NTFS_FLAGS (FILE_CASE_SENSITIVE_SEARCH \
 				| FILE_CASE_PRESERVED_NAMES \
 				| FILE_UNICODE_ON_DISK \
@@ -399,11 +400,8 @@ fs_info::update (PUNICODE_STRING upath, HANDLE in_vol)
 				| FILE_SUPPORTS_OBJECT_IDS \
 				| FILE_SUPPORTS_ENCRYPTION \
 				| FILE_NAMED_STREAMS \
-				| FILE_SUPPORTS_TRANSACTIONS \
 				| FILE_SUPPORTS_HARD_LINKS \
-				| FILE_SUPPORTS_EXTENDED_ATTRIBUTES \
-				| FILE_SUPPORTS_OPEN_BY_FILE_ID \
-				| FILE_SUPPORTS_USN_JOURNAL)
+				| FILE_SUPPORTS_EXTENDED_ATTRIBUTES)
 #define FS_IS_WINDOWS_NTFS TEST_GVI(flags () & MINIMAL_WIN_NTFS_FLAGS, \
 				    MINIMAL_WIN_NTFS_FLAGS)
 /* These are the exact flags of a real Windows FAT/FAT32 filesystem.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-21 17:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 17:30 [newlib-cygwin/main] Cygwin: fs_info::update: fix NTFS filesystem flags Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).