[newlib-cygwin/main] Cygwin: NFS: remove recognizing native symlinks as FIFOs

[newlib-cygwin/main] Cygwin: NFS: remove recognizing native symlinks as FIFOs

[Corinna Vinschen]

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5bbe0e56c617fbdf608d416592b6609af0e73211

commit 5bbe0e56c617fbdf608d416592b6609af0e73211
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Sat Sep 9 23:26:21 2023 +0200
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Sat Sep 9 23:28:55 2023 +0200

    Cygwin: NFS: remove recognizing native symlinks as FIFOs
    
    Given the downsides of NFS symlinks as FIFOs, drop the code
    added to recognize them as such.
    
    Fixes: 622fb0776ea3 ("Cygwin: enable usage of FIFOs on NFS")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/path.cc | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
index 0c9d3921a0ea..1c3583d763a9 100644
--- a/winsup/cygwin/path.cc
+++ b/winsup/cygwin/path.cc
@@ -3532,21 +3532,6 @@ restart:
 	    {
 	    case NF3LNK:
 	      res = check_nfs_symlink (h);
-	      /* Enable Cygwin-created FIFOs to be recognized as FIFOs.
-		 We have to overwrite the NFS fattr3 data, otherwise the
-		 info returned by Cygwin's stat will still claim the file
-		 is a symlink. */
-	      if (res && contents[0] == ':' && contents[1] == '\\'
-		  && parse_device (contents) && major == _major (FH_FIFO))
-		{
-		  conv_hdl.nfsattr ()->type = NF3FIFO;
-		  conv_hdl.nfsattr ()->mode = mode;
-		  conv_hdl.nfsattr ()->size = 0;
-		  /* Marker for fhandler_base::fstat_by_nfs_ea not to override
-		     the cached fattr3 data with fresh data from the filesystem,
-		     even if the handle is used for other purposes than stat. */
-		  conv_hdl.nfsattr ()->filler1 = NF3FIFO;
-		}
 	      break;
 	    case NF3FIFO:
 	      /* Enable real FIFOs recognized as such. */