public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: seekdir: don't set errno
Date: Tue, 23 Jan 2024 08:51:01 +0000 (GMT)	[thread overview]
Message-ID: <20240123085102.311E63858427@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=02572ff089dcefed1e2e25f420be975f1ee7340c

commit 02572ff089dcefed1e2e25f420be975f1ee7340c
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Mon Jan 22 19:59:09 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Jan 23 09:49:02 2024 +0100

    Cygwin: seekdir: don't set errno
    
    Commit 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks [...]")
    introduced setting EINVAL, marked as "Diagnosis".  The reason
    for this is lost in time and space, but looks very much like
    a debug helper which was supposed to be removed before release.
    It's rather pointless, so remove it.
    
    Fixes: 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks [...]")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/dir.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
index a181ce58c7ec..d67ac02d9159 100644
--- a/winsup/cygwin/dir.cc
+++ b/winsup/cygwin/dir.cc
@@ -235,7 +235,6 @@ seekdir (DIR *dir, long loc)
 	  dir->__flags &= dirent_info_mask;
 	  ((fhandler_base *) dir->__fh)->seekdir (dir, loc);
 	}
-      set_errno (EINVAL);	/* Diagnosis */
     }
   __except (EFAULT) {}
   __endtry

                 reply	other threads:[~2024-01-23  8:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123085102.311E63858427@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).