public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] Cygwin: seekdir: don't set errno
@ 2024-01-23 8:51 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2024-01-23 8:51 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=02572ff089dcefed1e2e25f420be975f1ee7340c
commit 02572ff089dcefed1e2e25f420be975f1ee7340c
Author: Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Mon Jan 22 19:59:09 2024 +0100
Commit: Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Jan 23 09:49:02 2024 +0100
Cygwin: seekdir: don't set errno
Commit 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks [...]")
introduced setting EINVAL, marked as "Diagnosis". The reason
for this is lost in time and space, but looks very much like
a debug helper which was supposed to be removed before release.
It's rather pointless, so remove it.
Fixes: 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks [...]")
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/dir.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
index a181ce58c7ec..d67ac02d9159 100644
--- a/winsup/cygwin/dir.cc
+++ b/winsup/cygwin/dir.cc
@@ -235,7 +235,6 @@ seekdir (DIR *dir, long loc)
dir->__flags &= dirent_info_mask;
((fhandler_base *) dir->__fh)->seekdir (dir, loc);
}
- set_errno (EINVAL); /* Diagnosis */
}
__except (EFAULT) {}
__endtry
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-23 8:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-23 8:51 [newlib-cygwin/main] Cygwin: seekdir: don't set errno Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).