From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: tty.cc and fhandler/tty.cc
Date: Thu, 24 Nov 2022 11:18:27 +0100 [thread overview]
Message-ID: <Y39E827dT9E2QOF8@calimero.vinschen.de> (raw)
In-Reply-To: <20221124172402.214c49a8aa0a65fd411b7497@nifty.ne.jp>
On Nov 24 17:24, Takashi Yano wrote:
> On Wed, 23 Nov 2022 10:08:11 +0100
> Corinna Vinschen wrote:
> > On Nov 23 07:46, Takashi Yano wrote:
> > > Well, I meant
> > > winsup/cygwin/tty.cc
> > > and
> > > winsup/cygwin/fhandler/pty.cc
> > > .
> >
> > Oh, right! Yeah, that makes perfect sense!
>
> Then, which is better solution?
>
> On Tue, 22 Nov 2022 10:36:28 +0100
> Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
> > Maybe we could split it up. The extern functions could go into
> > syscalls.cc and the tty classes could go into fhandler/termios.cc,
> > perhaps. There are already two tty_min methods in that file.
>
> or renaming fhandler/tty.cc?
Renaming fhandler/tty.cc to fhandler/pty.cc is the better solution,
I think.
Corinna
next prev parent reply other threads:[~2022-11-24 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 8:31 Takashi Yano
2022-11-22 9:36 ` Corinna Vinschen
2022-11-22 9:50 ` Corinna Vinschen
2022-11-22 22:46 ` Takashi Yano
2022-11-23 9:08 ` Corinna Vinschen
2022-11-24 8:24 ` Takashi Yano
2022-11-24 10:18 ` Corinna Vinschen [this message]
2022-11-24 10:56 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y39E827dT9E2QOF8@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).