From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: tty.cc and fhandler/tty.cc
Date: Tue, 22 Nov 2022 10:50:46 +0100 [thread overview]
Message-ID: <Y3ybdj5mpZ8tRma6@calimero.vinschen.de> (raw)
In-Reply-To: <Y3yYHPmQhWCjHpl3@calimero.vinschen.de>
On Nov 22 10:36, Corinna Vinschen wrote:
> On Nov 22 17:31, Takashi Yano wrote:
> > Current cygwin git master has two tty.cc, one is winsup/cygwin/tty.cc
> > and the other is winsup/cygwin/fhandler/tty.cc (it was originally
> > fhandler_tty.cc). This is somewhat confusing.
> >
> > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class,
> > so, what about renaming fhandler/tty.cc to fhandler/pty.cc?
>
> Maybe we could split it up. The extern functions could go into
> syscalls.cc and the tty classes could go into fhandler/termios.cc,
> perhaps. There are already two tty_min methods in that file.
If we don't split, maybe something like tty_helper.cc would be more
feasible? tty.cc mainly implements the tty/tty_min classes and at least
the latter is used for consoles, too. Pty.cc might be a bit misleading
Corinna
next prev parent reply other threads:[~2022-11-22 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 8:31 Takashi Yano
2022-11-22 9:36 ` Corinna Vinschen
2022-11-22 9:50 ` Corinna Vinschen [this message]
2022-11-22 22:46 ` Takashi Yano
2022-11-23 9:08 ` Corinna Vinschen
2022-11-24 8:24 ` Takashi Yano
2022-11-24 10:18 ` Corinna Vinschen
2022-11-24 10:56 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3ybdj5mpZ8tRma6@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).