* [PATCH v2 1/4] Cygwin: pty: Inherit typeahead data between two input pipes.
2021-01-21 20:58 [PATCH v2 0/4] Improve pseudo console support Takashi Yano
@ 2021-01-21 20:58 ` Takashi Yano
2021-01-21 20:58 ` [PATCH v2 2/4] Cygwin: pty: Keep code page between non-cygwin apps Takashi Yano
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Takashi Yano @ 2021-01-21 20:58 UTC (permalink / raw)
To: cygwin-patches
- PTY has a problem that the key input, which is typed during windows
native app is running, disappears when it returns to shell. This is
beacuse pty has two input pipes, one is for cygwin apps and the other
one is for native windows apps. The key input during windows native
program is running is sent to the second input pipe while cygwin
shell reads input from the first input pipe. This issue had been
fixed once by commit 29431fcb, however, the new implementation of
pseudo console support by commit bb428520 could not inherit this
feature. This patch realize transfering input data between these
two pipes bidirectionally by utilizing cygwin-console-helper process.
The helper process is launched prior to starting the non-cygwin app,
however, exits immediately unlike previous implementation.
---
winsup/cygwin/fhandler.h | 12 +-
winsup/cygwin/fhandler_tty.cc | 468 ++++++++++++++++++++++++++--------
winsup/cygwin/spawn.cc | 78 +++---
winsup/cygwin/tty.cc | 2 -
winsup/cygwin/tty.h | 8 +-
5 files changed, 422 insertions(+), 146 deletions(-)
diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h
index af1ef3a45..10c5973dd 100644
--- a/winsup/cygwin/fhandler.h
+++ b/winsup/cygwin/fhandler.h
@@ -2291,6 +2291,13 @@ class fhandler_pty_slave: public fhandler_pty_common
void fch_close_handles ();
public:
+ /* Transfer direction for transfer_input() */
+ enum xfer_dir
+ {
+ to_nat,
+ to_cyg
+ };
+
/* Constructor */
fhandler_pty_slave (int);
@@ -2340,7 +2347,7 @@ class fhandler_pty_slave: public fhandler_pty_common
copyto (fh);
return fh;
}
- bool setup_pseudoconsole (STARTUPINFOEXW *si, bool nopcon);
+ bool setup_pseudoconsole (bool nopcon);
static void close_pseudoconsole (tty *ttyp);
bool term_has_pcon_cap (const WCHAR *env);
void set_switch_to_pcon (void);
@@ -2349,6 +2356,9 @@ class fhandler_pty_slave: public fhandler_pty_common
void setup_locale (void);
tty *get_ttyp () { return (tty *) tc (); } /* Override as public */
void create_invisible_console (void);
+ static void transfer_input (xfer_dir dir, HANDLE from, tty *ttyp,
+ HANDLE input_available_event);
+ HANDLE get_input_available_event (void) { return input_available_event; }
};
#define __ptsname(buf, unit) __small_sprintf ((buf), "/dev/pty%d", (unit))
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 7f0752614..75ab500b1 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1591,7 +1591,7 @@ fhandler_pty_common::resize_pseudo_console (struct winsize *ws)
size.X = ws->ws_col;
size.Y = ws->ws_row;
pinfo p (get_ttyp ()->pcon_pid);
- if (p && !get_ttyp ()->do_not_resize_pcon)
+ if (p)
{
HPCON_INTERNAL hpcon_local;
HANDLE pcon_owner =
@@ -1763,6 +1763,17 @@ fhandler_pty_master::write (const void *ptr, size_t len)
get_ttyp ()->pcon_start = false;
}
ReleaseMutex (input_mutex);
+ if (get_ttyp ()->switch_to_pcon_in)
+ {
+ fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_nat,
+ from_master_cyg,
+ get_ttyp (),
+ input_available_event);
+ /* This accept_input() call is needed in order to transfer input
+ which is not accepted yet to non-cygwin pipe. */
+ if (get_readahead_valid ())
+ accept_input ();
+ }
return len;
}
@@ -2130,22 +2141,44 @@ fhandler_pty_master::pty_master_fwd_thread (const master_fwd_thread_param_t *p)
char *ptr = outbuf;
if (p->ttyp->h_pseudo_console)
{
- if (!p->ttyp->has_set_title)
- {
- /* Remove Set title sequence */
- char *p0, *p1;
- p0 = outbuf;
- while ((p0 = (char *) memmem (p0, rlen, "\033]0;", 4))
- && (p1 = (char *) memchr (p0, '\007', rlen-(p0-outbuf))))
- {
- memmove (p0, p1 + 1, rlen - (p1 + 1 - outbuf));
- rlen -= p1 + 1 - p0;
- wlen = rlen;
- }
- }
- /* Remove CSI > Pm m */
+ /* Avoid setting window title to "cygwin-console-helper.exe" */
int state = 0;
int start_at = 0;
+ for (DWORD i=0; i<rlen; i++)
+ if (outbuf[i] == '\033')
+ {
+ start_at = i;
+ state = 1;
+ continue;
+ }
+ else if ((state == 1 && outbuf[i] == ']') ||
+ (state == 2 && outbuf[i] == '0') ||
+ (state == 3 && outbuf[i] == ';'))
+ {
+ state ++;
+ continue;
+ }
+ else if (state == 4 && outbuf[i] == '\a')
+ {
+ const char *helper_str = "\\bin\\cygwin-console-helper.exe";
+ if (memmem (&outbuf[start_at], i + 1 - start_at,
+ helper_str, strlen (helper_str)))
+ {
+ memmove (&outbuf[start_at], &outbuf[i+1], rlen-i-1);
+ rlen = wlen = start_at + rlen - i - 1;
+ }
+ state = 0;
+ continue;
+ }
+ else if (outbuf[i] == '\a')
+ {
+ state = 0;
+ continue;
+ }
+
+ /* Remove CSI > Pm m */
+ state = 0;
+ start_at = 0;
for (DWORD i = 0; i < rlen; i++)
if (outbuf[i] == '\033')
{
@@ -2419,6 +2452,8 @@ fhandler_pty_master::setup ()
t.set_from_master_cyg (from_master_cyg);
t.set_to_master (to_master);
t.set_to_master_cyg (to_master_cyg);
+ t.set_to_slave (to_slave);
+ t.set_to_slave_cyg (get_output_handle ());
t.winsize.ws_col = 80;
t.winsize.ws_row = 25;
t.master_pid = myself->pid;
@@ -2579,10 +2614,15 @@ fhandler_pty_common::process_opost_output (HANDLE h, const void *ptr,
return res;
}
+ /* Pseudo console supprot is realized using a tricky technic.
+ PTY need the pseudo console handles, however, they cannot
+ be retrieved by normal procedure. Therefore, run a helper
+ process in a pseudo console and get them from the helper.
+ Slave process will attach to the pseudo console in the
+ helper process using AttachConsole(). */
bool
-fhandler_pty_slave::setup_pseudoconsole (STARTUPINFOEXW *si, bool nopcon)
+fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
{
-
/* Setting switch_to_pcon_in is necessary even if
pseudo console will not be activated. */
fhandler_base *fh = ::cygheap->fdtab[0];
@@ -2613,60 +2653,151 @@ fhandler_pty_slave::setup_pseudoconsole (STARTUPINFOEXW *si, bool nopcon)
return false;
}
- COORD size = {
- (SHORT) get_ttyp ()->winsize.ws_col,
- (SHORT) get_ttyp ()->winsize.ws_row
- };
- const DWORD inherit_cursor = 1;
- SetLastError (ERROR_SUCCESS);
- HRESULT res = CreatePseudoConsole (size, get_handle (), get_output_handle (),
- inherit_cursor,
- &get_ttyp ()->h_pseudo_console);
- if (res != S_OK || GetLastError () == ERROR_PROC_NOT_FOUND)
- {
- if (res != S_OK)
- system_printf ("CreatePseudoConsole() failed. %08x %08x\n",
- GetLastError (), res);
- goto fallback;
- }
-
- SIZE_T bytesRequired;
- InitializeProcThreadAttributeList (NULL, 1, 0, &bytesRequired);
- ZeroMemory (si, sizeof (*si));
- si->StartupInfo.cb = sizeof (STARTUPINFOEXW);
- si->lpAttributeList = (PPROC_THREAD_ATTRIBUTE_LIST)
- HeapAlloc (GetProcessHeap (), 0, bytesRequired);
- if (si->lpAttributeList == NULL)
- goto cleanup_pseudo_console;
- if (!InitializeProcThreadAttributeList (si->lpAttributeList,
- 1, 0, &bytesRequired))
- goto cleanup_heap;
- if (!UpdateProcThreadAttribute (si->lpAttributeList,
- 0,
- PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE,
- get_ttyp ()->h_pseudo_console,
- sizeof (get_ttyp ()->h_pseudo_console),
- NULL, NULL))
- goto cleanup_heap;
- si->StartupInfo.dwFlags = STARTF_USESTDHANDLES;
- si->StartupInfo.hStdInput = NULL;
- si->StartupInfo.hStdOutput = NULL;
- si->StartupInfo.hStdError = NULL;
+ STARTUPINFOEXW si;
+ PROCESS_INFORMATION pi;
+ HANDLE hello, goodbye;
+ HANDLE hr, hw;
+ HANDLE hpConIn, hpConOut;
- {
- fhandler_base *fh0 = ::cygheap->fdtab[0];
- if (fh0 && fh0->get_device () != get_device ())
- si->StartupInfo.hStdInput = fh0->get_handle ();
- fhandler_base *fh1 = ::cygheap->fdtab[1];
- if (fh1 && fh1->get_device () != get_device ())
- {
- get_ttyp ()->do_not_resize_pcon = true;
- si->StartupInfo.hStdOutput = fh1->get_output_handle ();
- }
- fhandler_base *fh2 = ::cygheap->fdtab[2];
- if (fh2 && fh2->get_device () != get_device ())
- si->StartupInfo.hStdError = fh2->get_output_handle ();
- }
+ do
+ {
+ COORD size = {
+ (SHORT) get_ttyp ()->winsize.ws_col,
+ (SHORT) get_ttyp ()->winsize.ws_row
+ };
+ const DWORD inherit_cursor = 1;
+ SetLastError (ERROR_SUCCESS);
+ HRESULT res = CreatePseudoConsole (size, get_handle (),
+ get_output_handle (),
+ inherit_cursor,
+ &get_ttyp ()->h_pseudo_console);
+ if (res != S_OK || GetLastError () == ERROR_PROC_NOT_FOUND)
+ {
+ if (res != S_OK)
+ system_printf ("CreatePseudoConsole() failed. %08x %08x\n",
+ GetLastError (), res);
+ goto fallback;
+ }
+
+ SIZE_T bytesRequired;
+ InitializeProcThreadAttributeList (NULL, 2, 0, &bytesRequired);
+ ZeroMemory (&si, sizeof (si));
+ si.StartupInfo.cb = sizeof (STARTUPINFOEXW);
+ si.lpAttributeList = (PPROC_THREAD_ATTRIBUTE_LIST)
+ HeapAlloc (GetProcessHeap (), 0, bytesRequired);
+ if (si.lpAttributeList == NULL)
+ goto cleanup_pseudo_console;
+ if (!InitializeProcThreadAttributeList (si.lpAttributeList,
+ 2, 0, &bytesRequired))
+ goto cleanup_heap;
+ if (!UpdateProcThreadAttribute (si.lpAttributeList,
+ 0,
+ PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE,
+ get_ttyp ()->h_pseudo_console,
+ sizeof (get_ttyp ()->h_pseudo_console),
+ NULL, NULL))
+
+ goto cleanup_heap;
+
+ hello = CreateEvent (&sec_none, true, false, NULL);
+ goodbye = CreateEvent (&sec_none, true, false, NULL);
+ CreatePipe (&hr, &hw, &sec_none, 0);
+
+ HANDLE handles_to_inherit[] = {hello, goodbye, hw};
+ if (!UpdateProcThreadAttribute (si.lpAttributeList,
+ 0,
+ PROC_THREAD_ATTRIBUTE_HANDLE_LIST,
+ handles_to_inherit,
+ sizeof (handles_to_inherit),
+ NULL, NULL))
+ goto cleanup_event_and_pipes;
+
+ /* Execute helper process */
+ WCHAR cmd[MAX_PATH];
+ path_conv helper ("/bin/cygwin-console-helper.exe");
+ size_t len = helper.get_wide_win32_path_len ();
+ helper.get_wide_win32_path (cmd);
+ __small_swprintf (cmd + len, L" %p %p %p", hello, goodbye, hw);
+ si.StartupInfo.dwFlags = STARTF_USESTDHANDLES;
+ si.StartupInfo.hStdInput = NULL;
+ si.StartupInfo.hStdOutput = NULL;
+ si.StartupInfo.hStdError = NULL;
+
+ get_ttyp ()->pcon_start = true;
+ if (!CreateProcessW (NULL, cmd, &sec_none, &sec_none,
+ TRUE, EXTENDED_STARTUPINFO_PRESENT,
+ NULL, NULL, &si.StartupInfo, &pi))
+ goto cleanup_event_and_pipes;
+
+ for (;;)
+ {
+ DWORD wait_result = WaitForSingleObject (hello, 500);
+ if (wait_result == WAIT_OBJECT_0)
+ break;
+ if (wait_result != WAIT_TIMEOUT)
+ goto cleanup_helper_process;
+ DWORD exit_code;
+ if (!GetExitCodeProcess (pi.hProcess, &exit_code))
+ goto cleanup_helper_process;
+ if (exit_code == STILL_ACTIVE)
+ continue;
+ if (exit_code != 0 ||
+ WaitForSingleObject (hello, 500) != WAIT_OBJECT_0)
+ goto cleanup_helper_process;
+ break;
+ }
+ CloseHandle (hello);
+ CloseHandle (pi.hThread);
+
+ /* Duplicate pseudo console handles */
+ DWORD rlen;
+ char buf[64];
+ if (!ReadFile (hr, buf, sizeof (buf), &rlen, NULL))
+ goto cleanup_helper_process;
+ buf[rlen] = '\0';
+ sscanf (buf, "StdHandles=%p,%p", &hpConIn, &hpConOut);
+ if (!DuplicateHandle (pi.hProcess, hpConIn,
+ GetCurrentProcess (), &hpConIn, 0,
+ TRUE, DUPLICATE_SAME_ACCESS))
+ goto cleanup_helper_process;
+ if (!DuplicateHandle (pi.hProcess, hpConOut,
+ GetCurrentProcess (), &hpConOut, 0,
+ TRUE, DUPLICATE_SAME_ACCESS))
+ goto cleanup_pcon_in;
+
+ CloseHandle (hr);
+ CloseHandle (hw);
+ DeleteProcThreadAttributeList (si.lpAttributeList);
+ HeapFree (GetProcessHeap (), 0, si.lpAttributeList);
+
+ /* Attach to pseudo console */
+ FreeConsole ();
+ AttachConsole (pi.dwProcessId);
+
+ /* Terminate helper process */
+ SetEvent (goodbye);
+ WaitForSingleObject (pi.hProcess, INFINITE);
+ CloseHandle (goodbye);
+ CloseHandle (pi.hProcess);
+
+ /* Set handle */
+ HANDLE orig_input_handle = get_handle ();
+ HANDLE orig_output_handle = get_output_handle ();
+ cygheap_fdenum cfd (false);
+ while (cfd.next () >= 0)
+ if (cfd->get_device () == get_device ())
+ {
+ fhandler_base *fh = cfd;
+ fhandler_pty_slave *ptys = (fhandler_pty_slave *) fh;
+ if (ptys->get_handle () == orig_input_handle)
+ ptys->set_handle (hpConIn);
+ if (ptys->get_output_handle () == orig_output_handle)
+ ptys->set_output_handle (hpConOut);
+ }
+ CloseHandle (orig_input_handle);
+ CloseHandle (orig_output_handle);
+ }
+ while (false);
if (get_ttyp ()->pcon_pid == 0 || !pinfo (get_ttyp ()->pcon_pid))
get_ttyp ()->pcon_pid = myself->pid;
@@ -2676,11 +2807,23 @@ fhandler_pty_slave::setup_pseudoconsole (STARTUPINFOEXW *si, bool nopcon)
HPCON_INTERNAL *hp = (HPCON_INTERNAL *) get_ttyp ()->h_pseudo_console;
get_ttyp ()->h_pcon_write_pipe = hp->hWritePipe;
}
- get_ttyp ()->pcon_start = true;
return true;
+cleanup_pcon_in:
+ CloseHandle (hpConIn);
+cleanup_helper_process:
+ SetEvent (goodbye);
+ WaitForSingleObject (pi.hProcess, INFINITE);
+ CloseHandle (pi.hProcess);
+ goto skip_close_hello;
+cleanup_event_and_pipes:
+ CloseHandle (hello);
+skip_close_hello:
+ CloseHandle (goodbye);
+ CloseHandle (hr);
+ CloseHandle (hw);
cleanup_heap:
- HeapFree (GetProcessHeap (), 0, si->lpAttributeList);
+ HeapFree (GetProcessHeap (), 0, si.lpAttributeList);
cleanup_pseudo_console:
if (get_ttyp ()->h_pseudo_console)
{
@@ -2690,6 +2833,7 @@ cleanup_pseudo_console:
CloseHandle (tmp);
}
fallback:
+ get_ttyp ()->pcon_start = false;
get_ttyp ()->h_pseudo_console = NULL;
return false;
}
@@ -2702,6 +2846,8 @@ fhandler_pty_slave::close_pseudoconsole (tty *ttyp)
if (ttyp->h_pseudo_console)
{
ttyp->wait_pcon_fwd ();
+ FreeConsole ();
+ AttachConsole (ATTACH_PARENT_PROCESS);
HPCON_INTERNAL *hp = (HPCON_INTERNAL *) ttyp->h_pseudo_console;
HANDLE tmp = hp->hConHostProcess;
ClosePseudoConsole (ttyp->h_pseudo_console);
@@ -2710,7 +2856,6 @@ fhandler_pty_slave::close_pseudoconsole (tty *ttyp)
ttyp->switch_to_pcon_in = false;
ttyp->pcon_pid = 0;
ttyp->pcon_start = false;
- ttyp->do_not_resize_pcon = false;
}
}
@@ -2793,7 +2938,6 @@ fhandler_pty_slave::term_has_pcon_cap (const WCHAR *env)
char buf[1024];
char *p;
int len;
- int x1, y1, x2, y2;
int wait_cnt = 0;
/* Check if terminal has ANSI escape sequence. */
@@ -2820,8 +2964,9 @@ fhandler_pty_slave::term_has_pcon_cap (const WCHAR *env)
len -= n;
*p = '\0';
char *p1 = strrchr (buf, '\033');
+ int x, y;
char c;
- if (p1 == NULL || sscanf (p1, "\033[%d;%d%c", &y1, &x1, &c) != 3
+ if (p1 == NULL || sscanf (p1, "\033[%d;%d%c", &y, &x, &c) != 3
|| c != 'R')
continue;
wait_cnt = 0;
@@ -2833,48 +2978,13 @@ fhandler_pty_slave::term_has_pcon_cap (const WCHAR *env)
Sleep (1);
}
while (len);
+ get_ttyp ()->h_pseudo_console = NULL;
if (len == 0)
goto not_has_csi6n;
get_ttyp ()->has_csi6n = true;
get_ttyp ()->pcon_cap_checked = true;
- /* Check if terminal has set-title capability */
- WaitForSingleObject (input_mutex, INFINITE);
- /* Set pcon_start again because it should be cleared
- in master write(). */
- get_ttyp ()->pcon_start = true;
- WriteFile (get_output_handle_cyg (), "\033]0;\033\\\033[6n", 10, &n, NULL);
- ReleaseMutex (input_mutex);
- p = buf;
- len = sizeof (buf) - 1;
- do
- {
- ReadFile (get_handle (), p, len, &n, NULL);
- p += n;
- len -= n;
- *p = '\0';
- char *p2 = strrchr (buf, '\033');
- char c;
- if (p2 == NULL || sscanf (p2, "\033[%d;%d%c", &y2, &x2, &c) != 3
- || c != 'R')
- continue;
- break;
- }
- while (len);
- get_ttyp ()->h_pseudo_console = NULL;
-
- if (len == 0)
- return true;
-
- if (x2 == x1 && y2 == y1)
- /* If "\033]0;\033\\" does not move cursor position,
- set-title is supposed to be supported. */
- get_ttyp ()->has_set_title = true;
- else
- /* Try to erase garbage string caused by "\033]0;\033\\" */
- for (int i=0; i<x2-x1; i++)
- WriteFile (get_output_handle_cyg (), "\b \b", 3, &n, NULL);
return true;
not_has_csi6n:
@@ -2928,3 +3038,139 @@ fhandler_pty_master::get_master_fwd_thread_param (master_fwd_thread_param_t *p)
p->ttyp = get_ttyp ();
SetEvent (thread_param_copied_event);
}
+
+#define ALT_PRESSED (LEFT_ALT_PRESSED | RIGHT_ALT_PRESSED)
+#define CTRL_PRESSED (LEFT_CTRL_PRESSED | RIGHT_CTRL_PRESSED)
+void
+fhandler_pty_slave::transfer_input (xfer_dir dir, HANDLE from, tty *ttyp,
+ HANDLE input_available_event)
+{
+ HANDLE to;
+ if (dir == to_nat)
+ to = ttyp->to_slave ();
+ else
+ to = ttyp->to_slave_cyg ();
+
+ pinfo p (ttyp->master_pid);
+ HANDLE pty_owner = OpenProcess (PROCESS_DUP_HANDLE, FALSE, p->dwProcessId);
+ DuplicateHandle (pty_owner, to, GetCurrentProcess (), &to,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+
+ UINT cp_from = 0, cp_to = 0;
+
+ if (dir == to_nat)
+ {
+ cp_from = ttyp->term_code_page;
+ if (ttyp->h_pseudo_console)
+ cp_to = CP_UTF8;
+ else
+ cp_to = GetConsoleCP ();
+ }
+ else
+ {
+ cp_from = GetConsoleCP ();
+ cp_to = ttyp->term_code_page;
+ }
+
+ tmp_pathbuf tp;
+ char *buf = tp.c_get ();
+
+ bool transfered = false;
+
+ if (dir == to_cyg && ttyp->h_pseudo_console)
+ { /* from handle is console handle */
+ INPUT_RECORD r[INREC_SIZE];
+ DWORD n;
+ while (PeekConsoleInputA (from, r, INREC_SIZE, &n) && n)
+ {
+ ReadConsoleInputA (from, r, n, &n);
+ int len = 0;
+ char *ptr = buf;
+ for (DWORD i = 0; i < n; i++)
+ if (r[i].EventType == KEY_EVENT && r[i].Event.KeyEvent.bKeyDown)
+ {
+ DWORD ctrl_key_state = r[i].Event.KeyEvent.dwControlKeyState;
+ if (r[i].Event.KeyEvent.uChar.AsciiChar)
+ {
+ if ((ctrl_key_state & ALT_PRESSED)
+ && r[i].Event.KeyEvent.uChar.AsciiChar <= 0x7f)
+ buf[len++] = '\033'; /* Meta */
+ buf[len++] = r[i].Event.KeyEvent.uChar.AsciiChar;
+ }
+ /* Allow Ctrl-Space to emit ^@ */
+ else if (r[i].Event.KeyEvent.wVirtualKeyCode == '2'
+ && (ctrl_key_state & CTRL_PRESSED)
+ && !(ctrl_key_state & ALT_PRESSED))
+ buf[len++] = '\0';
+ else
+ { /* arrow/function keys */
+ /* FIXME: The current code generates cygwin terminal
+ sequence rather than xterm sequence. */
+ char tmp[16];
+ const char *add =
+ fhandler_console::get_nonascii_key (r[i], tmp);
+ if (add)
+ {
+ strcpy (buf + len, add);
+ len += strlen (add);
+ }
+ }
+ }
+ if (cp_to != cp_from)
+ {
+ static mbstate_t mbp;
+ char *mbbuf = tp.c_get ();
+ size_t nlen = NT_MAX_PATH;
+ convert_mb_str (cp_to, mbbuf, &nlen, cp_from, buf, len, &mbp);
+ ptr = mbbuf;
+ len = nlen;
+ }
+ /* Call WriteFile() line by line */
+ char *p0 = ptr;
+ char *p1 = ptr;
+ while ((p1 = (char *) memchr (p0, '\r', len - (p0 - ptr))))
+ {
+ *p1 = '\n';
+ n = p1 - p0 + 1;
+ if (n && WriteFile (to, p0, n, &n, NULL) && n)
+ transfered = true;
+ p0 = p1 + 1;
+ }
+ n = len - (p0 - ptr);
+ if (n && WriteFile (to, p0, n, &n, NULL) && n)
+ transfered = true;
+ }
+ }
+ else
+ {
+ DWORD bytes_in_pipe;
+ while (::bytes_available (bytes_in_pipe, from) && bytes_in_pipe)
+ {
+ DWORD n;
+ ReadFile (from, buf, NT_MAX_PATH, &n, NULL);
+ char *ptr = buf;
+ if (dir == to_nat && ttyp->h_pseudo_console)
+ {
+ char *p = buf;
+ while ((p = (char *) memchr (p, '\n', n - (p - buf))))
+ *p = '\r';
+ }
+ if (cp_to != cp_from)
+ {
+ static mbstate_t mbp;
+ char *mbbuf = tp.c_get ();
+ size_t nlen = NT_MAX_PATH;
+ convert_mb_str (cp_to, mbbuf, &nlen, cp_from, buf, n, &mbp);
+ ptr = mbbuf;
+ n = nlen;
+ }
+ if (n && WriteFile (to, ptr, n, &n, NULL) && n)
+ transfered = true;;
+ }
+ }
+
+ if (dir == to_nat)
+ ResetEvent (input_available_event);
+ else if (transfered)
+ SetEvent (input_available_event);
+}
diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index d03492ee6..d12e52e4f 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -653,6 +653,34 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
}
}
+ bool enable_pcon = false;
+ HANDLE ptys_from_master = NULL;
+ HANDLE ptys_input_available_event = NULL;
+ tty *ptys_ttyp = NULL;
+ if (!iscygwin () && ptys_primary && is_console_app (runpath))
+ {
+ bool nopcon = mode != _P_OVERLAY && mode != _P_WAIT;
+ if (disable_pcon || !ptys_primary->term_has_pcon_cap (envblock))
+ nopcon = true;
+ if (ptys_primary->setup_pseudoconsole (nopcon))
+ enable_pcon = true;
+ ptys_ttyp = ptys_primary->get_ttyp ();
+ ptys_from_master = ptys_primary->get_handle ();
+ DuplicateHandle (GetCurrentProcess (), ptys_from_master,
+ GetCurrentProcess (), &ptys_from_master,
+ 0, 0, DUPLICATE_SAME_ACCESS);
+ ptys_input_available_event =
+ ptys_primary->get_input_available_event ();
+ DuplicateHandle (GetCurrentProcess (), ptys_input_available_event,
+ GetCurrentProcess (), &ptys_input_available_event,
+ 0, 0, DUPLICATE_SAME_ACCESS);
+ if (!enable_pcon)
+ fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_nat,
+ ptys_primary->get_handle_cyg (),
+ ptys_ttyp,
+ ptys_input_available_event);
+ }
+
/* Set up needed handles for stdio */
si.dwFlags = STARTF_USESTDHANDLES;
si.hStdInput = handle ((in__stdin < 0 ? 0 : in__stdin), false);
@@ -664,25 +692,6 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
if (!iscygwin ())
init_console_handler (myself->ctty > 0);
- bool enable_pcon = false;
- tty *ptys_ttyp = NULL;
- STARTUPINFOEXW si_pcon;
- ZeroMemory (&si_pcon, sizeof (si_pcon));
- STARTUPINFOW *si_tmp = &si;
- if (!iscygwin () && ptys_primary && is_console_app (runpath))
- {
- bool nopcon = mode != _P_OVERLAY && mode != _P_WAIT;
- if (disable_pcon || !ptys_primary->term_has_pcon_cap (envblock))
- nopcon = true;
- if (ptys_primary->setup_pseudoconsole (&si_pcon, nopcon))
- {
- c_flags |= EXTENDED_STARTUPINFO_PRESENT;
- si_tmp = &si_pcon.StartupInfo;
- enable_pcon = true;
- ptys_ttyp = ptys_primary->get_ttyp ();
- }
- }
-
loop:
/* When ruid != euid we create the new process under the current original
account and impersonate in child, this way maintaining the different
@@ -711,7 +720,7 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
c_flags,
envblock, /* environment */
NULL,
- si_tmp,
+ &si,
&pi);
}
else
@@ -765,7 +774,7 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
c_flags,
envblock, /* environment */
NULL,
- si_tmp,
+ &si,
&pi);
if (hwst)
{
@@ -778,11 +787,6 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
CloseDesktop (hdsk);
}
}
- if (enable_pcon)
- {
- DeleteProcThreadAttributeList (si_pcon.lpAttributeList);
- HeapFree (GetProcessHeap (), 0, si_pcon.lpAttributeList);
- }
if (mode != _P_OVERLAY)
SetHandleInformation (my_wr_proc_pipe, HANDLE_FLAG_INHERIT,
@@ -954,14 +958,20 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
}
if (sem)
__posix_spawn_sem_release (sem, 0);
- if (enable_pcon)
+ if (enable_pcon || ptys_ttyp || cons_native)
+ WaitForSingleObject (pi.hProcess, INFINITE);
+ if (ptys_ttyp)
{
- WaitForSingleObject (pi.hProcess, INFINITE);
- fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
+ fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
+ ptys_from_master, ptys_ttyp,
+ ptys_input_available_event);
+ CloseHandle (ptys_from_master);
+ CloseHandle (ptys_input_available_event);
}
+ if (enable_pcon)
+ fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
else if (cons_native)
{
- WaitForSingleObject (pi.hProcess, INFINITE);
fhandler_console::request_xterm_mode_output (true,
&cons_handle_set);
fhandler_console::request_xterm_mode_input (true,
@@ -975,6 +985,14 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
system_call.arm ();
if (waitpid (cygpid, &res, 0) != cygpid)
res = -1;
+ if (ptys_ttyp)
+ {
+ fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
+ ptys_from_master, ptys_ttyp,
+ ptys_input_available_event);
+ CloseHandle (ptys_from_master);
+ CloseHandle (ptys_input_available_event);
+ }
if (enable_pcon)
fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
else if (cons_native)
diff --git a/winsup/cygwin/tty.cc b/winsup/cygwin/tty.cc
index c6e13f111..436f5c6c3 100644
--- a/winsup/cygwin/tty.cc
+++ b/winsup/cygwin/tty.cc
@@ -244,8 +244,6 @@ tty::init ()
pcon_start = false;
pcon_cap_checked = false;
has_csi6n = false;
- has_set_title = false;
- do_not_resize_pcon = false;
need_invisible_console = false;
invisible_console_pid = 0;
}
diff --git a/winsup/cygwin/tty.h b/winsup/cygwin/tty.h
index a975aba45..eb604588c 100644
--- a/winsup/cygwin/tty.h
+++ b/winsup/cygwin/tty.h
@@ -93,6 +93,8 @@ private:
HANDLE _from_master_cyg;
HANDLE _to_master;
HANDLE _to_master_cyg;
+ HANDLE _to_slave;
+ HANDLE _to_slave_cyg;
HPCON h_pseudo_console;
bool pcon_start;
bool switch_to_pcon_in;
@@ -103,8 +105,6 @@ private:
HANDLE h_pcon_write_pipe;
bool pcon_cap_checked;
bool has_csi6n;
- bool has_set_title;
- bool do_not_resize_pcon;
bool need_invisible_console;
pid_t invisible_console_pid;
@@ -113,10 +113,14 @@ public:
HANDLE from_master_cyg () const { return _from_master_cyg; }
HANDLE to_master () const { return _to_master; }
HANDLE to_master_cyg () const { return _to_master_cyg; }
+ HANDLE to_slave () const { return _to_slave; }
+ HANDLE to_slave_cyg () const { return _to_slave_cyg; }
void set_from_master (HANDLE h) { _from_master = h; }
void set_from_master_cyg (HANDLE h) { _from_master_cyg = h; }
void set_to_master (HANDLE h) { _to_master = h; }
void set_to_master_cyg (HANDLE h) { _to_master_cyg = h; }
+ void set_to_slave (HANDLE h) { _to_slave = h; }
+ void set_to_slave_cyg (HANDLE h) { _to_slave_cyg = h; }
int read_retval;
bool was_opened; /* True if opened at least once. */
--
2.30.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 2/4] Cygwin: pty: Keep code page between non-cygwin apps.
2021-01-21 20:58 [PATCH v2 0/4] Improve pseudo console support Takashi Yano
2021-01-21 20:58 ` [PATCH v2 1/4] Cygwin: pty: Inherit typeahead data between two input pipes Takashi Yano
@ 2021-01-21 20:58 ` Takashi Yano
2021-01-21 20:58 ` [PATCH v2 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb Takashi Yano
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Takashi Yano @ 2021-01-21 20:58 UTC (permalink / raw)
To: cygwin-patches
- After commit bb428520, there has been the disadvantage:
4) Code page cannot be changed by chcp.com. Acctually, chcp works
itself and changes code page of its own pseudo console. However,
since pseudo console is recreated for another process, it cannot
inherit the code page.
This patch clears this disadvantage.
---
winsup/cygwin/fhandler_tty.cc | 7 +++++++
winsup/cygwin/tty.cc | 2 ++
winsup/cygwin/tty.h | 2 ++
3 files changed, 11 insertions(+)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 75ab500b1..1396f9b1b 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -2807,6 +2807,11 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
HPCON_INTERNAL *hp = (HPCON_INTERNAL *) get_ttyp ()->h_pseudo_console;
get_ttyp ()->h_pcon_write_pipe = hp->hWritePipe;
}
+
+ if (get_ttyp ()->previous_code_page)
+ SetConsoleCP (get_ttyp ()->previous_code_page);
+ if (get_ttyp ()->previous_output_code_page)
+ SetConsoleOutputCP (get_ttyp ()->previous_output_code_page);
return true;
cleanup_pcon_in:
@@ -2846,6 +2851,8 @@ fhandler_pty_slave::close_pseudoconsole (tty *ttyp)
if (ttyp->h_pseudo_console)
{
ttyp->wait_pcon_fwd ();
+ ttyp->previous_code_page = GetConsoleCP ();
+ ttyp->previous_output_code_page = GetConsoleOutputCP ();
FreeConsole ();
AttachConsole (ATTACH_PARENT_PROCESS);
HPCON_INTERNAL *hp = (HPCON_INTERNAL *) ttyp->h_pseudo_console;
diff --git a/winsup/cygwin/tty.cc b/winsup/cygwin/tty.cc
index 436f5c6c3..908166a37 100644
--- a/winsup/cygwin/tty.cc
+++ b/winsup/cygwin/tty.cc
@@ -246,6 +246,8 @@ tty::init ()
has_csi6n = false;
need_invisible_console = false;
invisible_console_pid = 0;
+ previous_code_page = 0;
+ previous_output_code_page = 0;
}
HANDLE
diff --git a/winsup/cygwin/tty.h b/winsup/cygwin/tty.h
index eb604588c..061357437 100644
--- a/winsup/cygwin/tty.h
+++ b/winsup/cygwin/tty.h
@@ -107,6 +107,8 @@ private:
bool has_csi6n;
bool need_invisible_console;
pid_t invisible_console_pid;
+ UINT previous_code_page;
+ UINT previous_output_code_page;
public:
HANDLE from_master () const { return _from_master; }
--
2.30.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb.
2021-01-21 20:58 [PATCH v2 0/4] Improve pseudo console support Takashi Yano
2021-01-21 20:58 ` [PATCH v2 1/4] Cygwin: pty: Inherit typeahead data between two input pipes Takashi Yano
2021-01-21 20:58 ` [PATCH v2 2/4] Cygwin: pty: Keep code page between non-cygwin apps Takashi Yano
@ 2021-01-21 20:58 ` Takashi Yano
2021-01-21 20:58 ` [PATCH v2 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously Takashi Yano
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Takashi Yano @ 2021-01-21 20:58 UTC (permalink / raw)
To: cygwin-patches
- After commit bb428520, there has been the disadvantage:
2) The apps which use console API cannot be debugged with gdb. This
is because pseudo console is not activated since gdb uses
CreateProcess() rather than exec(). Even with this limitation,
attaching gdb to native app, in which pseudo console is already
activated, works.
This patch clears this disadvantage.
---
winsup/cygwin/fhandler_tty.cc | 124 +++++++++++++++++++++++++---------
winsup/cygwin/spawn.cc | 2 +
winsup/cygwin/tty.cc | 5 +-
winsup/cygwin/tty.h | 2 +-
4 files changed, 97 insertions(+), 36 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 1396f9b1b..b599ff5d1 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -85,21 +85,42 @@ get_console_process_id (DWORD pid, bool match)
}
static bool isHybrid;
+static HANDLE h_gdb_process;
static void
-set_switch_to_pcon (HANDLE h)
+set_switch_to_pcon (HANDLE *in, HANDLE *out, HANDLE *err)
{
cygheap_fdenum cfd (false);
int fd;
+ fhandler_base *replace_in = NULL, *replace_out = NULL, *replace_err = NULL;
+ fhandler_pty_slave *ptys_pcon = NULL;
while ((fd = cfd.next ()) >= 0)
- if (cfd->get_major () == DEV_PTYS_MAJOR)
- {
- fhandler_base *fh = cfd;
- fhandler_pty_slave *ptys = (fhandler_pty_slave *) fh;
- if (h == ptys->get_handle ())
- ptys->set_switch_to_pcon ();
- return;
- }
+ {
+ if (*in == cfd->get_handle () ||
+ (fd == 0 && *in == GetStdHandle (STD_INPUT_HANDLE)))
+ replace_in = (fhandler_base *) cfd;
+ if (*out == cfd->get_output_handle () ||
+ (fd == 1 && *out == GetStdHandle (STD_OUTPUT_HANDLE)))
+ replace_out = (fhandler_base *) cfd;
+ if (*err == cfd->get_output_handle () ||
+ (fd == 2 && *err == GetStdHandle (STD_ERROR_HANDLE)))
+ replace_err = (fhandler_base *) cfd;
+ if (cfd->get_major () == DEV_PTYS_MAJOR)
+ {
+ fhandler_base *fh = cfd;
+ fhandler_pty_slave *ptys = (fhandler_pty_slave *) fh;
+ if (*in == ptys->get_handle ())
+ ptys_pcon = ptys;
+ }
+ }
+ if (ptys_pcon)
+ ptys_pcon->set_switch_to_pcon ();
+ if (replace_in)
+ *in = replace_in->get_handle ();
+ if (replace_out)
+ *out = replace_out->get_output_handle ();
+ if (replace_err)
+ *err = replace_err->get_output_handle ();
}
#define DEF_HOOK(name) static __typeof__ (name) *name##_Orig
@@ -113,16 +134,26 @@ CreateProcessA_Hooked
BOOL inh, DWORD f, LPVOID e, LPCSTR d,
LPSTARTUPINFOA si, LPPROCESS_INFORMATION pi)
{
- HANDLE h;
- if (!isHybrid)
- {
- if (si->dwFlags & STARTF_USESTDHANDLES)
- h = si->hStdInput;
- else
- h = GetStdHandle (STD_INPUT_HANDLE);
- set_switch_to_pcon (h);
- }
- return CreateProcessA_Orig (n, c, pa, ta, inh, f, e, d, si, pi);
+ STARTUPINFOEXA siex = {0, };
+ if (si->cb == sizeof (STARTUPINFOEXA))
+ siex = *(STARTUPINFOEXA *)si;
+ else
+ siex.StartupInfo = *si;
+ STARTUPINFOA *siov = &siex.StartupInfo;
+ if (!(si->dwFlags & STARTF_USESTDHANDLES))
+ {
+ siov->dwFlags |= STARTF_USESTDHANDLES;
+ siov->hStdInput = GetStdHandle (STD_INPUT_HANDLE);
+ siov->hStdOutput = GetStdHandle (STD_OUTPUT_HANDLE);
+ siov->hStdError = GetStdHandle (STD_ERROR_HANDLE);
+ }
+ set_switch_to_pcon (&siov->hStdInput, &siov->hStdOutput, &siov->hStdError);
+ BOOL ret = CreateProcessA_Orig (n, c, pa, ta, inh, f, e, d, siov, pi);
+ h_gdb_process = pi->hProcess;
+ DuplicateHandle (GetCurrentProcess (), h_gdb_process,
+ GetCurrentProcess (), &h_gdb_process,
+ 0, 0, DUPLICATE_SAME_ACCESS);
+ return ret;
}
static BOOL WINAPI
CreateProcessW_Hooked
@@ -130,16 +161,26 @@ CreateProcessW_Hooked
BOOL inh, DWORD f, LPVOID e, LPCWSTR d,
LPSTARTUPINFOW si, LPPROCESS_INFORMATION pi)
{
- HANDLE h;
- if (!isHybrid)
- {
- if (si->dwFlags & STARTF_USESTDHANDLES)
- h = si->hStdInput;
- else
- h = GetStdHandle (STD_INPUT_HANDLE);
- set_switch_to_pcon (h);
- }
- return CreateProcessW_Orig (n, c, pa, ta, inh, f, e, d, si, pi);
+ STARTUPINFOEXW siex = {0, };
+ if (si->cb == sizeof (STARTUPINFOEXW))
+ siex = *(STARTUPINFOEXW *)si;
+ else
+ siex.StartupInfo = *si;
+ STARTUPINFOW *siov = &siex.StartupInfo;
+ if (!(si->dwFlags & STARTF_USESTDHANDLES))
+ {
+ siov->dwFlags |= STARTF_USESTDHANDLES;
+ siov->hStdInput = GetStdHandle (STD_INPUT_HANDLE);
+ siov->hStdOutput = GetStdHandle (STD_OUTPUT_HANDLE);
+ siov->hStdError = GetStdHandle (STD_ERROR_HANDLE);
+ }
+ set_switch_to_pcon (&siov->hStdInput, &siov->hStdOutput, &siov->hStdError);
+ BOOL ret = CreateProcessW_Orig (n, c, pa, ta, inh, f, e, d, siov, pi);
+ h_gdb_process = pi->hProcess;
+ DuplicateHandle (GetCurrentProcess (), h_gdb_process,
+ GetCurrentProcess (), &h_gdb_process,
+ 0, 0, DUPLICATE_SAME_ACCESS);
+ return ret;
}
static void
@@ -833,9 +874,9 @@ fhandler_pty_slave::set_switch_to_pcon (void)
if (!get_ttyp ()->switch_to_pcon_in)
{
isHybrid = true;
- if (get_ttyp ()->pcon_pid == 0 || !pinfo (get_ttyp ()->pcon_pid))
- get_ttyp ()->pcon_pid = myself->pid;
- get_ttyp ()->switch_to_pcon_in = true;
+ setup_locale ();
+ bool nopcon = (disable_pcon || !term_has_pcon_cap (NULL));
+ setup_pseudoconsole (nopcon);
}
}
@@ -846,6 +887,16 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
&& !!pinfo (get_ttyp ()->pcon_pid))
/* There is a process which is grabbing pseudo console. */
return;
+ if (h_gdb_process)
+ {
+ if (WaitForSingleObject (h_gdb_process, 0) == WAIT_TIMEOUT)
+ get_ttyp ()->wait_pcon_fwd (false);
+ else
+ {
+ CloseHandle (h_gdb_process);
+ h_gdb_process = NULL;
+ }
+ }
if (isHybrid)
return;
get_ttyp ()->pcon_pid = 0;
@@ -2781,6 +2832,14 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
CloseHandle (pi.hProcess);
/* Set handle */
+ if (GetStdHandle (STD_INPUT_HANDLE) == get_handle ())
+ SetStdHandle (STD_INPUT_HANDLE, hpConIn);
+ if (GetStdHandle (STD_OUTPUT_HANDLE) == get_output_handle ())
+ SetStdHandle (STD_OUTPUT_HANDLE, hpConOut);
+ if (GetStdHandle (STD_ERROR_HANDLE) == get_output_handle ())
+ SetStdHandle (STD_ERROR_HANDLE, hpConOut);
+
+ /* Fixup handles */
HANDLE orig_input_handle = get_handle ();
HANDLE orig_output_handle = get_output_handle ();
cygheap_fdenum cfd (false);
@@ -2850,7 +2909,6 @@ fhandler_pty_slave::close_pseudoconsole (tty *ttyp)
{
if (ttyp->h_pseudo_console)
{
- ttyp->wait_pcon_fwd ();
ttyp->previous_code_page = GetConsoleCP ();
ttyp->previous_output_code_page = GetConsoleOutputCP ();
FreeConsole ();
diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index d12e52e4f..7984ffbc5 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -962,6 +962,7 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
WaitForSingleObject (pi.hProcess, INFINITE);
if (ptys_ttyp)
{
+ ptys_ttyp->wait_pcon_fwd ();
fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
ptys_from_master, ptys_ttyp,
ptys_input_available_event);
@@ -987,6 +988,7 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
res = -1;
if (ptys_ttyp)
{
+ ptys_ttyp->wait_pcon_fwd ();
fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
ptys_from_master, ptys_ttyp,
ptys_input_available_event);
diff --git a/winsup/cygwin/tty.cc b/winsup/cygwin/tty.cc
index 908166a37..432113275 100644
--- a/winsup/cygwin/tty.cc
+++ b/winsup/cygwin/tty.cc
@@ -294,7 +294,7 @@ tty_min::ttyname ()
}
void
-tty::wait_pcon_fwd (void)
+tty::wait_pcon_fwd (bool init)
{
/* The forwarding in pseudo console sometimes stops for
16-32 msec even if it already has data to transfer.
@@ -304,7 +304,8 @@ tty::wait_pcon_fwd (void)
thread when the last data is transfered. */
const int sleep_in_pcon = 16;
const int time_to_wait = sleep_in_pcon * 2 + 1/* margine */;
- pcon_last_time = GetTickCount ();
+ if (init)
+ pcon_last_time = GetTickCount ();
while (GetTickCount () - pcon_last_time < time_to_wait)
{
int tw = time_to_wait - (GetTickCount () - pcon_last_time);
diff --git a/winsup/cygwin/tty.h b/winsup/cygwin/tty.h
index 061357437..47ccad670 100644
--- a/winsup/cygwin/tty.h
+++ b/winsup/cygwin/tty.h
@@ -142,7 +142,7 @@ public:
void set_master_ctl_closed () {master_pid = -1;}
static void __stdcall create_master (int);
static void __stdcall init_session ();
- void wait_pcon_fwd (void);
+ void wait_pcon_fwd (bool init = true);
friend class fhandler_pty_common;
friend class fhandler_pty_master;
friend class fhandler_pty_slave;
--
2.30.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously.
2021-01-21 20:58 [PATCH v2 0/4] Improve pseudo console support Takashi Yano
` (2 preceding siblings ...)
2021-01-21 20:58 ` [PATCH v2 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb Takashi Yano
@ 2021-01-21 20:58 ` Takashi Yano
2021-01-22 9:50 ` [PATCH v2 0/4] Improve pseudo console support Corinna Vinschen
2021-01-22 12:20 ` Corinna Vinschen
5 siblings, 0 replies; 9+ messages in thread
From: Takashi Yano @ 2021-01-21 20:58 UTC (permalink / raw)
To: cygwin-patches
- After commit bb428520, there has been the disadvantage:
7) Pseudo console cannot be activated if it is already activated for
another process on same pty.
This patch clears this disadvantage.
---
winsup/cygwin/fhandler.h | 3 +
winsup/cygwin/fhandler_tty.cc | 240 ++++++++++++++++++++++++++--------
winsup/cygwin/spawn.cc | 40 ++++--
winsup/cygwin/tty.cc | 2 +-
winsup/cygwin/tty.h | 6 +-
5 files changed, 226 insertions(+), 65 deletions(-)
diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h
index 10c5973dd..698de051d 100644
--- a/winsup/cygwin/fhandler.h
+++ b/winsup/cygwin/fhandler.h
@@ -2273,6 +2273,9 @@ class fhandler_pty_common: public fhandler_termios
}
void resize_pseudo_console (struct winsize *);
+ static DWORD get_console_process_id (DWORD pid, bool match,
+ bool cygwin = false,
+ bool stub_only = false);
protected:
static BOOL process_opost_output (HANDLE h, const void *ptr, ssize_t& len,
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index b599ff5d1..b2f352964 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -61,8 +61,9 @@ struct pipe_reply {
extern HANDLE attach_mutex; /* Defined in fhandler_console.cc */
-static DWORD
-get_console_process_id (DWORD pid, bool match)
+DWORD
+fhandler_pty_common::get_console_process_id (DWORD pid, bool match,
+ bool cygwin, bool stub_only)
{
tmp_pathbuf tp;
DWORD *list = (DWORD *) tp.c_get ();
@@ -72,16 +73,34 @@ get_console_process_id (DWORD pid, bool match)
if (num == 0 || num > buf_size)
return 0;
- DWORD res = 0;
+ DWORD res_pri = 0, res = 0;
/* Last one is the oldest. */
/* https://github.com/microsoft/terminal/issues/95 */
for (int i = (int) num - 1; i >= 0; i--)
if ((match && list[i] == pid) || (!match && list[i] != pid))
{
- res = list[i];
- break;
+ if (!cygwin)
+ {
+ res_pri = list[i];
+ break;
+ }
+ else
+ {
+ pinfo p (cygwin_pid (list[i]));
+ if (!!p && p->dwProcessId && p->exec_dwProcessId
+ && p->dwProcessId != p->exec_dwProcessId)
+ {
+ res_pri = list[i];
+ break;
+ }
+ if (!!p && !res)
+ res = list[i];
+ }
}
- return res;
+ if (stub_only)
+ return res_pri;
+ else
+ return res_pri ?: res;
}
static bool isHybrid;
@@ -871,7 +890,7 @@ fhandler_pty_slave::init (HANDLE h, DWORD a, mode_t)
void
fhandler_pty_slave::set_switch_to_pcon (void)
{
- if (!get_ttyp ()->switch_to_pcon_in)
+ if (!isHybrid)
{
isHybrid = true;
setup_locale ();
@@ -883,10 +902,6 @@ fhandler_pty_slave::set_switch_to_pcon (void)
void
fhandler_pty_slave::reset_switch_to_pcon (void)
{
- if (get_ttyp ()->pcon_pid && get_ttyp ()->pcon_pid != myself->pid
- && !!pinfo (get_ttyp ()->pcon_pid))
- /* There is a process which is grabbing pseudo console. */
- return;
if (h_gdb_process)
{
if (WaitForSingleObject (h_gdb_process, 0) == WAIT_TIMEOUT)
@@ -897,6 +912,10 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
h_gdb_process = NULL;
}
}
+ if (get_ttyp ()->pcon_pid && get_ttyp ()->pcon_pid != myself->pid
+ && !!pinfo (get_ttyp ()->pcon_pid))
+ /* There is a process which is grabbing pseudo console. */
+ return;
if (isHybrid)
return;
get_ttyp ()->pcon_pid = 0;
@@ -1236,7 +1255,7 @@ fhandler_pty_slave::tcgetattr (struct termios *t)
{
if (get_ttyp ()->pcon_start)
t->c_lflag &= ~(ICANON | ECHO);
- if (get_ttyp ()->h_pseudo_console)
+ if (get_ttyp ()->pcon_activated)
t->c_iflag &= ~ICRNL;
break;
}
@@ -1351,7 +1370,7 @@ fhandler_pty_slave::ioctl (unsigned int cmd, void *arg)
if (get_ttyp ()->winsize.ws_row != ((struct winsize *) arg)->ws_row
|| get_ttyp ()->winsize.ws_col != ((struct winsize *) arg)->ws_col)
{
- if (get_ttyp ()->h_pseudo_console && get_ttyp ()->pcon_pid)
+ if (get_ttyp ()->pcon_activated && get_ttyp ()->pcon_pid)
resize_pseudo_console ((struct winsize *) arg);
get_ttyp ()->arg.winsize = *(struct winsize *) arg;
get_ttyp ()->winsize = *(struct winsize *) arg;
@@ -1766,7 +1785,7 @@ fhandler_pty_master::write (const void *ptr, size_t len)
/* Write terminal input to to_slave pipe instead of output_handle
if current application is native console application. */
- if (to_be_read_from_pcon () && get_ttyp ()->h_pseudo_console)
+ if (to_be_read_from_pcon () && get_ttyp ()->pcon_activated)
{
tmp_pathbuf tp;
char *buf = (char *) ptr;
@@ -1861,7 +1880,7 @@ fhandler_pty_master::tcgetattr (struct termios *t)
/* Workaround for rlwrap v0.40 or later */
if (get_ttyp ()->pcon_start)
t->c_lflag &= ~(ICANON | ECHO);
- if (get_ttyp ()->h_pseudo_console)
+ if (get_ttyp ()->pcon_activated)
t->c_iflag &= ~ICRNL;
return 0;
}
@@ -1910,7 +1929,7 @@ fhandler_pty_master::ioctl (unsigned int cmd, void *arg)
if (get_ttyp ()->winsize.ws_row != ((struct winsize *) arg)->ws_row
|| get_ttyp ()->winsize.ws_col != ((struct winsize *) arg)->ws_col)
{
- if (get_ttyp ()->h_pseudo_console && get_ttyp ()->pcon_pid)
+ if (get_ttyp ()->pcon_activated && get_ttyp ()->pcon_pid)
resize_pseudo_console ((struct winsize *) arg);
get_ttyp ()->winsize = *(struct winsize *) arg;
get_ttyp ()->kill_pgrp (SIGWINCH);
@@ -2190,7 +2209,7 @@ fhandler_pty_master::pty_master_fwd_thread (const master_fwd_thread_param_t *p)
}
ssize_t wlen = rlen;
char *ptr = outbuf;
- if (p->ttyp->h_pseudo_console)
+ if (p->ttyp->pcon_activated)
{
/* Avoid setting window title to "cygwin-console-helper.exe" */
int state = 0;
@@ -2688,9 +2707,7 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
if (nopcon)
return false;
- if (get_ttyp ()->pcon_pid && get_ttyp ()->pcon_pid != myself->pid
- && !!pinfo (get_ttyp ()->pcon_pid))
- return false;
+
/* If the legacy console mode is enabled, pseudo console seems
not to work as expected. To determine console mode, registry
key ForceV2 in HKEY_CURRENT_USER\Console is checked. */
@@ -2704,11 +2721,32 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
return false;
}
+ HANDLE hpConIn, hpConOut;
+ acquire_output_mutex (INFINITE);
+ if (get_ttyp ()->pcon_pid && get_ttyp ()->pcon_pid != myself->pid
+ && !!pinfo (get_ttyp ()->pcon_pid) && get_ttyp ()->pcon_activated)
+ {
+ /* Attach to the pseudo console which already exits. */
+ pinfo p (get_ttyp ()->pcon_pid);
+ HANDLE pcon_owner =
+ OpenProcess (PROCESS_DUP_HANDLE, FALSE, p->exec_dwProcessId);
+ DuplicateHandle (pcon_owner, get_ttyp ()->h_pcon_in,
+ GetCurrentProcess (), &hpConIn,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (pcon_owner, get_ttyp ()->h_pcon_out,
+ GetCurrentProcess (), &hpConOut,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ CloseHandle (pcon_owner);
+ FreeConsole ();
+ AttachConsole (p->dwProcessId);
+ goto skip_create;
+ }
+
STARTUPINFOEXW si;
PROCESS_INFORMATION pi;
HANDLE hello, goodbye;
HANDLE hr, hw;
- HANDLE hpConIn, hpConOut;
+ HPCON hpcon;
do
{
@@ -2717,11 +2755,11 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
(SHORT) get_ttyp ()->winsize.ws_row
};
const DWORD inherit_cursor = 1;
+ hpcon = NULL;
SetLastError (ERROR_SUCCESS);
HRESULT res = CreatePseudoConsole (size, get_handle (),
get_output_handle (),
- inherit_cursor,
- &get_ttyp ()->h_pseudo_console);
+ inherit_cursor, &hpcon);
if (res != S_OK || GetLastError () == ERROR_PROC_NOT_FOUND)
{
if (res != S_OK)
@@ -2744,9 +2782,7 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
if (!UpdateProcThreadAttribute (si.lpAttributeList,
0,
PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE,
- get_ttyp ()->h_pseudo_console,
- sizeof (get_ttyp ()->h_pseudo_console),
- NULL, NULL))
+ hpcon, sizeof (hpcon), NULL, NULL))
goto cleanup_heap;
@@ -2775,6 +2811,7 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
si.StartupInfo.hStdError = NULL;
get_ttyp ()->pcon_start = true;
+ get_ttyp ()->pcon_activated = true;
if (!CreateProcessW (NULL, cmd, &sec_none, &sec_none,
TRUE, EXTENDED_STARTUPINFO_PRESENT,
NULL, NULL, &si.StartupInfo, &pi))
@@ -2830,7 +2867,12 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
WaitForSingleObject (pi.hProcess, INFINITE);
CloseHandle (goodbye);
CloseHandle (pi.hProcess);
+ }
+ while (false);
+skip_create:
+ do
+ {
/* Set handle */
if (GetStdHandle (STD_INPUT_HANDLE) == get_handle ())
SetStdHandle (STD_INPUT_HANDLE, hpConIn);
@@ -2861,16 +2903,29 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
if (get_ttyp ()->pcon_pid == 0 || !pinfo (get_ttyp ()->pcon_pid))
get_ttyp ()->pcon_pid = myself->pid;
- if (get_ttyp ()->h_pseudo_console && get_ttyp ()->pcon_pid == myself->pid)
+ if (hpcon && get_ttyp ()->pcon_pid == myself->pid)
{
- HPCON_INTERNAL *hp = (HPCON_INTERNAL *) get_ttyp ()->h_pseudo_console;
+ HPCON_INTERNAL *hp = (HPCON_INTERNAL *) hpcon;
get_ttyp ()->h_pcon_write_pipe = hp->hWritePipe;
+ get_ttyp ()->h_pcon_condrv_reference = hp->hConDrvReference;
+ get_ttyp ()->h_pcon_conhost_process = hp->hConHostProcess;
+ DuplicateHandle (GetCurrentProcess (), hpConIn,
+ GetCurrentProcess (), &get_ttyp ()->h_pcon_in,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (GetCurrentProcess (), hpConOut,
+ GetCurrentProcess (), &get_ttyp ()->h_pcon_out,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ /* Discard the pseudo console handler container here.
+ Reconstruct it temporary when it is needed. */
+ HeapFree (GetProcessHeap (), 0, hp);
}
if (get_ttyp ()->previous_code_page)
SetConsoleCP (get_ttyp ()->previous_code_page);
if (get_ttyp ()->previous_output_code_page)
SetConsoleOutputCP (get_ttyp ()->previous_output_code_page);
+
+ release_output_mutex ();
return true;
cleanup_pcon_in:
@@ -2882,6 +2937,8 @@ cleanup_helper_process:
goto skip_close_hello;
cleanup_event_and_pipes:
CloseHandle (hello);
+ get_ttyp ()->pcon_start = false;
+ get_ttyp ()->pcon_activated = false;
skip_close_hello:
CloseHandle (goodbye);
CloseHandle (hr);
@@ -2889,16 +2946,15 @@ skip_close_hello:
cleanup_heap:
HeapFree (GetProcessHeap (), 0, si.lpAttributeList);
cleanup_pseudo_console:
- if (get_ttyp ()->h_pseudo_console)
+ if (hpcon)
{
- HPCON_INTERNAL *hp = (HPCON_INTERNAL *) get_ttyp ()->h_pseudo_console;
+ HPCON_INTERNAL *hp = (HPCON_INTERNAL *) hpcon;
HANDLE tmp = hp->hConHostProcess;
- ClosePseudoConsole (get_ttyp ()->h_pseudo_console);
+ ClosePseudoConsole (hpcon);
CloseHandle (tmp);
}
fallback:
- get_ttyp ()->pcon_start = false;
- get_ttyp ()->h_pseudo_console = NULL;
+ release_output_mutex ();
return false;
}
@@ -2907,20 +2963,102 @@ fallback:
void
fhandler_pty_slave::close_pseudoconsole (tty *ttyp)
{
- if (ttyp->h_pseudo_console)
+ DWORD switch_to_stub = 0, switch_to = 0;
+ DWORD new_pcon_pid = 0;
+ if (ttyp->pcon_pid == myself->pid)
+ {
+ /* Search another process which attaches to the pseudo console */
+ switch_to =
+ get_console_process_id (myself->exec_dwProcessId, false, true);
+ if (switch_to)
+ {
+ pinfo p (cygwin_pid (switch_to));
+ if (p)
+ {
+ if (p->exec_dwProcessId)
+ switch_to_stub = p->exec_dwProcessId;
+ new_pcon_pid = p->pid;
+ }
+ }
+ }
+ if (ttyp->pcon_activated)
{
ttyp->previous_code_page = GetConsoleCP ();
ttyp->previous_output_code_page = GetConsoleOutputCP ();
- FreeConsole ();
- AttachConsole (ATTACH_PARENT_PROCESS);
- HPCON_INTERNAL *hp = (HPCON_INTERNAL *) ttyp->h_pseudo_console;
- HANDLE tmp = hp->hConHostProcess;
- ClosePseudoConsole (ttyp->h_pseudo_console);
- CloseHandle (tmp);
- ttyp->h_pseudo_console = NULL;
- ttyp->switch_to_pcon_in = false;
- ttyp->pcon_pid = 0;
- ttyp->pcon_start = false;
+ if (ttyp->pcon_pid == myself->pid)
+ {
+ switch_to = switch_to_stub ?: switch_to;
+ if (switch_to)
+ {
+ /* Change pseudo console owner to another process */
+ HANDLE new_owner =
+ OpenProcess (PROCESS_DUP_HANDLE, FALSE, switch_to);
+ HANDLE new_write_pipe = NULL;
+ HANDLE new_condrv_reference = NULL;
+ HANDLE new_conhost_process = NULL;
+ HANDLE new_pcon_in = NULL, new_pcon_out = NULL;
+ DuplicateHandle (GetCurrentProcess (),
+ ttyp->h_pcon_write_pipe,
+ new_owner, &new_write_pipe,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (GetCurrentProcess (),
+ ttyp->h_pcon_condrv_reference,
+ new_owner, &new_condrv_reference,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (GetCurrentProcess (),
+ ttyp->h_pcon_conhost_process,
+ new_owner, &new_conhost_process,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (GetCurrentProcess (), ttyp->h_pcon_in,
+ new_owner, &new_pcon_in,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (GetCurrentProcess (), ttyp->h_pcon_out,
+ new_owner, &new_pcon_out,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ CloseHandle (new_owner);
+ CloseHandle (ttyp->h_pcon_write_pipe);
+ CloseHandle (ttyp->h_pcon_condrv_reference);
+ CloseHandle (ttyp->h_pcon_conhost_process);
+ CloseHandle (ttyp->h_pcon_in);
+ CloseHandle (ttyp->h_pcon_out);
+ ttyp->pcon_pid = new_pcon_pid;
+ ttyp->h_pcon_write_pipe = new_write_pipe;
+ ttyp->h_pcon_condrv_reference = new_condrv_reference;
+ ttyp->h_pcon_conhost_process = new_conhost_process;
+ ttyp->h_pcon_in = new_pcon_in;
+ ttyp->h_pcon_out = new_pcon_out;
+ }
+ else
+ {
+ /* Close pseudo console */
+ FreeConsole ();
+ AttachConsole (ATTACH_PARENT_PROCESS);
+ /* Reconstruct pseudo console handler container here for close */
+ HPCON_INTERNAL *hp =
+ (HPCON_INTERNAL *) HeapAlloc (GetProcessHeap (), 0,
+ sizeof (*hp));
+ hp->hWritePipe = ttyp->h_pcon_write_pipe;
+ hp->hConDrvReference = ttyp->h_pcon_condrv_reference;
+ hp->hConHostProcess = ttyp->h_pcon_conhost_process;
+ /* HeapFree() will be called in ClosePseudoConsole() */
+ ClosePseudoConsole ((HPCON) hp);
+ CloseHandle (ttyp->h_pcon_conhost_process);
+ ttyp->pcon_activated = false;
+ ttyp->switch_to_pcon_in = false;
+ ttyp->pcon_pid = 0;
+ ttyp->pcon_start = false;
+ }
+ }
+ }
+ else
+ {
+ if (switch_to_stub)
+ ttyp->pcon_pid = new_pcon_pid;
+ else
+ {
+ ttyp->pcon_pid = 0;
+ ttyp->switch_to_pcon_in = false;
+ }
}
}
@@ -3011,9 +3149,9 @@ fhandler_pty_slave::term_has_pcon_cap (const WCHAR *env)
/* Check if terminal has CSI6n */
WaitForSingleObject (input_mutex, INFINITE);
- /* Set h_pseudo_console and pcon_start so that the response
+ /* Set pcon_activated and pcon_start so that the response
will sent to io_handle rather than io_handle_cyg. */
- get_ttyp ()->h_pseudo_console = (HPCON *) -1; /* dummy */
+ get_ttyp ()->pcon_activated = true;
/* pcon_start will be cleared in master write() when CSI6n is responded. */
get_ttyp ()->pcon_start = true;
WriteFile (get_output_handle_cyg (), "\033[6n", 4, &n, NULL);
@@ -3043,7 +3181,7 @@ fhandler_pty_slave::term_has_pcon_cap (const WCHAR *env)
Sleep (1);
}
while (len);
- get_ttyp ()->h_pseudo_console = NULL;
+ get_ttyp ()->pcon_activated = false;
if (len == 0)
goto not_has_csi6n;
@@ -3057,7 +3195,7 @@ not_has_csi6n:
/* If CSI6n is not responded, pcon_start is not cleared
in master write(). Therefore, clear it here manually. */
get_ttyp ()->pcon_start = false;
- get_ttyp ()->h_pseudo_console = NULL;
+ get_ttyp ()->pcon_activated = false;
ReleaseMutex (input_mutex);
maybe_dumb:
get_ttyp ()->pcon_cap_checked = true;
@@ -3126,7 +3264,7 @@ fhandler_pty_slave::transfer_input (xfer_dir dir, HANDLE from, tty *ttyp,
if (dir == to_nat)
{
cp_from = ttyp->term_code_page;
- if (ttyp->h_pseudo_console)
+ if (ttyp->pcon_activated)
cp_to = CP_UTF8;
else
cp_to = GetConsoleCP ();
@@ -3142,7 +3280,7 @@ fhandler_pty_slave::transfer_input (xfer_dir dir, HANDLE from, tty *ttyp,
bool transfered = false;
- if (dir == to_cyg && ttyp->h_pseudo_console)
+ if (dir == to_cyg && ttyp->pcon_activated)
{ /* from handle is console handle */
INPUT_RECORD r[INREC_SIZE];
DWORD n;
@@ -3214,7 +3352,7 @@ fhandler_pty_slave::transfer_input (xfer_dir dir, HANDLE from, tty *ttyp,
DWORD n;
ReadFile (from, buf, NT_MAX_PATH, &n, NULL);
char *ptr = buf;
- if (dir == to_nat && ttyp->h_pseudo_console)
+ if (dir == to_nat && ttyp->pcon_activated)
{
char *p = buf;
while ((p = (char *) memchr (p, '\n', n - (p - buf))))
diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 7984ffbc5..5fb4587d8 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -656,6 +656,7 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
bool enable_pcon = false;
HANDLE ptys_from_master = NULL;
HANDLE ptys_input_available_event = NULL;
+ HANDLE ptys_output_mutex = NULL;
tty *ptys_ttyp = NULL;
if (!iscygwin () && ptys_primary && is_console_app (runpath))
{
@@ -674,6 +675,9 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
DuplicateHandle (GetCurrentProcess (), ptys_input_available_event,
GetCurrentProcess (), &ptys_input_available_event,
0, 0, DUPLICATE_SAME_ACCESS);
+ DuplicateHandle (GetCurrentProcess (), ptys_primary->output_mutex,
+ GetCurrentProcess (), &ptys_output_mutex,
+ 0, 0, DUPLICATE_SAME_ACCESS);
if (!enable_pcon)
fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_nat,
ptys_primary->get_handle_cyg (),
@@ -963,15 +967,21 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
if (ptys_ttyp)
{
ptys_ttyp->wait_pcon_fwd ();
- fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
- ptys_from_master, ptys_ttyp,
- ptys_input_available_event);
+ /* Do not transfer input if another process using pseudo
+ console exists. */
+ WaitForSingleObject (ptys_output_mutex, INFINITE);
+ if (!fhandler_pty_common::get_console_process_id
+ (myself->exec_dwProcessId, false, true, true))
+ fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
+ ptys_from_master, ptys_ttyp,
+ ptys_input_available_event);
CloseHandle (ptys_from_master);
CloseHandle (ptys_input_available_event);
+ fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
+ ReleaseMutex (ptys_output_mutex);
+ CloseHandle (ptys_output_mutex);
}
- if (enable_pcon)
- fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
- else if (cons_native)
+ if (cons_native)
{
fhandler_console::request_xterm_mode_output (true,
&cons_handle_set);
@@ -989,15 +999,21 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
if (ptys_ttyp)
{
ptys_ttyp->wait_pcon_fwd ();
- fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
- ptys_from_master, ptys_ttyp,
- ptys_input_available_event);
+ /* Do not transfer input if another process using pseudo
+ console exists. */
+ WaitForSingleObject (ptys_output_mutex, INFINITE);
+ if (!fhandler_pty_common::get_console_process_id
+ (myself->exec_dwProcessId, false, true, true))
+ fhandler_pty_slave::transfer_input (fhandler_pty_slave::to_cyg,
+ ptys_from_master, ptys_ttyp,
+ ptys_input_available_event);
CloseHandle (ptys_from_master);
CloseHandle (ptys_input_available_event);
+ fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
+ ReleaseMutex (ptys_output_mutex);
+ CloseHandle (ptys_output_mutex);
}
- if (enable_pcon)
- fhandler_pty_slave::close_pseudoconsole (ptys_ttyp);
- else if (cons_native)
+ if (cons_native)
{
fhandler_console::request_xterm_mode_output (true,
&cons_handle_set);
diff --git a/winsup/cygwin/tty.cc b/winsup/cygwin/tty.cc
index 432113275..f495fa1b5 100644
--- a/winsup/cygwin/tty.cc
+++ b/winsup/cygwin/tty.cc
@@ -235,7 +235,7 @@ tty::init ()
master_pid = 0;
is_console = false;
column = 0;
- h_pseudo_console = NULL;
+ pcon_activated = false;
switch_to_pcon_in = false;
mask_switch_to_pcon_in = false;
pcon_pid = 0;
diff --git a/winsup/cygwin/tty.h b/winsup/cygwin/tty.h
index 47ccad670..90ebd98f0 100644
--- a/winsup/cygwin/tty.h
+++ b/winsup/cygwin/tty.h
@@ -95,7 +95,7 @@ private:
HANDLE _to_master_cyg;
HANDLE _to_slave;
HANDLE _to_slave_cyg;
- HPCON h_pseudo_console;
+ bool pcon_activated;
bool pcon_start;
bool switch_to_pcon_in;
bool mask_switch_to_pcon_in;
@@ -103,6 +103,10 @@ private:
UINT term_code_page;
DWORD pcon_last_time;
HANDLE h_pcon_write_pipe;
+ HANDLE h_pcon_condrv_reference;
+ HANDLE h_pcon_conhost_process;
+ HANDLE h_pcon_in;
+ HANDLE h_pcon_out;
bool pcon_cap_checked;
bool has_csi6n;
bool need_invisible_console;
--
2.30.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 0/4] Improve pseudo console support.
2021-01-21 20:58 [PATCH v2 0/4] Improve pseudo console support Takashi Yano
` (3 preceding siblings ...)
2021-01-21 20:58 ` [PATCH v2 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously Takashi Yano
@ 2021-01-22 9:50 ` Corinna Vinschen
2021-01-22 11:40 ` Takashi Yano
2021-01-22 12:20 ` Corinna Vinschen
5 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2021-01-22 9:50 UTC (permalink / raw)
To: cygwin-patches
On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote:
> The new implementation of pseudo console support by commit bb428520
> provides the important advantages, while there also has been several
> disadvantages compared to the previous implementation.
>
> These patches overturn some of them.
>
> The disadvantage:
> 1) The cygwin program which calls console API directly does not work.
> is supposed to be able to be overcome as well, however, I am not sure
> it is worth enough. This will need a lot of hooks for console APIs.
Definitely not. We should really not cave in to such expectations.
Cygwin apps are POSIX apps in the first place and should use the API
provided by Cygwin and other Cygwin libs. Yes, there are border cases
like the X server or cygrunsrv, but these are limited and should stay
limited.
Corinna
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 0/4] Improve pseudo console support.
2021-01-22 9:50 ` [PATCH v2 0/4] Improve pseudo console support Corinna Vinschen
@ 2021-01-22 11:40 ` Takashi Yano
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Yano @ 2021-01-22 11:40 UTC (permalink / raw)
To: cygwin-patches
On Fri, 22 Jan 2021 10:50:28 +0100
Corinna Vinschen wrote:
> On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote:
> > The new implementation of pseudo console support by commit bb428520
> > provides the important advantages, while there also has been several
> > disadvantages compared to the previous implementation.
> >
> > These patches overturn some of them.
> >
> > The disadvantage:
> > 1) The cygwin program which calls console API directly does not work.
> > is supposed to be able to be overcome as well, however, I am not sure
> > it is worth enough. This will need a lot of hooks for console APIs.
>
> Definitely not. We should really not cave in to such expectations.
> Cygwin apps are POSIX apps in the first place and should use the API
> provided by Cygwin and other Cygwin libs. Yes, there are border cases
> like the X server or cygrunsrv, but these are limited and should stay
> limited.
I agree. I will stop working on it.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/4] Improve pseudo console support.
2021-01-21 20:58 [PATCH v2 0/4] Improve pseudo console support Takashi Yano
` (4 preceding siblings ...)
2021-01-22 9:50 ` [PATCH v2 0/4] Improve pseudo console support Corinna Vinschen
@ 2021-01-22 12:20 ` Corinna Vinschen
2021-01-25 9:37 ` Takashi Yano
5 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2021-01-22 12:20 UTC (permalink / raw)
To: cygwin-patches
Hi Takashi,
On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote:
> The new implementation of pseudo console support by commit bb428520
> provides the important advantages, while there also has been several
> disadvantages compared to the previous implementation.
>
> These patches overturn some of them.
>
> The disadvantage:
> 1) The cygwin program which calls console API directly does not work.
> is supposed to be able to be overcome as well, however, I am not sure
> it is worth enough. This will need a lot of hooks for console APIs.
>
> Takashi Yano (4):
> Cygwin: pty: Inherit typeahead data between two input pipes.
> Cygwin: pty: Keep code page between non-cygwin apps.
> Cygwin: pty: Make apps using console APIs be able to debug with gdb.
> Cygwin: pty: Allow multiple apps to enable pseudo console
> simultaneously.
>
> winsup/cygwin/fhandler.h | 15 +-
> winsup/cygwin/fhandler_tty.cc | 805 ++++++++++++++++++++++++++--------
> winsup/cygwin/spawn.cc | 102 +++--
> winsup/cygwin/tty.cc | 11 +-
> winsup/cygwin/tty.h | 18 +-
> 5 files changed, 730 insertions(+), 221 deletions(-)
>
> --
> 2.30.0
I found a problem with this patchset.
Try this:
Start mintty
$ touch foo
$ attrib +r foo
$ gdb /bin/rm
$ start foo
At this point, starting rm will take a few seconds. While GDB is
still working on this, *before* GDB returns to the prompt, type some
keys on keyboard, e. g., "1234".
Without this patchset, you'll see the keys being echoed in mintty, and
as soon as GDB returns to the prompt, the keys are copied to GDBs input
buffer and the keys you typed show up after the prompt. This is the
expected behaviour.
(gdb) 1234
With this patchset, the keys are *not* echoed in mintty, and as soon
as the GDB prompt returns, the keys are still not visible.
Now continue the execution of rm:
(gdb) c
/usr/bin/rm: remove write-protected regular file 'foo'?
Without this patchset, I get
/usr/bin/rm: error closing file
[...]
[Inferior 1 (process 1224) exited with code 01]
(gdb)
That's not optimal, apparently. With this patchset:
(gdb) c
/usr/bin/rm: remove write-protected regular file 'foo'? 1234
so the keys typed while gdb was starting rm have been saved up and then
used as input for rm. That's not quite right either, is it?
Thanks,
Corinna
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 0/4] Improve pseudo console support.
2021-01-22 12:20 ` Corinna Vinschen
@ 2021-01-25 9:37 ` Takashi Yano
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Yano @ 2021-01-25 9:37 UTC (permalink / raw)
To: cygwin-patches
Hi Corinna,
Thanks for testing.
On Fri, 22 Jan 2021 13:20:57 +0100
Corinna Vinschen wrote:
> Hi Takashi,
>
> On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote:
> > The new implementation of pseudo console support by commit bb428520
> > provides the important advantages, while there also has been several
> > disadvantages compared to the previous implementation.
> >
> > These patches overturn some of them.
> >
> > The disadvantage:
> > 1) The cygwin program which calls console API directly does not work.
> > is supposed to be able to be overcome as well, however, I am not sure
> > it is worth enough. This will need a lot of hooks for console APIs.
> >
> > Takashi Yano (4):
> > Cygwin: pty: Inherit typeahead data between two input pipes.
> > Cygwin: pty: Keep code page between non-cygwin apps.
> > Cygwin: pty: Make apps using console APIs be able to debug with gdb.
> > Cygwin: pty: Allow multiple apps to enable pseudo console
> > simultaneously.
> >
> > winsup/cygwin/fhandler.h | 15 +-
> > winsup/cygwin/fhandler_tty.cc | 805 ++++++++++++++++++++++++++--------
> > winsup/cygwin/spawn.cc | 102 +++--
> > winsup/cygwin/tty.cc | 11 +-
> > winsup/cygwin/tty.h | 18 +-
> > 5 files changed, 730 insertions(+), 221 deletions(-)
> >
> > --
> > 2.30.0
>
> I found a problem with this patchset.
>
> Try this:
>
> Start mintty
>
> $ touch foo
> $ attrib +r foo
> $ gdb /bin/rm
> $ start foo
>
> At this point, starting rm will take a few seconds. While GDB is
> still working on this, *before* GDB returns to the prompt, type some
> keys on keyboard, e. g., "1234".
>
> Without this patchset, you'll see the keys being echoed in mintty, and
> as soon as GDB returns to the prompt, the keys are copied to GDBs input
> buffer and the keys you typed show up after the prompt. This is the
> expected behaviour.
>
> (gdb) 1234
>
> With this patchset, the keys are *not* echoed in mintty, and as soon
> as the GDB prompt returns, the keys are still not visible.
I have fixed this issue. Please try v3 patch set. In v3 patch set,
pseudo console is not activated for GDB if the app to be debugged
is cygwin program. Also, for non-cygwin apps, I added the code to
transfer input when switching occurs between GDB and the debugging
process.
> Now continue the execution of rm:
>
> (gdb) c
> /usr/bin/rm: remove write-protected regular file 'foo'?
>
> Without this patchset, I get
>
> /usr/bin/rm: error closing file
> [...]
> [Inferior 1 (process 1224) exited with code 01]
> (gdb)
This seems to be a bug of cygwin GDB. The cause is that the pgid
setting for /usr/bin/rm is lost after break. The following patch
for GDB source resolves the issue. In the following section,
winpid is passed to getpgid() rather than cygwin pid. Also, winpid
is passed to other POSIX system calls such as kill() elsewhere.
I hope the GDB maintainer will check it out.
--- inflow.c.orig 2020-05-24 06:10:29.000000000 +0900
+++ inflow.c 2021-01-23 17:48:27.963609500 +0900
@@ -364,11 +364,11 @@
#ifdef HAVE_TERMIOS_H
/* If we can't tell the inferior's actual process group,
then restore whatever was the foreground pgrp the last
time the inferior was running. See also comments
describing terminal_state::process_group. */
-#ifdef HAVE_GETPGID
+#if defined (HAVE_GETPGID) && !defined (__CYGWIN__)
result = tcsetpgrp (0, getpgid (inf->pid));
#else
result = tcsetpgrp (0, tinfo->process_group);
#endif
if (result == -1)
> That's not optimal, apparently. With this patchset:
>
> (gdb) c
> /usr/bin/rm: remove write-protected regular file 'foo'? 1234
>
> so the keys typed while gdb was starting rm have been saved up and then
> used as input for rm. That's not quite right either, is it?
Another undesired behavior of cygwin GDB is that the debugging program
in pty cannot continue to execute after interrupted by Ctrl-C. If pseudo
console is activated for the debugging program, it seems to be able to
do this for some unknown reason.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
^ permalink raw reply [flat|nested] 9+ messages in thread