From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().
Date: Tue, 23 Mar 2021 20:57:17 +0900 [thread overview]
Message-ID: <20210323205717.bf5c3a41695871ec70bf1229@nifty.ne.jp> (raw)
In-Reply-To: <YFm+fEONY3wLq3Sp@calimero.vinschen.de>
On Tue, 23 Mar 2021 11:10:04 +0100
Corinna Vinschen wrote:
> [CC Marco, CC Jan]
>
> On Mar 22 13:02, Ken Brown via Cygwin-patches wrote:
> > [Still CC Marco]
> >
> > On 3/22/2021 7:43 AM, Corinna Vinschen via Cygwin-patches wrote:
> > > [CC Marco]
> > >
> > > On Mar 22 08:07, Takashi Yano via Cygwin-patches wrote:
> > > > On Sun, 21 Mar 2021 17:44:27 +0900
> > > > Takashi Yano wrote:
> > > > > [...]
> > > > > However, following cygwin apps/dlls call _get_osfhandle():
> > > > > ccmake.exe
> > > > > cmake.exe
> > > > > cpack.exe
> > > > > ctest.exe
> > > > > ddrescue.exe
>
> I'm pretty sure ddrescue needs the osfhandle just to access raw block
> devices.
>
> > > > > And also, following cygwin apps/dlls call GetStdHandle():
> > > > > ccmake.exe
> > > > > cmake.exe
> > > > > cpack.exe
> > > > > ctest.exe
> > > > > run.exe
>
> run creates its own conin/conout handles to create a hidden console.
> The code calling GetStdHandle() is only for debug purposes and never
> built into the executable.
>
> > > > > cygusb0.dll
>
> This lib tries to access USB devices only.
>
> > > > > tk86.dll
>
> Not sure about this one. In theory this shouldn't happen, given our
> tk is built against X11, not against the Windows GUI.
>
> Jan, can you please check where and why tk86.dll calls GetStdHandle.
> I found a few places in the source where GetStdHandle is called, but
> it's not clear to me which one is called.
Thanks for checking obove.
> > Out of curiosity, I took a quick glance at the cmake code. It appears that
> > this code is designed to support running cmake in a Console. I don't think
> > that should be needed any more, if it ever was.
> > [...]
> > I think the following might suffice (untested):
> >
> > --- a/Source/kwsys/Terminal.c
> > +++ b/Source/kwsys/Terminal.c
> > @@ -10,7 +10,7 @@
> > #endif
> >
> > /* Configure support for this platform. */
> > -#if defined(_WIN32) || defined(__CYGWIN__)
> > +#if defined(_WIN32)
> > # define KWSYS_TERMINAL_SUPPORT_CONSOLE
> > #endif
> > #if !defined(_WIN32)
>
> Looks right to me. If we patch cmake to do the right thing, do we still
> need this patch, Takashi?
I don't think so. If all is well with current code, nothing to be fixed.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2021-03-23 11:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 4:01 Takashi Yano
2021-03-21 4:01 ` [PATCH 1/2] Cygwin: syscalls.cc: Make _get_osfhandle() return appropriate handle Takashi Yano
2021-03-21 4:01 ` [PATCH 2/2] Cygwin: pty: Add hook for GetStdHandle() to " Takashi Yano
2021-03-21 8:44 ` [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle() Takashi Yano
2021-03-21 23:07 ` Takashi Yano
2021-03-22 11:43 ` Corinna Vinschen
2021-03-22 17:02 ` Ken Brown
2021-03-23 10:10 ` Corinna Vinschen
2021-03-23 11:57 ` Takashi Yano [this message]
2021-03-23 12:17 ` Corinna Vinschen
2021-03-23 12:32 ` Takashi Yano
2021-03-23 12:42 ` Takashi Yano
2021-03-23 12:46 ` Corinna Vinschen
2021-03-23 12:52 ` Takashi Yano
2021-03-23 13:32 ` Corinna Vinschen
2021-03-23 13:51 ` Takashi Yano
2021-03-23 14:27 ` Corinna Vinschen
2021-03-23 12:44 ` Corinna Vinschen
2021-03-23 13:09 ` Jon Turney
2021-03-23 15:21 ` ASSI
2021-03-23 15:54 ` Corinna Vinschen
2021-03-23 19:45 ` Brian Inglis
2021-03-24 10:43 ` Marco Atzeri
2021-03-24 10:52 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323205717.bf5c3a41695871ec70bf1229@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).