From: Marco Atzeri <marco.atzeri@gmail.com>
To: cygwin-patches@cygwin.com, Jan Nijtmans <jan.nijtmans@gmail.com>
Subject: Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().
Date: Wed, 24 Mar 2021 11:43:57 +0100 [thread overview]
Message-ID: <78ac1b6e-c933-8b3a-9603-14d031f38b64@gmail.com> (raw)
In-Reply-To: <YFm+fEONY3wLq3Sp@calimero.vinschen.de>
On 23.03.2021 11:10, Corinna Vinschen wrote:
> [CC Marco, CC Jan]
>
>
>> Out of curiosity, I took a quick glance at the cmake code. It appears that
>> this code is designed to support running cmake in a Console. I don't think
>> that should be needed any more, if it ever was.
>> [...]
>> I think the following might suffice (untested):
>>
>> --- a/Source/kwsys/Terminal.c
>> +++ b/Source/kwsys/Terminal.c
>> @@ -10,7 +10,7 @@
>> #endif
>>
>> /* Configure support for this platform. */
>> -#if defined(_WIN32) || defined(__CYGWIN__)
>> +#if defined(_WIN32)
>> # define KWSYS_TERMINAL_SUPPORT_CONSOLE
>> #endif
>> #if !defined(_WIN32)
noted.
cmake was always annoying, we remove this type of define and they add
somewhere else
> Looks right to me. If we patch cmake to do the right thing, do we still
> need this patch, Takashi?
>
>
> Thanks,
> Corinna
Regards
Marco
next prev parent reply other threads:[~2021-03-24 10:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 4:01 Takashi Yano
2021-03-21 4:01 ` [PATCH 1/2] Cygwin: syscalls.cc: Make _get_osfhandle() return appropriate handle Takashi Yano
2021-03-21 4:01 ` [PATCH 2/2] Cygwin: pty: Add hook for GetStdHandle() to " Takashi Yano
2021-03-21 8:44 ` [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle() Takashi Yano
2021-03-21 23:07 ` Takashi Yano
2021-03-22 11:43 ` Corinna Vinschen
2021-03-22 17:02 ` Ken Brown
2021-03-23 10:10 ` Corinna Vinschen
2021-03-23 11:57 ` Takashi Yano
2021-03-23 12:17 ` Corinna Vinschen
2021-03-23 12:32 ` Takashi Yano
2021-03-23 12:42 ` Takashi Yano
2021-03-23 12:46 ` Corinna Vinschen
2021-03-23 12:52 ` Takashi Yano
2021-03-23 13:32 ` Corinna Vinschen
2021-03-23 13:51 ` Takashi Yano
2021-03-23 14:27 ` Corinna Vinschen
2021-03-23 12:44 ` Corinna Vinschen
2021-03-23 13:09 ` Jon Turney
2021-03-23 15:21 ` ASSI
2021-03-23 15:54 ` Corinna Vinschen
2021-03-23 19:45 ` Brian Inglis
2021-03-24 10:43 ` Marco Atzeri [this message]
2021-03-24 10:52 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78ac1b6e-c933-8b3a-9603-14d031f38b64@gmail.com \
--to=marco.atzeri@gmail.com \
--cc=cygwin-patches@cygwin.com \
--cc=jan.nijtmans@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).