From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().
Date: Tue, 23 Mar 2021 13:44:39 +0100 [thread overview]
Message-ID: <YFnit7OtFJeflMQT@calimero.vinschen.de> (raw)
In-Reply-To: <20210323213212.d2c5a9e7db7a508260693998@nifty.ne.jp>
On Mar 23 21:32, Takashi Yano via Cygwin-patches wrote:
> On Tue, 23 Mar 2021 13:17:16 +0100
> Corinna Vinschen wrote:
> > On Mar 23 20:57, Takashi Yano via Cygwin-patches wrote:
> > > Corinna Vinschen wrote:
> > > > > > On Mar 22 08:07, Takashi Yano via Cygwin-patches wrote:
> > > > > > > > And also, following cygwin apps/dlls call GetStdHandle():
> > > > > > > > ccmake.exe
> > > > > > > > cmake.exe
> > > > > > > > cpack.exe
> > > > > > > > ctest.exe
> > > > > > > > run.exe
> > > >
> > > > run creates its own conin/conout handles to create a hidden console.
> > > > The code calling GetStdHandle() is only for debug purposes and never
> > > > built into the executable.
> >
> > Sorry, but this was utterly wrong. run calls GetStdHandle, then
> > overwrites the handles, but only if it doesn't already is attached to a
> > console.
> >
> > > > Looks right to me. If we patch cmake to do the right thing, do we still
> > > > need this patch, Takashi?
> > >
> > > I don't think so. If all is well with current code, nothing to be fixed.
> >
> > How do you evaluate this in light of the run behaviour above?
>
> I try to check run.exe behaviour and noticed that
> run cmd.exe
> and
> run cat.exe
> does not work with cygwin 3.0.7 and 3.2.0 (TEST) while these
> work in 3.1.7.
>
> Is this expected behaviour?
The problem is that I never used run. I can't actually tell what
exactly is expected. I *think* run was intended to start Cygwin
applications without console window in the first place, not
native Windows apps, but I could be wrong.
I don't even know if anybody is actually, seriously using it.
The biggest problem with run is probably that it's unmaintained for
a long time, and seeing code comments like
/* Note: we do it this way instead of using GetConsoleWindow()
* because we want it to work on < w2k.
*/
doesn't actually make me confident in its viability for any purpose...
Corinna
next prev parent reply other threads:[~2021-03-23 12:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 4:01 Takashi Yano
2021-03-21 4:01 ` [PATCH 1/2] Cygwin: syscalls.cc: Make _get_osfhandle() return appropriate handle Takashi Yano
2021-03-21 4:01 ` [PATCH 2/2] Cygwin: pty: Add hook for GetStdHandle() to " Takashi Yano
2021-03-21 8:44 ` [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle() Takashi Yano
2021-03-21 23:07 ` Takashi Yano
2021-03-22 11:43 ` Corinna Vinschen
2021-03-22 17:02 ` Ken Brown
2021-03-23 10:10 ` Corinna Vinschen
2021-03-23 11:57 ` Takashi Yano
2021-03-23 12:17 ` Corinna Vinschen
2021-03-23 12:32 ` Takashi Yano
2021-03-23 12:42 ` Takashi Yano
2021-03-23 12:46 ` Corinna Vinschen
2021-03-23 12:52 ` Takashi Yano
2021-03-23 13:32 ` Corinna Vinschen
2021-03-23 13:51 ` Takashi Yano
2021-03-23 14:27 ` Corinna Vinschen
2021-03-23 12:44 ` Corinna Vinschen [this message]
2021-03-23 13:09 ` Jon Turney
2021-03-23 15:21 ` ASSI
2021-03-23 15:54 ` Corinna Vinschen
2021-03-23 19:45 ` Brian Inglis
2021-03-24 10:43 ` Marco Atzeri
2021-03-24 10:52 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFnit7OtFJeflMQT@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).