From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH] Ensure PSAPI_VERSION is 1 when building ldd
Date: Thu, 20 May 2021 18:46:35 +0100 [thread overview]
Message-ID: <20210520174635.24163-1-jon.turney@dronecode.org.uk> (raw)
The default PSAPI_VERSION is controlled by WIN32_WINNT, which we set to
0x0a00 when building ldd, which gets PSAPI_VERSION=2.
This causes K32GetModuleFileNameEx to be used for GetFileNameFromHandle,
which isn't available on Windows Vista.
Define PSAPI_VERSION as 1 for the built executable to work on Windows
Vista.
---
winsup/utils/ldd.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/winsup/utils/ldd.cc b/winsup/utils/ldd.cc
index 1e1863c1c..d370db986 100644
--- a/winsup/utils/ldd.cc
+++ b/winsup/utils/ldd.cc
@@ -38,6 +38,7 @@
#include <libgen.h>
#define _WIN32_WINNT 0x0a00
+#define PSAPI_VERSION 1
#include <windows.h>
#include <winternl.h>
#include <imagehlp.h>
--
2.31.1
next reply other threads:[~2021-05-20 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 17:46 Jon Turney [this message]
2021-05-20 18:05 ` Corinna Vinschen
2021-05-22 15:08 ` Jon Turney
2021-05-25 21:37 ` Jon Turney
2021-05-26 9:04 ` Corinna Vinschen
2021-05-26 16:51 ` Jon Turney
2021-05-26 17:04 ` Yaakov Selkowitz
2021-05-26 19:18 ` Corinna Vinschen
2021-05-27 17:30 ` Jon Turney
2021-05-27 19:08 ` Corinna Vinschen
2021-05-28 15:13 ` Jon Turney
2021-06-20 13:37 ` [PATCH] Define PSAPI_VERSION as 1 before including psapi.h Jon Turney
2021-07-06 13:55 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520174635.24163-1-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).