From: Yaakov Selkowitz <yselkowitz@cygwin.com>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Ensure PSAPI_VERSION is 1 when building ldd
Date: Wed, 26 May 2021 13:04:53 -0400 [thread overview]
Message-ID: <b3286aea4562bbd9b705060b44892c8fbc3e4a2c.camel@cygwin.com> (raw)
In-Reply-To: <104966fe-2e78-c28f-dcbe-53af7221f117@dronecode.org.uk>
On Wed, 2021-05-26 at 17:51 +0100, Jon Turney wrote:
> On 26/05/2021 10:04, Corinna Vinschen wrote:
> > On May 25 22:37, Jon Turney wrote:
> > > On 22/05/2021 16:08, Jon Turney wrote:
> > > > On 20/05/2021 19:05, Corinna Vinschen wrote:
> > > > > Hi Jon,
> > > > >
> > > > > On May 20 18:46, Jon Turney wrote:
> > > > > > The default PSAPI_VERSION is controlled by WIN32_WINNT, which we
> > > > > > set to
> > > > > > 0x0a00 when building ldd, which gets PSAPI_VERSION=2.
> > >
> > > In the just released w32api 9.0.0, _WIN32_WINNT is now set to 0xa00 by
> > > default, so this issue is probably going to surface in a few other
> > > places as
> > > well.
> >
> > I added _WIN32_WINNT and NTDDI_VERSION settings to make sure we notice
> > any problems right away.
>
> I'm not sure what the mechanism by which we're going to notice is?
>
> Adding WIN32_WINNT=0x0a00 everywhere changes the meaning of '#include
> <psapi.h>' in a way that is incompatible with Vista.
>
> So this has broken dumper, and possibly other utils, on Vista.
>
> I don't know if there are any other imports in other header which also
> have this annoying behaviour...
Does Vista REALLY still need to be supported at this point?
--
Yaakov
next prev parent reply other threads:[~2021-05-26 17:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 17:46 Jon Turney
2021-05-20 18:05 ` Corinna Vinschen
2021-05-22 15:08 ` Jon Turney
2021-05-25 21:37 ` Jon Turney
2021-05-26 9:04 ` Corinna Vinschen
2021-05-26 16:51 ` Jon Turney
2021-05-26 17:04 ` Yaakov Selkowitz [this message]
2021-05-26 19:18 ` Corinna Vinschen
2021-05-27 17:30 ` Jon Turney
2021-05-27 19:08 ` Corinna Vinschen
2021-05-28 15:13 ` Jon Turney
2021-06-20 13:37 ` [PATCH] Define PSAPI_VERSION as 1 before including psapi.h Jon Turney
2021-07-06 13:55 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3286aea4562bbd9b705060b44892c8fbc3e4a2c.camel@cygwin.com \
--to=yselkowitz@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).