public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Ensure PSAPI_VERSION is 1 when building ldd
Date: Thu, 20 May 2021 20:05:56 +0200	[thread overview]
Message-ID: <YKalBKpjhBx6mZBg@calimero.vinschen.de> (raw)
In-Reply-To: <20210520174635.24163-1-jon.turney@dronecode.org.uk>

Hi Jon,

On May 20 18:46, Jon Turney wrote:
> The default PSAPI_VERSION is controlled by WIN32_WINNT, which we set to
> 0x0a00 when building ldd, which gets PSAPI_VERSION=2.
> 
> This causes K32GetModuleFileNameEx to be used for GetFileNameFromHandle,
> which isn't available on Windows Vista.

Patch is ok, but the description needs a tweak.  GetModuleFileNameEx is
called from load_dll and print_dll, not from GetFileNameFromHandle.

In terms of GetFileNameFromHandle, given the GetFinalPathNameByHandle
function is availabe since Vista, we should probably go ahead and use
it in ldd.cc, too.


Thanks,
Corinna

  reply	other threads:[~2021-05-20 18:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 17:46 Jon Turney
2021-05-20 18:05 ` Corinna Vinschen [this message]
2021-05-22 15:08   ` Jon Turney
2021-05-25 21:37     ` Jon Turney
2021-05-26  9:04       ` Corinna Vinschen
2021-05-26 16:51         ` Jon Turney
2021-05-26 17:04           ` Yaakov Selkowitz
2021-05-26 19:18             ` Corinna Vinschen
2021-05-27 17:30               ` Jon Turney
2021-05-27 19:08                 ` Corinna Vinschen
2021-05-28 15:13                   ` Jon Turney
2021-06-20 13:37                     ` [PATCH] Define PSAPI_VERSION as 1 before including psapi.h Jon Turney
2021-07-06 13:55                       ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKalBKpjhBx6mZBg@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).