From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: console: Make the console accessible from other terminals.
Date: Wed, 21 Dec 2022 19:23:43 +0900 [thread overview]
Message-ID: <20221221192343.32699d22e6d113ce9195de8f@nifty.ne.jp> (raw)
In-Reply-To: <Y6ItllXJ8J20cEbp@calimero.vinschen.de>
On Tue, 20 Dec 2022 22:48:06 +0100
Corinna Vinschen wrote:
> On Dec 20 21:45, Takashi Yano wrote:
> > Previously, the console device could not be accessed from other terminals.
> > Due to this limitation, GNU screen and tmux cannot be opened in console.
> > With this patch, console device can be accessed from other TTYs, such as
> > other consoles or ptys. Thanks to this patch, screen and tmux get working
> > in console.
> >
> > Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
> > ---
> > winsup/cygwin/devices.cc | 24 +-
> > winsup/cygwin/devices.in | 24 +-
> > winsup/cygwin/fhandler/console.cc | 438 +++++++++++++++++-------
> > winsup/cygwin/fhandler/pty.cc | 4 +-
> > winsup/cygwin/local_includes/fhandler.h | 26 +-
> > winsup/cygwin/local_includes/winsup.h | 1 -
> > winsup/cygwin/select.cc | 2 +
> > 7 files changed, 382 insertions(+), 137 deletions(-)
>
> I just toyed around with screen and this looks really great.
>
> Just one question: What about security? If we now can share
> consoles, don't we need fchmod/fchown calls, too?
Thanks for reviewing.
As for security, AttachConsole() for another user's process
will failed with ERROR_ACCESS_DENIED, so the console of
another user is inaccessible.
However, fstat() does not return appropriate information,
so, I implemented fhandler_console::fstat(). I also set proper
errno for that case. Please see v2 patch.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2022-12-21 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 12:45 Takashi Yano
2022-12-20 21:48 ` Corinna Vinschen
2022-12-21 10:23 ` Takashi Yano [this message]
2022-12-21 10:28 ` Takashi Yano
2022-12-21 12:56 ` Corinna Vinschen
2022-12-22 9:06 ` Takashi Yano
2022-12-22 12:15 ` Takashi Yano
2022-12-22 12:50 ` Corinna Vinschen
2022-12-22 13:12 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221192343.32699d22e6d113ce9195de8f@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).