Re: [PATCH] Cygwin: console: Make the console accessible from other terminals.

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Dec 20 21:45, Takashi Yano wrote:
> Previously, the console device could not be accessed from other terminals.
> Due to this limitation, GNU screen and tmux cannot be opened in console.
> With this patch, console device can be accessed from other TTYs, such as
> other consoles or ptys. Thanks to this patch, screen and tmux get working
> in console.
> 
> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
> ---
>  winsup/cygwin/devices.cc                |  24 +-
>  winsup/cygwin/devices.in                |  24 +-
>  winsup/cygwin/fhandler/console.cc       | 438 +++++++++++++++++-------
>  winsup/cygwin/fhandler/pty.cc           |   4 +-
>  winsup/cygwin/local_includes/fhandler.h |  26 +-
>  winsup/cygwin/local_includes/winsup.h   |   1 -
>  winsup/cygwin/select.cc                 |   2 +
>  7 files changed, 382 insertions(+), 137 deletions(-)

I just toyed around with screen and this looks really great.

Just one question: What about security?  If we now can share
consoles, don't we need fchmod/fchown calls, too?


Thanks,
Corinna