public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: console: Make the console accessible from other terminals.
Date: Thu, 22 Dec 2022 18:06:03 +0900	[thread overview]
Message-ID: <20221222180603.9a8dedadfee6c59cdf073e36@nifty.ne.jp> (raw)
In-Reply-To: <Y6MCeRdiRCJAQMbV@calimero.vinschen.de>

On Wed, 21 Dec 2022 13:56:25 +0100
Corinna Vinschen wrote:
> However, there's something broken with these patches in terms of
> debugging:
> 
> With current origin/master:
> 
>   $ ls -l  /dev/cons0
>   crw-rw-rw- 4 corinna vinschen 3, 0 Dec 21 13:46 /dev/cons0
>   $ strace -o xxx /bin/ls /dev/cons0
>   /dev/cons0
> 
> After applying "pinfo: Align CTTY behavior to the statement of POSIX."
> 
>   $ ls -l /dev/cons0
>   crw-rw-rw- 4 corinna vinschen 3, 0 Dec 21 13:51 /dev/cons0
>   $ strace -o xxx /bin/ls /dev/cons0
>   /usr/bin/ls: cannot access '/dev/cons0': No such device or address
> 
> "devices: Make generic console devices invisible from pty." doesn't
> change this, but after applying "console: Make the console accessible
> from other terminals.":
> 
>   $ ls -l /dev/cons0
>   crw------- 4 corinna vinschen 3, 0 Dec 21 13:55 /dev/cons0
>   $ strace -o xxx /bin/ls /dev/cons0
>    670400 [main] ls 1630 C:\cygwin64\bin\ls.exe: *** fatal error - MapViewOfFileEx '(null)'(0x54), Win32 error 487.  Terminating.
>    674526 [main] ls 1630 cygwin_exception::open_stackdumpfile: Dumping stack trace to ls.exe.stackdump
> 
> FWIW:
> 
>   $ strace -o xxx /bin/ls
>    673796 [main] ls 1633 C:\cygwin64\bin\ls.exe: *** fatal error - MapViewOfFileEx '(null)'(0x54), Win32 error 487.  Terminating.
>    676814 [main] ls 1633 cygwin_exception::open_stackdumpfile: Dumping stack trace to ls.exe.stackdump

Thank you for finding this. I think this can be easily fixed.
Please see v3 patch.

[PATCH v3] Cygwin: pinfo: Align CTTY behavior to the statement of POSIX.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

  reply	other threads:[~2022-12-22  9:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 12:45 Takashi Yano
2022-12-20 21:48 ` Corinna Vinschen
2022-12-21 10:23   ` Takashi Yano
2022-12-21 10:28     ` Takashi Yano
2022-12-21 12:56     ` Corinna Vinschen
2022-12-22  9:06       ` Takashi Yano [this message]
2022-12-22 12:15         ` Takashi Yano
2022-12-22 12:50         ` Corinna Vinschen
2022-12-22 13:12           ` Takashi Yano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221222180603.9a8dedadfee6c59cdf073e36@nifty.ne.jp \
    --to=takashi.yano@nifty.ne.jp \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).