public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 00/11] More testsuite fixes
Date: Thu, 13 Jul 2023 12:38:53 +0100	[thread overview]
Message-ID: <20230713113904.1752-1-jon.turney@dronecode.org.uk> (raw)

This gets us from :

FAIL: cygload
FAIL: devdsp.c
FAIL: ltp/access05.c
FAIL: ltp/fcntl07.c
FAIL: ltp/symlink01.c
FAIL: ltp/symlink03.c
FAIL: ltp/umask03.c
FAIL: pthread/cancel11.c
FAIL: pthread/cancel3.c
FAIL: pthread/cancel5.c
FAIL: pthread/inherit1.c
FAIL: pthread/priority1.c
FAIL: pthread/priority2.c
FAIL: systemcall.c

to:

FAIL: cygload
FAIL: devdsp.c
FAIL: ltp/umask03.c
FAIL: pthread/cancel11.c
FAIL: pthread/priority1.c

Notes on the remaining failures:

cygload: I have no idea of the voodoo needed to make this work

devdsp: forkplaytest() is broken in some complex way I don't understand, causing a hang. It looks like the child 
process doesn't exit, which must be a bug in Cygwin?

devdsp: it's totally unclear to me if opening /dev/dsp twice is meant to be allowed or not

umask03: was utterly broken, now fails, but accurately reports the failure. I don't quite understand the 
permissions issue which is causing it to fail.

cancel11: some funkiness I can't work out, causing the save/restoring signal handlers around system() to not 
work correctly

priority1: this looks like a bug with pthread_create() and a non-null pthread_attr_t *, for which I'll send a 
patch shortly.

Jon Turney (11):
  Cygwin: testsuite: Setup test prereqs in 'installation' the tests run
    in
  Cygwin: testsuite: Add a simple timeout mechanism
  Cygwin: testsuite: Remove const from writable string in fcntl07b
  Cygwin: testsuite: Skip devdsp test when no audio devices present
  Cygwin: testsuite: Just log result of second open of /dev/dsp
  Cygwin: testsuite: Also check direct call in systemcall
  Cygwin: testsuite: Fix for limited thread priority values
  Cygwin: testsuite: Busy-wait in cancel3 and cancel5
  Cygwin: testsuite: Fix a buffer overflow in symlink01
  Cygwin: testsuite: Minor fixes to umask03
  Cygwin: testsuite: Drop Adminstrator privileges while running tests

 .github/workflows/cygwin.yml                  |  4 ++-
 winsup/cygwin/Makefile.am                     |  4 +--
 winsup/doc/faq-programming.xml                |  4 ++-
 winsup/testsuite/Makefile.am                  | 28 ++++++++++++++-
 winsup/testsuite/cygrun.c                     | 17 +++++++--
 winsup/testsuite/winsup.api/devdsp.c          | 35 +++++++++++--------
 winsup/testsuite/winsup.api/ltp/fcntl07B.c    |  2 +-
 winsup/testsuite/winsup.api/ltp/symlink01.c   |  2 +-
 winsup/testsuite/winsup.api/ltp/umask03.c     | 21 ++++++-----
 winsup/testsuite/winsup.api/pthread/cancel3.c | 24 +++++++++----
 winsup/testsuite/winsup.api/pthread/cancel5.c | 24 +++++++++----
 .../testsuite/winsup.api/pthread/inherit1.c   | 21 ++++++++++-
 .../testsuite/winsup.api/pthread/priority1.c  | 24 +++++++++++--
 .../testsuite/winsup.api/pthread/priority2.c  | 22 ++++++++++--
 winsup/testsuite/winsup.api/systemcall.c      | 10 +++++-
 winsup/testsuite/winsup.api/winsup.exp        |  2 +-
 16 files changed, 194 insertions(+), 50 deletions(-)

-- 
2.39.0


             reply	other threads:[~2023-07-13 11:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 11:38 Jon Turney [this message]
2023-07-13 11:38 ` [PATCH 01/11] Cygwin: testsuite: Setup test prereqs in 'installation' the tests run in Jon Turney
2023-07-13 11:38 ` [PATCH 02/11] Cygwin: testsuite: Add a simple timeout mechanism Jon Turney
2023-07-13 11:38 ` [PATCH 03/11] Cygwin: testsuite: Remove const from writable string in fcntl07b Jon Turney
2023-07-13 11:38 ` [PATCH 04/11] Cygwin: testsuite: Skip devdsp test when no audio devices present Jon Turney
2023-07-13 11:38 ` [PATCH 05/11] Cygwin: testsuite: Just log result of second open of /dev/dsp Jon Turney
2023-07-13 11:38 ` [PATCH 06/11] Cygwin: testsuite: Also check direct call in systemcall Jon Turney
2023-07-13 11:39 ` [PATCH 07/11] Cygwin: testsuite: Fix for limited thread priority values Jon Turney
2023-07-13 11:39 ` [PATCH 08/11] Cygwin: testsuite: Busy-wait in cancel3 and cancel5 Jon Turney
2023-07-13 11:43   ` Jon Turney
2023-07-13 18:16   ` Corinna Vinschen
2023-07-13 18:37     ` Corinna Vinschen
2023-07-13 18:53       ` Corinna Vinschen
2023-07-14 13:04         ` Jon Turney
2023-07-14 18:57           ` Corinna Vinschen
2023-07-17 11:05             ` Corinna Vinschen
2023-07-17 11:51               ` Jon Turney
2023-07-17 14:21                 ` Corinna Vinschen
2023-07-17 15:41                   ` Corinna Vinschen
2023-07-17 18:23                     ` Corinna Vinschen
2023-07-18 11:20                     ` Jon Turney
2023-07-18 12:09                       ` Corinna Vinschen
2023-07-18 15:52                         ` Jon Turney
2023-07-17 11:51           ` Jon Turney
2023-07-17 14:04             ` Corinna Vinschen
2023-07-17 14:22               ` Corinna Vinschen
2023-07-13 11:39 ` [PATCH 09/11] Cygwin: testsuite: Fix a buffer overflow in symlink01 Jon Turney
2023-07-13 18:17   ` Corinna Vinschen
2023-07-14 13:04     ` Jon Turney
2023-07-13 11:39 ` [PATCH 10/11] Cygwin: testsuite: Minor fixes to umask03 Jon Turney
2023-07-13 18:18   ` Corinna Vinschen
2023-07-13 11:39 ` [PATCH 11/11] Cygwin: testsuite: Drop Adminstrator privileges while running tests Jon Turney
2023-07-13 18:05 ` [PATCH 00/11] More testsuite fixes Corinna Vinschen
2023-07-17 11:58 ` Jon Turney
2023-07-17 14:02   ` Corinna Vinschen
2023-07-18 13:37     ` Jon Turney
2023-07-18 14:52       ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230713113904.1752-1-jon.turney@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).