From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 05/11] Cygwin: testsuite: Just log result of second open of /dev/dsp
Date: Thu, 13 Jul 2023 12:38:58 +0100 [thread overview]
Message-ID: <20230713113904.1752-6-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20230713113904.1752-1-jon.turney@dronecode.org.uk>
Do not rate successful second open of /dev/dsp as an error, just log the
result.
Based on this patch by Gerd Spalink:
https://cygwin.com/pipermail/cygwin-patches/2004q3/004848.html
---
winsup/testsuite/winsup.api/devdsp.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/winsup/testsuite/winsup.api/devdsp.c b/winsup/testsuite/winsup.api/devdsp.c
index 0ac76f085..de3ccfa19 100644
--- a/winsup/testsuite/winsup.api/devdsp.c
+++ b/winsup/testsuite/winsup.api/devdsp.c
@@ -170,15 +170,11 @@ playbacktest (void)
strerror (errno));
}
audio2 = open ("/dev/dsp", O_WRONLY);
+ tst_resm (TINFO, "Second open /dev/dsp W %s ",
+ audio2 >= 0 ? "WORKS" : "DOESN'T WORK");
if (audio2 >= 0)
{
- tst_brkm (TFAIL, cleanup,
- "Second open /dev/dsp W succeeded, but is expected to fail");
- }
- else if (errno != EBUSY)
- {
- tst_brkm (TFAIL, cleanup, "Expected EBUSY here, exit: %s",
- strerror (errno));
+ close (audio2);
}
for (rate = 0; rate < sizeof (rates) / sizeof (int); rate++)
for (k = 0; k < sizeof (sblut) / sizeof (struct sb); k++)
@@ -209,15 +205,11 @@ recordingtest (void)
strerror (errno));
}
audio2 = open ("/dev/dsp", O_RDONLY);
+ tst_resm (TINFO, "Second open /dev/dsp R %s",
+ audio2 >= 0 ? "WORKS" : "DOESN'T WORK");
if (audio2 >= 0)
{
- tst_brkm (TFAIL, cleanup,
- "Second open /dev/dsp R succeeded, but is expected to fail");
- }
- else if (errno != EBUSY)
- {
- tst_brkm (TFAIL, cleanup, "Expected EBUSY here, exit: %s",
- strerror (errno));
+ close (audio2);
}
for (rate = 0; rate < sizeof (rates) / sizeof (int); rate++)
for (k = 0; k < sizeof (sblut) / sizeof (struct sb); k++)
--
2.39.0
next prev parent reply other threads:[~2023-07-13 11:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 11:38 [PATCH 00/11] More testsuite fixes Jon Turney
2023-07-13 11:38 ` [PATCH 01/11] Cygwin: testsuite: Setup test prereqs in 'installation' the tests run in Jon Turney
2023-07-13 11:38 ` [PATCH 02/11] Cygwin: testsuite: Add a simple timeout mechanism Jon Turney
2023-07-13 11:38 ` [PATCH 03/11] Cygwin: testsuite: Remove const from writable string in fcntl07b Jon Turney
2023-07-13 11:38 ` [PATCH 04/11] Cygwin: testsuite: Skip devdsp test when no audio devices present Jon Turney
2023-07-13 11:38 ` Jon Turney [this message]
2023-07-13 11:38 ` [PATCH 06/11] Cygwin: testsuite: Also check direct call in systemcall Jon Turney
2023-07-13 11:39 ` [PATCH 07/11] Cygwin: testsuite: Fix for limited thread priority values Jon Turney
2023-07-13 11:39 ` [PATCH 08/11] Cygwin: testsuite: Busy-wait in cancel3 and cancel5 Jon Turney
2023-07-13 11:43 ` Jon Turney
2023-07-13 18:16 ` Corinna Vinschen
2023-07-13 18:37 ` Corinna Vinschen
2023-07-13 18:53 ` Corinna Vinschen
2023-07-14 13:04 ` Jon Turney
2023-07-14 18:57 ` Corinna Vinschen
2023-07-17 11:05 ` Corinna Vinschen
2023-07-17 11:51 ` Jon Turney
2023-07-17 14:21 ` Corinna Vinschen
2023-07-17 15:41 ` Corinna Vinschen
2023-07-17 18:23 ` Corinna Vinschen
2023-07-18 11:20 ` Jon Turney
2023-07-18 12:09 ` Corinna Vinschen
2023-07-18 15:52 ` Jon Turney
2023-07-17 11:51 ` Jon Turney
2023-07-17 14:04 ` Corinna Vinschen
2023-07-17 14:22 ` Corinna Vinschen
2023-07-13 11:39 ` [PATCH 09/11] Cygwin: testsuite: Fix a buffer overflow in symlink01 Jon Turney
2023-07-13 18:17 ` Corinna Vinschen
2023-07-14 13:04 ` Jon Turney
2023-07-13 11:39 ` [PATCH 10/11] Cygwin: testsuite: Minor fixes to umask03 Jon Turney
2023-07-13 18:18 ` Corinna Vinschen
2023-07-13 11:39 ` [PATCH 11/11] Cygwin: testsuite: Drop Adminstrator privileges while running tests Jon Turney
2023-07-13 18:05 ` [PATCH 00/11] More testsuite fixes Corinna Vinschen
2023-07-17 11:58 ` Jon Turney
2023-07-17 14:02 ` Corinna Vinschen
2023-07-18 13:37 ` Jon Turney
2023-07-18 14:52 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713113904.1752-6-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).