From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 00/11] More testsuite fixes
Date: Mon, 17 Jul 2023 16:02:45 +0200 [thread overview]
Message-ID: <ZLVKBcPUlt18BQoJ@calimero.vinschen.de> (raw)
In-Reply-To: <0a9d6f10-f26c-faf2-6fa1-c6a055570f5a@dronecode.org.uk>
Hi Jon,
On Jul 17 12:58, Jon Turney wrote:
> On 13/07/2023 12:38, Jon Turney wrote:
> >
> > cancel11: some funkiness I can't work out, causing the save/restoring signal handlers around system() to not
> > work correctly
>
> So, the test here: is the SIGINT handle restored correctly if the thread
> executing system() is cancelled. This test fails, because it's not.
>
> It seems like that scenario was explicitly considered when this test was
> added in https://cygwin.com/pipermail/cygwin-patches/2003q1/003378.html
>
> I think maybe this is a regression introduced in https://cygwin.com/cgit/newlib-cygwin/commit/?id=3cb9da14617c58c2821c80d48f0bd80a2deb5fdf
>
> child_info_spawn::worker calls waitpid() which ultimately calls cygwait()
> which notices the thread's cancel event is signalled and acts as a
> cancellation point.
>
> Attached is a patch which adds back the restoration of signal handlers on
> thread cancellation.
>
> I can't find any hints in the mailing lists around 2013-04 about what
> problem that change is fixing, but given the commentary, this might be
> reintroducing another problem, though.
Maybe, but the patch is slim enough so we might get away with it.
> From a798750d271e20402a0a5efc4ac073f5948ad5b7 Mon Sep 17 00:00:00 2001
> From: Jon Turney <jon.turney@dronecode.org.uk>
> Date: Sun, 16 Jul 2023 14:46:00 +0100
> Subject: [PATCH] Cygwin: Restore pthread cleanup of signal handlers during
> system()
>
> Removed in 3cb9da14 which describes it as 'ill-advised' (additional
> context doesn't appear to be available).
Actually, "ill-conceived". Beats my why, though.
> We can't neatly tuck the pthread_cleanup_push/pop inside the object, as
> they are implemented as macros which must appear in the same lexical
> scope.
You could do it if you call the underlying functions instead.
pthread_cleanup_push is just a convenience macro which initializes a
local __pthread_cleanup_handler, see include/pthread.h. If you add a
__pthread_cleanup_handler to system_call_handle, you could use it the
same way as the macro and encapsulate the whole thing inside the object.
If you want to...
Fixes and Signed-off-by tags?
Thanks,
Corinna
next prev parent reply other threads:[~2023-07-17 14:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 11:38 Jon Turney
2023-07-13 11:38 ` [PATCH 01/11] Cygwin: testsuite: Setup test prereqs in 'installation' the tests run in Jon Turney
2023-07-13 11:38 ` [PATCH 02/11] Cygwin: testsuite: Add a simple timeout mechanism Jon Turney
2023-07-13 11:38 ` [PATCH 03/11] Cygwin: testsuite: Remove const from writable string in fcntl07b Jon Turney
2023-07-13 11:38 ` [PATCH 04/11] Cygwin: testsuite: Skip devdsp test when no audio devices present Jon Turney
2023-07-13 11:38 ` [PATCH 05/11] Cygwin: testsuite: Just log result of second open of /dev/dsp Jon Turney
2023-07-13 11:38 ` [PATCH 06/11] Cygwin: testsuite: Also check direct call in systemcall Jon Turney
2023-07-13 11:39 ` [PATCH 07/11] Cygwin: testsuite: Fix for limited thread priority values Jon Turney
2023-07-13 11:39 ` [PATCH 08/11] Cygwin: testsuite: Busy-wait in cancel3 and cancel5 Jon Turney
2023-07-13 11:43 ` Jon Turney
2023-07-13 18:16 ` Corinna Vinschen
2023-07-13 18:37 ` Corinna Vinschen
2023-07-13 18:53 ` Corinna Vinschen
2023-07-14 13:04 ` Jon Turney
2023-07-14 18:57 ` Corinna Vinschen
2023-07-17 11:05 ` Corinna Vinschen
2023-07-17 11:51 ` Jon Turney
2023-07-17 14:21 ` Corinna Vinschen
2023-07-17 15:41 ` Corinna Vinschen
2023-07-17 18:23 ` Corinna Vinschen
2023-07-18 11:20 ` Jon Turney
2023-07-18 12:09 ` Corinna Vinschen
2023-07-18 15:52 ` Jon Turney
2023-07-17 11:51 ` Jon Turney
2023-07-17 14:04 ` Corinna Vinschen
2023-07-17 14:22 ` Corinna Vinschen
2023-07-13 11:39 ` [PATCH 09/11] Cygwin: testsuite: Fix a buffer overflow in symlink01 Jon Turney
2023-07-13 18:17 ` Corinna Vinschen
2023-07-14 13:04 ` Jon Turney
2023-07-13 11:39 ` [PATCH 10/11] Cygwin: testsuite: Minor fixes to umask03 Jon Turney
2023-07-13 18:18 ` Corinna Vinschen
2023-07-13 11:39 ` [PATCH 11/11] Cygwin: testsuite: Drop Adminstrator privileges while running tests Jon Turney
2023-07-13 18:05 ` [PATCH 00/11] More testsuite fixes Corinna Vinschen
2023-07-17 11:58 ` Jon Turney
2023-07-17 14:02 ` Corinna Vinschen [this message]
2023-07-18 13:37 ` Jon Turney
2023-07-18 14:52 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLVKBcPUlt18BQoJ@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).