* cygwin/acl.h not included from sys/acl.h
[not found] <1165926610.11966611.1539851450039.ref@mail.yahoo.com>
@ 2018-10-18 8:31 ` matthew patton via cygwin
2018-10-18 9:06 ` Corinna Vinschen
0 siblings, 1 reply; 3+ messages in thread
From: matthew patton via cygwin @ 2018-10-18 8:31 UTC (permalink / raw)
To: cygwin
Many of the headers in 'sys' include their counterparts from 'cygwin'. Why is acl.h special? I see the comment on line 25 but I'm missing the point, I guess - not seeing the collisions.
'cygwin/acl.h' is a very important file. Granted I don't normally compile much from source under Cygwin but I was building my own (very slightly) modified RSYNC and stumbled across the missing dependency.
What is the correct solution if the 1-liner fix to sys/acl.h is not acceptable?
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cygwin/acl.h not included from sys/acl.h
2018-10-18 8:31 ` cygwin/acl.h not included from sys/acl.h matthew patton via cygwin
@ 2018-10-18 9:06 ` Corinna Vinschen
0 siblings, 0 replies; 3+ messages in thread
From: Corinna Vinschen @ 2018-10-18 9:06 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Oct 18 08:30, matthew patton via cygwin wrote:
> Many of the headers in 'sys' include their counterparts from 'cygwin'.
> Why is acl.h special? I see the comment on line 25 but I'm missing the
> point, I guess - not seeing the collisions.
Not collisions, namespace poisoning. cygwin/acl.h defines the
old Solaris macros and function calls, but a POSIX application
should be free to use functions like "acl" by itself.
> 'cygwin/acl.h' is a very important file.
No, it isn't, if you're using POSIX ACLs.
> Granted I don't normally
> compile much from source under Cygwin but I was building my own (very
> slightly) modified RSYNC and stumbled across the missing dependency.
>
> What is the correct solution if the 1-liner fix to sys/acl.h is not
> acceptable?
Build rsync with POSIX ACL support. It's already in the sources. It's
very likely that a simple autoconf (or autoreconf if you build from repo
sources) will do.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cygwin/acl.h not included from sys/acl.h
[not found] <1582687447.11951125.1539856293918.ref@mail.yahoo.com>
@ 2018-10-18 9:51 ` matthew patton via cygwin
0 siblings, 0 replies; 3+ messages in thread
From: matthew patton via cygwin @ 2018-10-18 9:51 UTC (permalink / raw)
To: cygwin
https://github.com/tuna/rsync/blob/master/configure.ac#L981
Looks like it was short-circuited to use Solaris ACLs. I'll send the RSYNC guys a patch.
Defeating the case statement does pick up Posix ACLs.
$ grep -i acl config.status
S["LIBS"]="-lacl "
D["HAVE_SYS_ACL_H"]=" 1"
D["HAVE_ACL_LIBACL_H"]=" 1"
D["HAVE_ACLSORT"]=" 1"
D["HAVE_LIBACL"]=" 1"
D["HAVE_POSIX_ACLS"]=" 1"
D["SUPPORT_ACLS"]=" 1
I don't know what the elegant solution is to intuit the need to include cygwin/acl.h if HAVE_SOLARIS_ACLS though.
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-18 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1165926610.11966611.1539851450039.ref@mail.yahoo.com>
2018-10-18 8:31 ` cygwin/acl.h not included from sys/acl.h matthew patton via cygwin
2018-10-18 9:06 ` Corinna Vinschen
[not found] <1582687447.11951125.1539856293918.ref@mail.yahoo.com>
2018-10-18 9:51 ` matthew patton via cygwin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).