public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: David Allsopp <David.Allsopp@cl.cam.ac.uk>,
	The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: Cygwin setup writing incorrect symlinks for native
Date: Fri, 7 Jan 2022 15:44:20 +0000	[thread overview]
Message-ID: <1afc3b10-e19d-5b97-4ca7-b143f3262e67@dronecode.org.uk> (raw)
In-Reply-To: <53ca12d5a17d43089bc38ef67e4cc858@metastack.com>

On 06/01/2022 16:45, David Allsopp wrote:
> Jon Turney wrote:
>> On 06/01/2022 10:46, David Allsopp wrote:
>>> Running Cygwin setup 2.912 with --symlink-type native (or
>>> CYGWIN=winsymlinks:native) is not correctly translating all symlinks.
>>> A default install has these faulty ones:
>>>
>>> /etc/pki/tls/cert.pem ->
>>> \??\/etc\pki\ca-trust\extracted\pem\tls-ca-bundle.pem
>>> /etc/pki/tls/certs/ca-bundle.crt ->
>>> \??\/etc\pki\ca-trust\extracted\pem\tls-ca-bundle.pem
>>> /etc/pki/tls/certs/ca-bundle.trust.crt ->
>>> \??\/etc\pki\ca-trust\extracted\openssl\ca-bundle.trust.crt
>>> /etc/ssl/certs -> \??\/etc\pki\tls\certs /lib/security/cacerts ->
>>> \??\/etc\pki\ca-trust\extracted\java\cacerts
>>> /usr/share/doc/groff-1.22.4/pdf/mom-pdf.pdf ->
>>> \??\/usr\share\doc\groff-1.22.4\examples\mom\mom-pdf.pdf
>>
>>
>> Thanks for reporting this.
>>
>> Yes, it seems this is messed up where the target of the symlink is an
>> absolute path.
>>
>> I've uploaded setup 2.913 with an attempted fix.
>>
>>     https://cygwin.com/setup/setup-2.913.x86_64.exe
>>     https://cygwin.com/setup/setup-2.913.x86.exe
>>
>> Please try that (you'll have to reinstall the effected packages), and see
>> if it improves things for you?
> 
> Thank you! This fixes it for the Cygwin side, although the symlinks are still technically not right from the Windows side. They're still showing up prefixed \??\.
> 
> It's an age since I mucked around with those functions - IIRC the API function for writing them adds the \??\ itself and doesn't expect it to have been supplied? However, when you read the reparse point you have to remember to remove it yourself because who needs consistency :o)

Thanks for testing.  It seems I still didn't have this quite right and 
these symlinks just happened to work for cygwin, but not native tools.

Please try

   https://cygwin.com/setup/setup-2.914.x86_64.exe
   https://cygwin.com/setup/setup-2.914.x86.exe

> C:\cygwin64>dir /s | findstr ??
> 01/06/2022  04:30 PM    <SYMLINK>      cert.pem [\??\C:\cygwin64\etc\pki\ca-trust\extracted\pem\tls-ca-bundle.pem]
> 01/06/2022  04:30 PM    <SYMLINK>      ca-bundle.crt [\??\C:\cygwin64\etc\pki\ca-trust\extracted\pem\tls-ca-bundle.pem]
> 01/06/2022  04:30 PM    <SYMLINK>      ca-bundle.trust.crt [\??\C:\cygwin64\etc\pki\ca-trust\extracted\openssl\ca-bundle.trust.crt]
> 01/06/2022  04:30 PM    <SYMLINKD>     certs [\??\C:\cygwin64\etc\pki\tls\certs]
> 01/06/2022  04:30 PM    <SYMLINK>      cacerts [\??\C:\cygwin64\etc\pki\ca-trust\extracted\java\cacerts]
> 01/06/2022  04:30 PM    <SYMLINK>      mom-pdf.pdf [\??\C:\cygwin64\usr\share\doc\groff-1.22.4\examples\mom\mom-pdf.pdf]

  reply	other threads:[~2022-01-07 15:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 10:46 David Allsopp
2022-01-06 16:05 ` Jon Turney
2022-01-06 16:45   ` David Allsopp
2022-01-07 15:44     ` Jon Turney [this message]
2022-01-09  9:35       ` David Allsopp
2022-01-10 15:39         ` Jon Turney
2022-01-12 16:03           ` David Allsopp
2022-01-12 16:18             ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1afc3b10-e19d-5b97-4ca7-b143f3262e67@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=David.Allsopp@cl.cam.ac.uk \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).