From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Cygwin fails to utilize Unicode replacement character
Date: Fri, 07 Sep 2018 18:20:00 -0000 [thread overview]
Message-ID: <20180907182028.GW6350@calimero.vinschen.de> (raw)
In-Reply-To: <1b170781-d54d-1d71-689d-e2efb4aed9cb@SystematicSw.ab.ca>
[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]
On Sep 7 10:48, Brian Inglis wrote:
> On 2018-09-07 05:54, Corinna Vinschen wrote:
> > On Sep 7 13:51, Thomas Wolff wrote:
> >> On 07.09.2018 13:41, Thomas Wolff wrote:
> >>> On 07.09.2018 13:29, Corinna Vinschen wrote:
> >>>> On Sep 7 12:34, Thomas Wolff wrote:
> >>>>> On 07.09.2018 10:17, Corinna Vinschen wrote:
> >>>>>> On Sep 6 09:01, Corinna Vinschen wrote:
> >>>>>>> https://cygwin.com/ml/cygwin-cvs/2018-q3/msg00054.html
> >>>>>> I created new developer snapshots for testing. Please give the latest fromhttps://cygwin.com/snapshots/ a try.
> >>>>> Raster Fonts: output of invalid encoding hangs cygwin...
> >>>>>> This will be my last action for the next 4 weeks though. I'll be
> >>>>>> back in October.
> >>>> Looks like s/ANSI_CHARSET/DEFAULT_CHARSET/ does the trick
> >>> Without this change, lf.lfFaceName is "T" when entering the do...while
> >>> loop.
> >> No, sorry, it's "Terminal" initially and then shortened down to "T" by one
> >> char each in the loop.
> >>> What's the purpose of this nested loop (do...while and EnumFontFamilies)
> >>> anyway?
> > The loop is handling the weird DejaVu Sans Mono behaviour I explained
> > in previous mail.
>
> Garbage in font name from uninit struct on stack?
> Before call bzero/memset/implicit:
>
> - CONSOLE_FONT_INFOEX cfi;
> + CONSOLE_FONT_INFOEX cfi = { 0 };
No, that doesn't help. Do you really think I didn't try this? Think
about it. The string returned by GetCurrentConsoleFontEx is supposed to
be \0-terminated. If the \0 follows *after* the stray characters, where
would they come from if not created by the GetCurrentConsoleFontEx
function itself?
> and remove loop, which opens an attack vector by renaming a good font
> and substituting one with a shorter name, or could cause problems by
> using the wrong font e.g DejaVu Sans.
How so?
> You need to self-impose a change freeze before heading out, once you're in
> "stuff to get done before leaving" mode, which may be a day or up to a week, you
> delegate or postpone decisions and actions until you return: BTDTGTS (Got The
> Scars) ;^>
I hear you.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-07 18:20 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 16:13 Steven Penny
2018-09-01 18:11 ` Thomas Wolff
2018-09-01 18:46 ` Steven Penny
2018-09-01 21:07 ` Thomas Wolff
2018-09-01 19:40 ` Corinna Vinschen
2018-09-01 21:50 ` Doug Henderson
2018-09-01 22:49 ` Steven Penny
2018-09-02 8:07 ` Thomas Wolff
2018-09-02 12:51 ` Steven Penny
2018-09-03 12:46 ` Corinna Vinschen
2018-09-03 14:59 ` Corinna Vinschen
2018-09-03 16:34 ` Thomas Wolff
2018-09-03 17:17 ` Corinna Vinschen
2018-09-03 17:56 ` Thomas Wolff
2018-09-03 18:20 ` Thomas Wolff
2018-09-03 19:14 ` Corinna Vinschen
2018-09-03 20:27 ` Corinna Vinschen
2018-09-03 20:42 ` Thomas Wolff
2018-09-03 21:03 ` Corinna Vinschen
2018-09-03 22:15 ` Steven Penny
2018-09-04 6:06 ` Brian Inglis
2018-09-04 9:00 ` Corinna Vinschen
2018-09-04 11:40 ` Steven Penny
2018-09-05 7:55 ` Corinna Vinschen
2018-09-05 9:22 ` Thomas Wolff
2018-09-05 11:58 ` Steven Penny
2018-09-05 13:18 ` Marco Atzeri
2018-09-05 15:20 ` Andrey Repin
2018-09-05 15:58 ` Corinna Vinschen
2018-09-05 20:15 ` Corinna Vinschen
2018-09-06 1:35 ` Steven Penny
2018-09-06 7:01 ` Corinna Vinschen
2018-09-07 8:20 ` Corinna Vinschen
2018-09-07 10:34 ` Thomas Wolff
2018-09-07 11:29 ` Corinna Vinschen
2018-09-07 11:42 ` Thomas Wolff
2018-09-07 11:51 ` Thomas Wolff
2018-09-07 11:54 ` Corinna Vinschen
2018-09-07 16:22 ` Brian Inglis
2018-09-07 16:48 ` Brian Inglis
2018-09-07 17:01 ` Marco Atzeri
2018-09-07 18:21 ` Corinna Vinschen
2018-09-07 18:20 ` Corinna Vinschen [this message]
2018-09-05 13:35 ` Andrey Repin
2018-09-05 14:04 ` Houder
2018-09-05 15:05 ` Andrey Repin
2018-09-04 12:50 ` David Macek
2018-09-04 14:18 ` Thomas Wolff
2018-09-04 14:46 ` David Macek
2018-09-04 18:20 ` Steven Penny
2018-09-04 18:41 ` Thomas Wolff
2018-09-04 19:50 ` Andrey Repin
2018-09-04 19:53 ` Steven Penny
2018-09-04 21:43 ` Thomas Wolff
2018-09-04 23:29 ` Steven Penny
2018-09-04 20:40 ` Brian Inglis
2018-09-05 8:32 ` Corinna Vinschen
2018-09-04 13:05 ` Andrey Repin
2018-10-04 0:25 ` Steven Penny
2018-09-03 16:05 ` Brian Inglis
2018-09-04 19:59 ` Doug Henderson
2018-09-04 21:05 ` Steven Penny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907182028.GW6350@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).