From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Houder <houder@xs4all.nl>
Cc: cygwin@cygwin.com, eblake@redhat.com
Subject: Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ...
Date: Mon, 02 Sep 2019 08:15:00 -0000 [thread overview]
Message-ID: <20190902081508.GB4164@calimero.vinschen.de> (raw)
In-Reply-To: <e438666b60ee08a2a3ee4ca16015382f@smtp-cloud9.xs4all.net>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Sep 1 19:38, Houder wrote:
> On Fri, 30 Aug 2019 11:54:27, Houder wrote:
>
> > A trailing forward slash in "pathname" is stripped in path_conv::check,
> >
> > (look for: *--tail = '\0' )
> >
> > after "pathname" has been normalized in
> >
> > normalized_posix_path or normalized_win32_path (or both),
> >
> > before it is fed into conv_to_win32_path.
> >
> > Tests have shown that Eric's code snippet can be deleted w/o harm.
> >
> > Counter arguments?
>
> Hi Corinna,
>
> My last post in this issue.
>
> As reported, Eric's code snippet in rmdir() (dir.cc) has become
> redundant, lines 317 - 325 can be removed.
This is what I'm not entirely sure about. There's some kind of
bordercase and as soon as we release Cygwin with this change,
as chance would have it somebody will report a problem.
I'm not opposed to removing this code, but I'd like to get Eric's
input on this.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-02 8:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 15:25 Houder
2019-08-27 16:28 ` Corinna Vinschen
2019-08-27 17:01 ` Houder
2019-08-27 17:32 ` Vince Rice
2019-08-27 17:50 ` Corinna Vinschen
2019-08-28 7:16 ` Houder
2019-08-28 9:22 ` john doe
2019-08-28 11:47 ` Houder
2019-08-28 13:22 ` Corinna Vinschen
2019-08-28 14:16 ` Eric Blake
2019-08-28 14:22 ` Corinna Vinschen
2019-08-28 15:18 ` Corinna Vinschen
2019-08-29 15:19 ` Houder
2019-08-30 8:20 ` Corinna Vinschen
2019-08-30 12:42 ` Houder
2019-09-01 17:38 ` Houder
2019-09-02 8:15 ` Corinna Vinschen [this message]
2019-09-03 8:40 ` Houder
2019-09-03 6:50 ` Andrey Repin
2019-09-19 19:51 ` Ken Brown
2019-09-20 9:11 ` Houder
2019-09-20 18:20 ` Houder
2019-09-21 16:07 ` Ken Brown
2019-09-22 7:34 ` Houder
2019-09-22 14:12 ` Ken Brown
2019-09-07 3:47 ` L A Walsh
2019-08-27 19:48 ` Achim Gratz
2019-08-27 20:58 ` Brian Inglis
2019-08-28 7:16 ` Corinna Vinschen
2019-08-27 22:21 ` Achim Gratz
2019-08-28 13:36 ` Eric Blake
2019-08-28 22:57 ` Houder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902081508.GB4164@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=eblake@redhat.com \
--cc=houder@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).