Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ...

[Houder <houder@xs4all.nl>]

On Wed, 28 Aug 2019 16:22:20, Corinna Vinschen  wrote:

> > As simple as that?
> >
> > diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
> > index b757851d5c7f..747b1582af50 100644
> > --- a/winsup/cygwin/dir.cc
> > +++ b/winsup/cygwin/dir.cc
> > @@ -314,13 +314,13 @@ mkdir (const char *dir, mode_t mode)
> >  	  set_errno (ENOENT);
> >  	  __leave;
> >  	}
> > -      if (isdirsep (dir[strlen (dir) - 1]))
> > +      if (dir[strlen (dir) - 1] =3D=3D '/')
> >  	{
> >  	  /* This converts // to /, but since both give EEXIST, we're okay.  */
> >  	  char *buf;
> >  	  char *p =3D stpcpy (buf =3D tp.c_get (), dir) - 1;
> >  	  dir =3D buf;
> > -	  while (p > dir && isdirsep (*p))
> > +	  while (p > dir && *p =3D=3D '/')
> >  	    *p-- =3D '\0';
> >  	}
> >        if (!(fh =3D build_fh_name (dir, PC_SYM_NOFOLLOW)))
> 
> One problem here is, what to do about border cases like
> 
>   $ mkdir a\/\/\/
> 
> In theory slashes and backslashes should both be treated as dir
> separators.  Handling a case like this so that all expectations
> are satisfied is next to impossible, I guess.

How about dropping Eric's code snippet in winsup/cygwin/dir.cc ?????

Subdirectory 'a' is created. No problem there. Perhaps the patch has
become superfluous/ redundant over time?

I have tried different "values" for the path-argument to mkdir, and
have not found a problem while the code snippet is being skipped.

What am I missing?

Henri

-----
Breakpoint 1 at 0x1800548b9: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc, line 317.
Breakpoint 2 at 0x1800548e3: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc, line 326.
(gdb) r
Starting program: /usr/bin/mkdir 'a\/\/\/'
[New Thread 1064.0x1a8c]
[New Thread 1064.0x59c]

Thread 1 "mkdir" hit Breakpoint 1, mkdir (dir=0x800041320 "a\\/\\/\\/", mode=511)
    at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:317
317           if (isdirsep (dir[strlen (dir) - 1]))
(gdb) j dir.cc:326
Continuing at 0x1800548e3.

Thread 1 "mkdir" hit Breakpoint 2, mkdir (dir=0x800041320 "a\\/\\/\\/", mode=511)
    at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:326
326           if (!(fh = build_fh_name (dir, PC_SYM_NOFOLLOW)))
(gdb) c
Continuing.
[Inferior 1 (process 1064) exited normally]
(gdb) quit

64-@@ ls -ld a*
drwxr-xr-x+ 1 Henri None 0 Aug 29 16:47 a

=====


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple