From: Houder <houder@xs4all.nl>
To: cygwin@cygwin.com
Subject: Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ...
Date: Fri, 20 Sep 2019 09:11:00 -0000 [thread overview]
Message-ID: <e7cb47be199186f3c7438a0bfcc8c7df@smtp-cloud7.xs4all.net> (raw)
In-Reply-To: <f77b318f-0c52-4b5f-3738-ff882804e84a@cornell.edu>
On Thu, 19 Sep 2019 18:04:47, Ken Brown wrote:
> On 9/1/2019 1:38 PM, Houder wrote:
> > On Fri, 30 Aug 2019 11:54:27, Houder wrote:
>
> [...]
>
> > As the directory "/foo" had been correctly created, I turned to
> > path_conv::check(), which is called when build_fhname() creates
> > the path_conv object (also called pc) -- see dtable.cc.
> >
> > Examining this (obsure) method in path.cc, I corrected the code
> > in 2 places:
> >
> > ---
> > if (dev.isfs ())
> > {
> > //if (strncmp (path, "\\\\.\\", 4)) <==== 1171
> > if ( ! strncmp (path, "\\\\.\\", 4)) // <==== [1]
> > {
> > if (!tail || tail == path)
> > /* nothing */;
> > else if (tail[-1] != '\\')
> > *tail = '\0'; <==== Ah! (you should not do that!)
> > else
> > {
> > error = ENOENT;
> > return;
> > }
> > }
> >
> > [1] this code should be executed only if path == '\\.\' !!
Sorry Ken, for not being correct ... Of course, the statement above tests
whether or not the string *** starts with *** \\.\
> I don't agree with your analysis here.
Analysis of what? No Ken, I did not _analyze_ what this piece of code is
good for.
I only discovered that it "mutilates" the code if one exexutes
mkdir /foo, where foo is a nonexisting directory
So, in general this piece of code should NOT be executed. And I doubt if
it is ever reached in case of a device path, like \\.\e: (did not check).
Btw, do not pay attention to the second correction (hack) that I made in
this method; I dropped it.
That said, my modifications to mkdir_2 and rmdir_2 are more relevant.
Currently, rmdir_2 is not in agreement with Posix (and Linux).
Currently I am running the modified code (including the above correction
in "path resolution" -- i.c. path_conv::check).
Found no problems. And my tests show that rmdir_2 is now in agreement w/
Posix (and Linux).
Oh sorry, mkdir_2 and rmdir_2 should be read as mkdir(2) and rmdir(2).
(the syscalls in dir.cc, not the functions in fhandler_disk_file.cc)
Henri
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2019-09-20 7:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 15:25 Houder
2019-08-27 16:28 ` Corinna Vinschen
2019-08-27 17:01 ` Houder
2019-08-27 17:32 ` Vince Rice
2019-08-27 17:50 ` Corinna Vinschen
2019-08-28 7:16 ` Houder
2019-08-28 9:22 ` john doe
2019-08-28 11:47 ` Houder
2019-08-28 13:22 ` Corinna Vinschen
2019-08-28 14:16 ` Eric Blake
2019-08-28 14:22 ` Corinna Vinschen
2019-08-28 15:18 ` Corinna Vinschen
2019-08-29 15:19 ` Houder
2019-08-30 8:20 ` Corinna Vinschen
2019-08-30 12:42 ` Houder
2019-09-01 17:38 ` Houder
2019-09-02 8:15 ` Corinna Vinschen
2019-09-03 8:40 ` Houder
2019-09-03 6:50 ` Andrey Repin
2019-09-19 19:51 ` Ken Brown
2019-09-20 9:11 ` Houder [this message]
2019-09-20 18:20 ` Houder
2019-09-21 16:07 ` Ken Brown
2019-09-22 7:34 ` Houder
2019-09-22 14:12 ` Ken Brown
2019-09-07 3:47 ` L A Walsh
2019-08-27 19:48 ` Achim Gratz
2019-08-27 20:58 ` Brian Inglis
2019-08-28 7:16 ` Corinna Vinschen
2019-08-27 22:21 ` Achim Gratz
2019-08-28 13:36 ` Eric Blake
2019-08-28 22:57 ` Houder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7cb47be199186f3c7438a0bfcc8c7df@smtp-cloud7.xs4all.net \
--to=houder@xs4all.nl \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).