fish Remove unneeded workarounds in /etc/fish/conf.d/cygwin.fish

fish Remove unneeded workarounds in /etc/fish/conf.d/cygwin.fish

[Whek rin]

The cygwin-specific file /etc/fish/config.d/cygwin.fish has this section:

# Work around an autocompletion bug, where fish tries to execute strings
# in parentheses in the PATH.  For example it tries to run the x86 function
# if it sees a PATH component like '/cygdrive/c/Program Files (x86)'.
# See https://github.com/fish-shell/fish-shell/issues/952#issuecomment-27499216
.
# Work around the most common cases here.

function R --description "print '(R)'"
echo '(R)'
end
function tm --description "print '(tm)'"
echo '(tm)'
end
function TM --description "print '(TM)'"
echo '(TM)'
end
function x86 --description "print '(x86)'"
echo '(x86)'
end
function X86 --description "print '(X86)'"
echo '(X86)'
end

This was to work around fish bug
https://github.com/fish-shell/fish-shell/issues/952. However, this bug
was fixed in version 2.3.0. I tested this quickly by removing the
workaround and fish seemed to complete paths swimmingly (heh).

I suggest this section is removed from fish-2.3.1 as these workarounds
are no longer needed.
Thanks, Matt

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: fish Remove unneeded workarounds in /etc/fish/conf.d/cygwin.fish

[Andrew Schulman]

> The cygwin-specific file /etc/fish/config.d/cygwin.fish has this section:
> 
> # Work around an autocompletion bug, where fish tries to execute strings
> # in parentheses in the PATH.  For example it tries to run the x86 function
> # if it sees a PATH component like '/cygdrive/c/Program Files (x86)'.
> # See https://github.com/fish-shell/fish-shell/issues/952#issuecomment-27499216
> .
> # Work around the most common cases here.
> 
> function R --description "print '(R)'"
> echo '(R)'
> end
> function tm --description "print '(tm)'"
> echo '(tm)'
> end
> function TM --description "print '(TM)'"
> echo '(TM)'
> end
> function x86 --description "print '(x86)'"
> echo '(x86)'
> end
> function X86 --description "print '(X86)'"
> echo '(X86)'
> end
> 
> This was to work around fish bug
> https://github.com/fish-shell/fish-shell/issues/952. However, this bug
> was fixed in version 2.3.0. I tested this quickly by removing the
> workaround and fish seemed to complete paths swimmingly (heh).
> 
> I suggest this section is removed from fish-2.3.1 as these workarounds
> are no longer needed.
> Thanks, Matt

Thanks for pointing that out. Yep, I checked and they don't seem to be needed
any more. I'll remove them and put out a new point release. Andrew


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple