setfacl -s acl_entries file file ... now fails ... Corinna?

setfacl -s acl_entries file file ... now fails ... Corinna?

[Houder]

Hi Corinna,

Regression? setfacl -s used to accept multiple file arguments ... (yes, I am sure)

@@ touch aap noot mies
@@ ls -l aap noot mies
-rw-r--r-- 1 Henri None 0 Feb 12 15:55 aap
-rw-r--r-- 1 Henri None 0 Feb 12 15:55 mies
-rw-r--r-- 1 Henri None 0 Feb 12 15:55 noot
@@ setfacl -s u::rwx,g::r-x,o:r-x aap noot mies
setfacl: Invalid argument
setfacl: Invalid argument
@@ setfacl -s u::rwx,g::r-x,o:r-x aap # euh, accepts only one file argument now?

setfacl -s used to work for multiple file arguments (yes, strangely enough, it did
not work for multiple directory arguments).

Did I miss something?

Henri


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: setfacl -s acl_entries file file ... now fails

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

On Feb 12 16:06, Houder wrote:
> Hi Corinna,
> 
> Regression? setfacl -s used to accept multiple file arguments ... (yes, I am sure)
> 
> @@ touch aap noot mies
> @@ ls -l aap noot mies
> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 aap
> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 mies
> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 noot
> @@ setfacl -s u::rwx,g::r-x,o:r-x aap noot mies
> setfacl: Invalid argument
> setfacl: Invalid argument

Yes, regression.  When revamping the acl(SETACL, ...) call I used
the a_type value in the incoming aclent_t entry for bookkeeping,
thus invalidating it for further reuse.  I fixed that in CVS and
uploaded a new snapshot on https://cygwin.com/snapshots/

Please give it a try.

Btw., it's really not necessary to address me directly in the subject of
a mail to this list.  I am reading this list regulary and I'm not
ignoring reports which look like a bug in Cygwin and least of all those
with testcases.  In fact, I'd prefer a subject not calling me out.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: setfacl -s acl_entries file file ... now fails

[Houder]

> On Feb 12 16:06, Houder wrote:
>> Hi Corinna,
>>
>> Regression? setfacl -s used to accept multiple file arguments ... (yes, I am sure)
>>
>> @@ touch aap noot mies
>> @@ ls -l aap noot mies
>> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 aap
>> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 mies
>> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 noot
>> @@ setfacl -s u::rwx,g::r-x,o:r-x aap noot mies
>> setfacl: Invalid argument
>> setfacl: Invalid argument
>
> Yes, regression.  When revamping the acl(SETACL, ...) call I used
> the a_type value in the incoming aclent_t entry for bookkeeping,
> thus invalidating it for further reuse.  I fixed that in CVS and
> uploaded a new snapshot on https://cygwin.com/snapshots/
>
> Please give it a try.

I did. Substituted cygwin1.dll for the one from the snapshot (0212).

Did some limited testing (as usual ;-).

As far far I can tell, is is now possible to specify multiple file
arguments again ...

As I was curious, I also did a test in which I specified multiple
directory arguments. Appeared to work as well. Splendid.

Thank you.

Henri


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: setfacl -s acl_entries file file ... now fails

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]

On Feb 13 00:19, Houder wrote:
> > On Feb 12 16:06, Houder wrote:
> >> Hi Corinna,
> >>
> >> Regression? setfacl -s used to accept multiple file arguments ... (yes, I am sure)
> >>
> >> @@ touch aap noot mies
> >> @@ ls -l aap noot mies
> >> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 aap
> >> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 mies
> >> -rw-r--r-- 1 Henri None 0 Feb 12 15:55 noot
> >> @@ setfacl -s u::rwx,g::r-x,o:r-x aap noot mies
> >> setfacl: Invalid argument
> >> setfacl: Invalid argument
> >
> > Yes, regression.  When revamping the acl(SETACL, ...) call I used
> > the a_type value in the incoming aclent_t entry for bookkeeping,
> > thus invalidating it for further reuse.  I fixed that in CVS and
> > uploaded a new snapshot on https://cygwin.com/snapshots/
> >
> > Please give it a try.
> 
> I did. Substituted cygwin1.dll for the one from the snapshot (0212).
> 
> Did some limited testing (as usual ;-).
> 
> As far far I can tell, is is now possible to specify multiple file
> arguments again ...
> 
> As I was curious, I also did a test in which I specified multiple
> directory arguments. Appeared to work as well. Splendid.

Cool, thanks for testing!


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]