From: Mark Wielaard <mark@klomp.org>
To: Kalev Lember <klember@redhat.com>
Cc: debugedit@sourceware.org
Subject: Re: [PATCH] find-debuginfo: Pass -j down to dwz
Date: Fri, 27 Jan 2023 00:14:35 +0100 [thread overview]
Message-ID: <20230126231435.GA21676@gnu.wildebeest.org> (raw)
In-Reply-To: <CAHjaNbrVQNhLdtJDdcg4gn3rFWh0KjYReavVjdNwLQDfp8UfWA@mail.gmail.com>
Hi Kalev,
On Thu, Jan 26, 2023 at 04:57:18PM +0100, Kalev Lember wrote:
> > I agree with Panu that a configure check would be nice to make sure the
> > installed dwz does support -j. Would the attached patch work for you?
> >
>
> That looks perfect to me. Thanks a lot!
Pushed as:
commit 5b23e464528ef988cfcd0a87b3ec8db0520db867
Author: Kalev Lember <klember@redhat.com>
Date: Thu Jan 19 17:03:18 2023 +0100
find-debuginfo: Pass -j down to dwz
Now that dwz 0.15 supports parallel jobs, add a way to control it from
here. find-debuginfo already has a -j parameter so we can just extend it
and pass the value down to dwz as well.
This should fix building large packages on memory constrained builders,
such as webkitgtk on s390x in Fedora koji build system, where we can now
use the -j option to tune down parallelism to avoid running out of
memory during dwz run.
Add a configure check to make sure the installed dwz supports the
-j option.
Signed-off-by: Kalev Lember <klember@redhat.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
> Can you also apply it to the rawhide package, please? That way I can
> confirm if it actually works on actual koji builders and see if we can get
> webkitgtk building right.
I will, but as you might have seen the rawhide buildbot just failed.
All others seem green, so it probably is the new gcc or some compiler
flag changes in fedora rawhide:
https://builder.sourceware.org/buildbot/#/changes/17730
As soon as I figure out how to get the testsuite green on rawhide I'll
also push this patch there.
Cheers,
Mark
next prev parent reply other threads:[~2023-01-26 23:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 16:03 Kalev Lember
2023-01-20 8:39 ` Panu Matilainen
2023-01-20 10:27 ` Kalev Lember
2023-01-20 11:27 ` Panu Matilainen
2023-01-26 14:34 ` Mark Wielaard
2023-01-26 15:57 ` Kalev Lember
2023-01-26 23:14 ` Mark Wielaard [this message]
2023-01-27 17:37 ` Mark Wielaard
2023-01-28 1:07 ` Kalev Lember
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126231435.GA21676@gnu.wildebeest.org \
--to=mark@klomp.org \
--cc=debugedit@sourceware.org \
--cc=klember@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).