Re: [PATCH] find-debuginfo: Pass -j down to dwz

[Panu Matilainen <pmatilai@redhat.com>]

On 1/19/23 18:03, Kalev Lember wrote:
> Now that dwz 0.15 supports parallel jobs, add a way to control it from
> here. find-debuginfo already has a -j parameter so we can just extend it
> and pass the value down to dwz as well.
> 
> This should fix building large packages on memory constrained builders,
> such as webkitgtk on s390x in Fedora koji build system, where we can now
> use the -j option to tune down parallelism to avoid running out of
> memory during dwz run.
> 
> Signed-off-by: Kalev Lember <klember@redhat.com>
> ---
>   scripts/find-debuginfo.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
> index b07a52f..8cc1bfd 100755
> --- a/scripts/find-debuginfo.in
> +++ b/scripts/find-debuginfo.in
> @@ -585,7 +585,7 @@ if $run_dwz \
>         dwz_multifile_suffix=".${dwz_multifile_idx}"
>       done
>       dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
> -    dwz_opts="-h -q -r"
> +    dwz_opts="-h -q -r -j ${n_jobs}"
>       [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ] \
>         && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
>       mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"

This is so new, even Fedora 37 doesn't have it yet. I tend to think 
find-debuginfo should be a bit conservative about the assumptions it 
makes about external tools.

	- Panu -