From: "Dmitry V. Levin" <ldv@altlinux.org>
To: debugedit@sourceware.org
Subject: Re: [PATCH 1/3] debugedit: skip .debug_types tests if compiler doesn't generate section
Date: Sat, 25 Mar 2023 14:30:43 +0300 [thread overview]
Message-ID: <20230325113043.GA19701@altlinux.org> (raw)
In-Reply-To: <20230324235807.2335399-1-mark@klomp.org>
On Sat, Mar 25, 2023 at 12:58:05AM +0100, Mark Wielaard wrote:
> Some compilers don't generate a .debug_types section even when compiling
> with -fdebug-types-section. Skip testing the .debug_types tests in that
> case.
>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
> tests/debugedit.at | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/debugedit.at b/tests/debugedit.at
> index 725e68e..0601127 100644
> --- a/tests/debugedit.at
> +++ b/tests/debugedit.at
> @@ -364,6 +364,7 @@ AT_CLEANUP
> AT_SETUP([debugedit .debug_types objects])
> AT_KEYWORDS([debugtypes] [debugedit])
> DEBUGEDIT_SETUP([-fdebug-types-section -gdwarf-4])
> +AT_SKIP_IF([! $READELF -S ./foo.o ./subdir_bar/bar.o ./baz.o | grep -q '.debug_types'])
Should it rather be grep -F -q?
--
ldv
next prev parent reply other threads:[~2023-03-25 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 23:58 Mark Wielaard
2023-03-24 23:58 ` [PATCH 2/3] debuginfo: check whether compiler needs -fdebug-macro Mark Wielaard
2023-03-24 23:58 ` [PATCH 3/3] debugedit: Simplify and extend .debug_line tests Mark Wielaard
2023-03-25 11:30 ` Dmitry V. Levin [this message]
2023-03-28 11:24 ` [PATCH 1/3] debugedit: skip .debug_types tests if compiler doesn't generate section Mark Wielaard
2023-04-21 12:46 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325113043.GA19701@altlinux.org \
--to=ldv@altlinux.org \
--cc=debugedit@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).